Re: [PATCH] Add support for Analog Devices Blackfin processor (part 6/6: src toplevel)

Daniel Jacobowitz
2006-01-20T23:25:34Z

On Wed, Jan 04, 2006 at 03:15:56PM +0800, Jie Zhang wrote:
> On 1/4/06, Jim Blandy <jimb@red-bean.com> wrote:
> > On 12/27/05, Jie Zhang <jzhang918@gmail.com> wrote:
> > > This final part only contains one line change in src top level
> > > configure, which will enable configure in gdb directory for bfin port.
> >
> > I think you want to post a patch to configure.in, not configure.
> > (It's preferred to omit the patches to configure scripts generated
> > from configure.in or configure.ac files when posting work for review.)
> > And the patch needs to go to binutils@sources.redhat.com, as well as
> > gdb-patches.
> >
> Here is the second patch, which is for configure.in, and also sent to
> binutils@sources.redhat.com. Sorry for not sending the first one to
> binutils mailing list.
>
> > The actual content of the change looks straightforward to me.
> >
> If it's also OK for binutils, I'll commit it along with other Blackfin
> gdb patches.

Sounds good.

> * configure.in: Configure gdb directory for bfin.

You may already know this, but you should also mention the generated
files in the changelog:

* configure: Regenerated.

And commit both.

--
Daniel Jacobowitz
CodeSourcery