From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7418 invoked by alias); 3 Jan 2006 23:15:45 -0000 Received: (qmail 7411 invoked by uid 22791); 3 Jan 2006 23:15:44 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 03 Jan 2006 23:15:42 +0000 Received: by zproxy.gmail.com with SMTP id x3so2835644nzd for ; Tue, 03 Jan 2006 15:15:40 -0800 (PST) Received: by 10.36.2.19 with SMTP id 19mr4469744nzb; Tue, 03 Jan 2006 15:15:39 -0800 (PST) Received: by 10.37.2.42 with HTTP; Tue, 3 Jan 2006 15:15:39 -0800 (PST) Message-ID: <8f2776cb0601031515m8ef145x5e23aa5f80644428@mail.gmail.com> Date: Tue, 03 Jan 2006 23:15:00 -0000 From: Jim Blandy To: fnf@specifix.com Subject: Re: [PATCH] Fix ptype problem printing typedefs defined differently in different compilation units Cc: gdb-patches@sourceware.org In-Reply-To: <200601031517.50309.fnf@specifix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200601031517.50309.fnf@specifix.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00016.txt.bz2 On 1/3/06, Fred Fish wrote: > The patch also adds a proposed fix for the problem, which is to look > in the current source symtab for the name, before scanning all the > symtabs. The test looks good; please commit that. I have some questions about the patch, though.=20 get_current_source_symtab_and_line is a user-interface thing, and I'm uncomfortable calling it from one of our fundamental lookup functions. Why isn't the right block being passed to lookup_symbol in the first place?