From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18933 invoked by alias); 2 Dec 2005 01:07:42 -0000 Received: (qmail 18921 invoked by uid 22791); 2 Dec 2005 01:07:37 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.198) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 02 Dec 2005 01:07:32 +0000 Received: by zproxy.gmail.com with SMTP id l1so415957nzf for ; Thu, 01 Dec 2005 17:07:26 -0800 (PST) Received: by 10.36.177.16 with SMTP id z16mr2121562nze; Thu, 01 Dec 2005 17:07:24 -0800 (PST) Received: by 10.37.2.6 with HTTP; Thu, 1 Dec 2005 17:07:24 -0800 (PST) Message-ID: <8f2776cb0512011707p120df411w3a685c453d4ec625@mail.gmail.com> Date: Fri, 02 Dec 2005 01:13:00 -0000 From: Jim Blandy To: pgilliam@us.ibm.com Subject: Re: [PATCH] add 'rs6000_in_function_epilogue_p()' Cc: gdb-patches@sources.redhat.com In-Reply-To: <200511301225.56802.pgilliam@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200511301225.56802.pgilliam@us.ibm.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-12/txt/msg00029.txt.bz2 Paul wanted to fast-track this patch, in hopes it could get into the 6.4 release. Joel, what are your thoughts? I think the best alternative to deprecated_read_memory_nobpt would be to actually call current_frame (this will be cheap, since we just called it in watchpoint_check, before calling gdbarch_in_function_epilogue_p) and then call safe_frame_unwind_memory. Whatever we do immediately, the underlying cause here is that unwinding isn't working at every instruction. If it were, then the call to frame_find_by_id would find the frame containing the watched variable, and watchpoint_check would correctly conclude that the variable was still in scope. Paul, does your test program have Dwarf CFI for the functions in question?