From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30423 invoked by alias); 30 Nov 2005 05:41:51 -0000 Received: (qmail 30416 invoked by uid 22791); 30 Nov 2005 05:41:50 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.206) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Nov 2005 05:41:50 +0000 Received: by zproxy.gmail.com with SMTP id l1so1405182nzf for ; Tue, 29 Nov 2005 21:41:48 -0800 (PST) Received: by 10.36.61.7 with SMTP id j7mr5396430nza; Tue, 29 Nov 2005 21:41:48 -0800 (PST) Received: by 10.37.2.35 with HTTP; Tue, 29 Nov 2005 21:41:48 -0800 (PST) Message-ID: <8f2776cb0511292141t2f9711a2l9633236db737e67b@mail.gmail.com> Date: Wed, 30 Nov 2005 13:59:00 -0000 From: Jim Blandy To: Andrew STUBBS Subject: Re: [PATCH] init-if-undefined command Cc: gdb-patches@sources.redhat.com In-Reply-To: <437B3E56.3080306@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <437B3E56.3080306@st.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00507.txt.bz2 On 11/16/05, Andrew STUBBS wrote: > + printf_unfiltered ("usage: init-if-undefined $ =3D \n"); Provide a full English sentence here, not a traditional Unix "usage:" thing= y. > + printf_unfiltered ("First parameter to init-if-undefined should be= a GDB variable\n"); This should be a full sentence, with a preceding "The" and a period. > + add_com ("init-if-undefined", class_vars, init_if_undefined_command, _= ("\ > +init-if-undefined =3D \n\ > +Ensure that an internal variable exists and set it to\n\ > +a given value if it does not.")); Use upper case for syntactic metavariables, like VAR and EXPR, not . Refer to the metavariables in the doc string: "Ensure that VAR ... and set it to the value of EXPR", etc.