From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8578 invoked by alias); 19 Nov 2005 19:15:20 -0000 Received: (qmail 8570 invoked by uid 22791); 19 Nov 2005 19:15:20 -0000 X-Spam-Check-By: sourceware.org Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.195) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 19 Nov 2005 19:15:19 +0000 Received: by zproxy.gmail.com with SMTP id l1so473874nzf for ; Sat, 19 Nov 2005 11:15:17 -0800 (PST) Received: by 10.36.133.15 with SMTP id g15mr1170083nzd; Sat, 19 Nov 2005 11:15:17 -0800 (PST) Received: by 10.37.2.35 with HTTP; Sat, 19 Nov 2005 11:15:17 -0800 (PST) Message-ID: <8f2776cb0511191115l7e52d993rb82efb944d27d3d1@mail.gmail.com> Date: Sun, 20 Nov 2005 05:44:00 -0000 From: Jim Blandy To: Eli Zaretskii , Michael Snyder Subject: Re: Fwd: Obvious: doc fix for 'struct memrange' in tracepoints.c Cc: gdb-patches@sources.redhat.com In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_5433_3526821.1132427717643" References: <8f2776cb0511181717k5b9bd035uc5ec857ea272a493@mail.gmail.com> <20051119012057.GA26596@nevyn.them.org> <8f2776cb0511181722h7f721b71uf4b94016e5a18da9@mail.gmail.com> <437E89C1.7050104@redhat.com> <8f2776cb0511182044r7a653ae5w46f3f2a1ddcaeec7@mail.gmail.com> <8f2776cb0511182045h5fe6b1a7ye0811b1bfaa74a59@mail.gmail.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00372.txt.bz2 ------=_Part_5433_3526821.1132427717643 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Content-length: 460 On 11/19/05, Eli Zaretskii wrote: > How about introducing a macro, so that the code speaks for itself? How does this look? gdb/ChangeLog: 2005-11-19 Jim Blandy * tracepoint.c (memrange_absolute): New enum constant. (struct memrange, memrange_cmp, add_memrange, collect_symbol, stringify_collection_list, encode_actions): Use it instead of '-1' to indicate an fixed-address memory range. (Suggested by Eli Zaretskii.) ------=_Part_5433_3526821.1132427717643 Content-Type: text/x-patch; name="jimb.gdb-tracepoints-memrange-absolute-enum.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="jimb.gdb-tracepoints-memrange-absolute-enum.patch" Content-length: 6776 Z2RiL0NoYW5nZUxvZzoKMjAwNS0xMS0xOSAgSmltIEJsYW5keSAgPGppbWJA cmVkaGF0LmNvbT4KCgkqIHRyYWNlcG9pbnQuYyAobWVtcmFuZ2VfYWJzb2x1 dGUpOiBOZXcgZW51bSBjb25zdGFudC4KCShzdHJ1Y3QgbWVtcmFuZ2UsIG1l bXJhbmdlX2NtcCwgYWRkX21lbXJhbmdlLCBjb2xsZWN0X3N5bWJvbCwKCXN0 cmluZ2lmeV9jb2xsZWN0aW9uX2xpc3QsIGVuY29kZV9hY3Rpb25zKTogVXNl IGl0IGluc3RlYWQgb2YgJy0xJwoJdG8gaW5kaWNhdGUgYW4gZml4ZWQtYWRk cmVzcyBtZW1vcnkgcmFuZ2UuCgkoU3VnZ2VzdGVkIGJ5IEVsaSBaYXJldHNr aWkuKQoKSW5kZXg6IGdkYi90cmFjZXBvaW50LmMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi90cmFjZXBvaW50 LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuODEKZGlmZiAtYyAtcCAtcjEu ODEgdHJhY2Vwb2ludC5jCioqKiBnZGIvdHJhY2Vwb2ludC5jCTE5IE5vdiAy MDA1IDE4OjU3OjI4IC0wMDAwCTEuODEKLS0tIGdkYi90cmFjZXBvaW50LmMJ MTkgTm92IDIwMDUgMTk6MTM6MjkgLTAwMDAKKioqKioqKioqKioqKioqIG1h a2VfY2xlYW51cF9mcmVlX2FjdGlvbnMgKHN0cnVjdCB0cmFjZXAKKioqIDEw NjksMTA3NyAqKioqCiAgICByZXR1cm4gbWFrZV9jbGVhbnVwIChkb19mcmVl X2FjdGlvbnNfY2xlYW51cCwgdCk7CiAgfQogIAogIHN0cnVjdCBtZW1yYW5n ZQogIHsKISAgIGludCB0eXBlOwkJLyogLTEgZm9yIGFic29sdXRlIG1lbW9y eSByYW5nZSwgZWxzZSBiYXNlcmVnIG51bWJlciAqLwogICAgYmZkX3NpZ25l ZF92bWEgc3RhcnQ7CiAgICBiZmRfc2lnbmVkX3ZtYSBlbmQ7CiAgfTsKLS0t IDEwNjksMTA4MiAtLS0tCiAgICByZXR1cm4gbWFrZV9jbGVhbnVwIChkb19m cmVlX2FjdGlvbnNfY2xlYW51cCwgdCk7CiAgfQogIAorIGVudW0geworICAg bWVtcmFuZ2VfYWJzb2x1dGUgPSAtMQorIH07CisgCiAgc3RydWN0IG1lbXJh bmdlCiAgewohICAgaW50IHR5cGU7CQkvKiBtZW1yYW5nZV9hYnNvbHV0ZSBm b3IgYWJzb2x1dGUgbWVtb3J5IHJhbmdlLAohICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGVsc2UgYmFzZXJlZyBudW1iZXIgKi8KICAgIGJmZF9zaWdu ZWRfdm1hIHN0YXJ0OwogICAgYmZkX3NpZ25lZF92bWEgZW5kOwogIH07Cioq KioqKioqKioqKioqKiBtZW1yYW5nZV9jbXAgKGNvbnN0IHZvaWQgKnZhLCBj b25zdCB2b2lkCioqKiAxMTAzLDExMDkgKioqKgogICAgICByZXR1cm4gLTE7 CiAgICBpZiAoYS0+dHlwZSA+IGItPnR5cGUpCiAgICAgIHJldHVybiAxOwoh ICAgaWYgKGEtPnR5cGUgPT0gMCkKICAgICAgewogICAgICAgIGlmICgoYmZk X3ZtYSkgYS0+c3RhcnQgPCAoYmZkX3ZtYSkgYi0+c3RhcnQpCiAgCXJldHVy biAtMTsKLS0tIDExMDgsMTExNCAtLS0tCiAgICAgIHJldHVybiAtMTsKICAg IGlmIChhLT50eXBlID4gYi0+dHlwZSkKICAgICAgcmV0dXJuIDE7CiEgICBp ZiAoYS0+dHlwZSA9PSBtZW1yYW5nZV9hYnNvbHV0ZSkKICAgICAgewogICAg ICAgIGlmICgoYmZkX3ZtYSkgYS0+c3RhcnQgPCAoYmZkX3ZtYSkgYi0+c3Rh cnQpCiAgCXJldHVybiAtMTsKKioqKioqKioqKioqKioqIGFkZF9tZW1yYW5n ZSAoc3RydWN0IGNvbGxlY3Rpb25fbGlzdCAqbWUKKioqIDExNzUsMTE4MSAq KioqCiAgICAgICAgcHJpbnRmX2ZpbHRlcmVkICgiLCVsZClcbiIsIGxlbik7 CiAgICAgIH0KICAKISAgIC8qIHR5cGU6IC0xID09IG1lbW9yeSwgbiA9PSBi YXNlcmVnICovCiAgICBtZW1yYW5nZXMtPmxpc3RbbWVtcmFuZ2VzLT5uZXh0 X21lbXJhbmdlXS50eXBlID0gdHlwZTsKICAgIC8qIGJhc2U6IGFkZHIgaWYg bWVtb3J5LCBvZmZzZXQgaWYgcmVnIHJlbGF0aXZlLiAgKi8KICAgIG1lbXJh bmdlcy0+bGlzdFttZW1yYW5nZXMtPm5leHRfbWVtcmFuZ2VdLnN0YXJ0ID0g YmFzZTsKLS0tIDExODAsMTE4NiAtLS0tCiAgICAgICAgcHJpbnRmX2ZpbHRl cmVkICgiLCVsZClcbiIsIGxlbik7CiAgICAgIH0KICAKISAgIC8qIHR5cGU6 IG1lbXJhbmdlX2Fic29sdXRlID09IG1lbW9yeSwgb3RoZXIgbiA9PSBiYXNl cmVnICovCiAgICBtZW1yYW5nZXMtPmxpc3RbbWVtcmFuZ2VzLT5uZXh0X21l bXJhbmdlXS50eXBlID0gdHlwZTsKICAgIC8qIGJhc2U6IGFkZHIgaWYgbWVt b3J5LCBvZmZzZXQgaWYgcmVnIHJlbGF0aXZlLiAgKi8KICAgIG1lbXJhbmdl cy0+bGlzdFttZW1yYW5nZXMtPm5leHRfbWVtcmFuZ2VdLnN0YXJ0ID0gYmFz ZTsKKioqKioqKioqKioqKioqIGFkZF9tZW1yYW5nZSAoc3RydWN0IGNvbGxl Y3Rpb25fbGlzdCAqbWUKKioqIDExODksMTE5NSAqKioqCiAgCQkJCSAgbWVt cmFuZ2VzLT5saXN0c2l6ZSk7CiAgICAgIH0KICAKISAgIGlmICh0eXBlICE9 IC0xKQkJLyogQmV0dGVyIGNvbGxlY3QgdGhlIGJhc2UgcmVnaXN0ZXIhICAq LwogICAgICBhZGRfcmVnaXN0ZXIgKG1lbXJhbmdlcywgdHlwZSk7CiAgfQog IAotLS0gMTE5NCwxMjAwIC0tLS0KICAJCQkJICBtZW1yYW5nZXMtPmxpc3Rz aXplKTsKICAgICAgfQogIAohICAgaWYgKHR5cGUgIT0gbWVtcmFuZ2VfYWJz b2x1dGUpCQkvKiBCZXR0ZXIgY29sbGVjdCB0aGUgYmFzZSByZWdpc3RlciEg ICovCiAgICAgIGFkZF9yZWdpc3RlciAobWVtcmFuZ2VzLCB0eXBlKTsKICB9 CiAgCioqKioqKioqKioqKioqKiBjb2xsZWN0X3N5bWJvbCAoc3RydWN0IGNv bGxlY3Rpb25fbGlzdCAqCioqKiAxMjI2LDEyMzIgKioqKgogIAkJCSAgIERF UFJFQ0FURURfU1lNQk9MX05BTUUgKHN5bSksIGxlbiwgCiAgCQkJICAgdG1w IC8qIGFkZHJlc3MgKi8pOwogIAl9CiEgICAgICAgYWRkX21lbXJhbmdlIChj b2xsZWN0LCAtMSwgb2Zmc2V0LCBsZW4pOwkvKiAtMSA9PSBtZW1vcnkgKi8K ICAgICAgICBicmVhazsKICAgICAgY2FzZSBMT0NfUkVHSVNURVI6CiAgICAg IGNhc2UgTE9DX1JFR1BBUk06Ci0tLSAxMjMxLDEyMzcgLS0tLQogIAkJCSAg IERFUFJFQ0FURURfU1lNQk9MX05BTUUgKHN5bSksIGxlbiwgCiAgCQkJICAg dG1wIC8qIGFkZHJlc3MgKi8pOwogIAl9CiEgICAgICAgYWRkX21lbXJhbmdl IChjb2xsZWN0LCBtZW1yYW5nZV9hYnNvbHV0ZSwgb2Zmc2V0LCBsZW4pOwog ICAgICAgIGJyZWFrOwogICAgICBjYXNlIExPQ19SRUdJU1RFUjoKICAgICAg Y2FzZSBMT0NfUkVHUEFSTToKKioqKioqKioqKioqKioqIHN0cmluZ2lmeV9j b2xsZWN0aW9uX2xpc3QgKHN0cnVjdCBjb2xsZWMKKioqIDE0NDEsMTQ0OSAq KioqCiAgICAgICAgICBiZmRfc2lnbmVkX3ZtYSBsZW5ndGggPSBsaXN0LT5s aXN0W2ldLmVuZCAtIGxpc3QtPmxpc3RbaV0uc3RhcnQ7CiAgCiAgICAgICAg ICAvKiBUaGUgIiVYIiBjb252ZXJzaW9uIHNwZWNpZmllciBleHBlY3RzIGFu IHVuc2lnbmVkIGFyZ3VtZW50LAohICAgICAgICAgICAgc28gcGFzc2luZyAt MSB0byBpdCBkaXJlY3RseSBnaXZlcyB5b3UgIkZGRkZGRkZGIiAob3IgbW9y ZSwKISAgICAgICAgICAgIGRlcGVuZGluZyBvbiBzaXplb2YgKHVuc2lnbmVk KSkuICBTcGVjaWFsLWNhc2UgaXQuICAqLwohICAgICAgICAgaWYgKGxpc3Qt Pmxpc3RbaV0udHlwZSA9PSAtMSkKICAgICAgICAgICAgc3ByaW50ZiAoZW5k LCAiTS0xLCVzLCVsWCIsIHRtcDIsIChsb25nKSBsZW5ndGgpOwogICAgICAg ICAgZWxzZQogICAgICAgICAgICBzcHJpbnRmIChlbmQsICJNJVgsJXMsJWxY IiwgbGlzdC0+bGlzdFtpXS50eXBlLCB0bXAyLCAobG9uZykgbGVuZ3RoKTsK LS0tIDE0NDYsMTQ1NSAtLS0tCiAgICAgICAgICBiZmRfc2lnbmVkX3ZtYSBs ZW5ndGggPSBsaXN0LT5saXN0W2ldLmVuZCAtIGxpc3QtPmxpc3RbaV0uc3Rh cnQ7CiAgCiAgICAgICAgICAvKiBUaGUgIiVYIiBjb252ZXJzaW9uIHNwZWNp ZmllciBleHBlY3RzIGFuIHVuc2lnbmVkIGFyZ3VtZW50LAohICAgICAgICAg ICAgc28gcGFzc2luZyAtMSAobWVtcmFuZ2VfYWJzb2x1dGUpIHRvIGl0IGRp cmVjdGx5IGdpdmVzIHlvdQohICAgICAgICAgICAgIkZGRkZGRkZGIiAob3Ig bW9yZSwgZGVwZW5kaW5nIG9uIHNpemVvZiAodW5zaWduZWQpKS4KISAgICAg ICAgICAgIFNwZWNpYWwtY2FzZSBpdC4gICovCiEgICAgICAgICBpZiAobGlz dC0+bGlzdFtpXS50eXBlID09IG1lbXJhbmdlX2Fic29sdXRlKQogICAgICAg ICAgICBzcHJpbnRmIChlbmQsICJNLTEsJXMsJWxYIiwgdG1wMiwgKGxvbmcp IGxlbmd0aCk7CiAgICAgICAgICBlbHNlCiAgICAgICAgICAgIHNwcmludGYg KGVuZCwgIk0lWCwlcywlbFgiLCBsaXN0LT5saXN0W2ldLnR5cGUsIHRtcDIs IChsb25nKSBsZW5ndGgpOwoqKioqKioqKioqKioqKiogZW5jb2RlX2FjdGlv bnMgKHN0cnVjdCB0cmFjZXBvaW50ICp0LCBjaAoqKiogMTYwNSwxNjExICoq KioKICAJCSAgICAgIHRlbXB2YWwgPSBldmFsdWF0ZV9leHByZXNzaW9uIChl eHApOwogIAkJICAgICAgYWRkciA9IFZBTFVFX0FERFJFU1MgKHRlbXB2YWwp ICsgdmFsdWVfb2Zmc2V0ICh0ZW1wdmFsKTsKICAJCSAgICAgIGxlbiA9IFRZ UEVfTEVOR1RIIChjaGVja190eXBlZGVmIChleHAtPmVsdHNbMV0udHlwZSkp OwohIAkJICAgICAgYWRkX21lbXJhbmdlIChjb2xsZWN0LCAtMSwgYWRkciwg bGVuKTsKICAJCSAgICAgIGJyZWFrOwogIAogIAkJICAgIGNhc2UgT1BfVkFS X1ZBTFVFOgotLS0gMTYxMSwxNjE3IC0tLS0KICAJCSAgICAgIHRlbXB2YWwg PSBldmFsdWF0ZV9leHByZXNzaW9uIChleHApOwogIAkJICAgICAgYWRkciA9 IFZBTFVFX0FERFJFU1MgKHRlbXB2YWwpICsgdmFsdWVfb2Zmc2V0ICh0ZW1w dmFsKTsKICAJCSAgICAgIGxlbiA9IFRZUEVfTEVOR1RIIChjaGVja190eXBl ZGVmIChleHAtPmVsdHNbMV0udHlwZSkpOwohIAkJICAgICAgYWRkX21lbXJh bmdlIChjb2xsZWN0LCBtZW1yYW5nZV9hYnNvbHV0ZSwgYWRkciwgbGVuKTsK ICAJCSAgICAgIGJyZWFrOwogIAogIAkJICAgIGNhc2UgT1BfVkFSX1ZBTFVF Ogo= ------=_Part_5433_3526821.1132427717643--