From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7144 invoked by alias); 13 Nov 2005 23:39:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7130 invoked by uid 22791); 13 Nov 2005 23:39:08 -0000 Received: from zproxy.gmail.com (HELO zproxy.gmail.com) (64.233.162.203) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 13 Nov 2005 23:39:08 +0000 Received: by zproxy.gmail.com with SMTP id l1so1166120nzf for ; Sun, 13 Nov 2005 15:39:06 -0800 (PST) Received: by 10.37.2.48 with SMTP id e48mr3545933nzi; Sun, 13 Nov 2005 15:39:06 -0800 (PST) Received: by 10.37.2.35 with HTTP; Sun, 13 Nov 2005 15:39:06 -0800 (PST) Message-ID: <8f2776cb0511131539j17ae5144n87b1aedab1fa420e@mail.gmail.com> Date: Mon, 14 Nov 2005 02:27:00 -0000 From: Jim Blandy To: Randolph Chung Subject: Re: [RFA/RFC] Support DW_OP_breg for tracepoints Cc: gdb-patches@sources.redhat.com In-Reply-To: <43775DDB.6020408@tausq.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <43775DDB.6020408@tausq.org> X-SW-Source: 2005-11/txt/msg00179.txt.bz2 On 11/13/05, Randolph Chung wrote: > Warning: I don't really understand how this works :-) > > On hppa-linux, when running gdb.trace/save-trace.exp, the test fails > because of: > > "Unsupported DWARF opcode in the location of q1" > > The opcode in question is "DW_OP_breg3". The attached patch attempts to > add support for DW_OP_breg0..DW_OP_breg31. With this patch hppa-linux > passes the testcase, although not really understanding DWARF-2 I am not > certain this is 100% correct. DWARF experts, comments appreciated. Why are you adding the offset twice? Is it just cut-and-paste from the DW_OP_fbreg code? That looks wrong, too. This code should go in ax-gdb.[ch]. That has a translator from GDB expressions to agent expressions; it would make sense to also have a translator from Dwarf expressions to agent expressions.