Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH, v2] Improve load command's help text
Date: Tue, 07 Feb 2017 11:12:00 -0000	[thread overview]
Message-ID: <8f18d4de-e91d-a781-e1eb-394d80c1d988@redhat.com> (raw)
In-Reply-To: <1483744529-22462-1-git-send-email-lgustavo@codesourcery.com>

I suspect that the reason these weren't originally mentioned
in the help was/is that the accepted arguments depend on target.

Back when we had support for a bunch of different remote
targets, we had more target_load implementations.
Nowadays, there's much fewer targets, though still a couple
load implemenations:

 $ grep "[.\->]to_load = " *
 remote.c:  remote_ops.to_load = remote_load;
 remote-sim.c:  gdbsim_ops.to_load = gdbsim_load;

remote_load calls generic_load, which accepts the offset.
gdbsim_load doesn't support an offset, but understands that
what comes after the filename is an offset.

(we could probably factor out more bits from those
two implementations to load_command.)

> -@kindex load @var{filename}
> -@item load @var{filename}
> +@kindex load @var{filename} @var{offset}
> +@item load @var{filename} @var{offset}
>  @anchor{load}
>  Depending on what remote debugging facilities are configured into
>  @value{GDBN}, the @code{load} command may be available.  Where it exists, it
> @@ -19611,6 +19611,10 @@ link the program; for other formats, like a.out, the object file format
>  specifies a fixed address.
>  @c FIXME! This would be a good place for an xref to the GNU linker doc.
>  
> +It is also possible to tell @value{GDBN} to load the symbol file at a specific

executable file, not symbol file.

> +offset described by the optional argument @var{offset}.  When @var{offset} is
> +provided, @var{filename} must also be provided.

LGTM with that, but Eli should review this.

Thanks,
Pedro Alves


  parent reply	other threads:[~2017-02-07 11:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 23:15 Luis Machado
2017-01-17 13:08 ` Luis Machado
2017-01-24 16:22   ` Luis Machado
2017-02-07 10:21 ` Luis Machado
2017-02-07 15:53   ` Eli Zaretskii
2017-02-07 11:12 ` Pedro Alves [this message]
2017-02-13 13:32   ` Luis Machado
2017-02-13 14:57     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f18d4de-e91d-a781-e1eb-394d80c1d988@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox