From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/7] Add "help news"
Date: Mon, 6 Jul 2020 10:06:02 -0400 [thread overview]
Message-ID: <8f06b5c2-829d-9baa-910e-fbc8dcf1748b@simark.ca> (raw)
In-Reply-To: <20200623132006.15863-3-tom@tromey.com>
On 2020-06-23 9:20 a.m., Tom Tromey wrote:
> This adds a "help news" subcommand, which simply dumps the NEWS file.
> The NEWS file is now installed.
(1) I first tried "help news" with GDB in its build directory without passing
--data-directory, expecting it to fail, just to see how it would fail. It
says:
(gdb) help news
could not open the NEWS file: No such file or directory.
Maybe this message should say which path it's trying to open. If this
happens, the cause would probably be a broken GDB installation, and it
would be useful to know where is GDB looking for that file.
(2) When trying to "make install", I get this error:
$ make install DESTDIR=/tmp/install
...
make[4]: *** No rule to make target 'install-news', needed by 'install-only'. Stop.
Indeed, the install-news target is used but does not exist.
(3) Since we look for the NEWS file at <data-directory>/NEWS, I presume it won't
work when running GDB in its build directory, either with
./gdb --data-directory=data-directory
or
make run
since the NEWS file is not there. It's not a big deal, but if you think of an easy
way to make it work, it would be nice. Can we put a symlink from data-directory/NEWS
to NEWS?
(4) I tried what I mentioned just above and I get some sanitizer error:
$ ./gdb -q -nx --data-directory=data-directory
(gdb) help news
/home/simark/src/binutils-gdb/gdb/cli/cli-decode.c:1214:60: runtime error: index 1024 out of bounds for type 'char [1024]'
Not sure if it's ASan or UBSan.
Simon
next prev parent reply other threads:[~2020-07-06 14:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 13:19 [PATCH v2 0/7] Some user-friendliness changes Tom Tromey
2020-06-23 13:20 ` [PATCH v2 1/7] Introduce read_entire_file Tom Tromey
2020-07-06 13:47 ` Simon Marchi
2020-10-02 10:24 ` Andrew Burgess
2020-06-23 13:20 ` [PATCH v2 2/7] Add "help news" Tom Tromey
2020-06-23 14:35 ` Eli Zaretskii
2020-06-23 18:18 ` Christian Biesinger
2020-07-05 15:59 ` Tom Tromey
2020-07-06 14:14 ` Simon Marchi
2020-07-11 15:30 ` Tom Tromey
2020-07-06 14:06 ` Simon Marchi [this message]
2020-07-06 14:18 ` Simon Marchi
2020-07-11 15:56 ` Tom Tromey
2020-07-06 14:22 ` Simon Marchi
2020-07-11 15:31 ` Tom Tromey
2020-06-23 13:20 ` [PATCH v2 3/7] Add "tips" file to gdb Tom Tromey
2020-06-23 14:36 ` Eli Zaretskii
2020-07-06 14:27 ` Simon Marchi
2020-06-23 13:20 ` [PATCH v2 4/7] Add get_standard_config_dir function Tom Tromey
2020-06-23 13:20 ` [PATCH v2 5/7] Add early startup command file Tom Tromey
2020-07-05 18:51 ` Tom Tromey
2020-08-26 15:47 ` Andrew Burgess
2020-08-27 16:32 ` Andrew Burgess
2020-06-23 13:20 ` [PATCH v2 6/7] Let the user control the startup style Tom Tromey
2020-06-23 14:41 ` Eli Zaretskii
2020-07-05 18:50 ` Tom Tromey
2020-07-05 19:02 ` Eli Zaretskii
2020-06-23 13:20 ` [PATCH v2 7/7] Add "set startup-quietly" Tom Tromey
2020-06-23 14:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f06b5c2-829d-9baa-910e-fbc8dcf1748b@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox