Re: [PATCH v2 09/28] Remove dwarf2_per_cu_data::mark

Tom Tromey
2025-04-21T15:39:11Z

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> Can you choose a different name for these "marked" parameters? That
Simon> name doesn't convey what a mark means. Perhaps "visited_cus", or
Simon> something like that.

I used cus_to_skip.

"visited" won't really be accurate by the end of the series, because by
then a CU that's already expanded will still be searched.

Simon> Also, does the "marked" in "dw2_expand_marked_cus" have the same meaning
Simon> as the "marked" that changed meaning in this patch? If so, does this
Simon> function need to be renamed (does it do the opposite of the what its
Simon> name imply now)?

I think that is what it mean, and furthermore the function seems
mis-named in other ways, since it isn't primarily concerned with marked
CUs so much as deciding which CUs to expand.

However I would rather not bother to rename it at this point, since it's
deleted entirely in a subsequent patch in the series.

Tom