From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82512 invoked by alias); 15 Aug 2019 17:58:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82500 invoked by uid 89); 15 Aug 2019 17:58:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=consuming, UD:gdb.log, gdblog, gdb.log X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 17:58:17 +0000 Received: by mail-wr1-f66.google.com with SMTP id q12so2938552wrj.12 for ; Thu, 15 Aug 2019 10:58:17 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id m6sm2548605wrq.95.2019.08.15.10.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2019 10:58:15 -0700 (PDT) Subject: Re: [PATCH] Increase timeout in gdb.mi/list-thread-groups-available.exp To: Simon Marchi , gdb-patches@sourceware.org References: <20190801143855.1640-1-simon.marchi@efficios.com> Cc: Tom de Vries From: Pedro Alves Message-ID: <8ee6182c-c8cf-6bdd-4148-bca0b0bc6434@redhat.com> Date: Thu, 15 Aug 2019 17:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190801143855.1640-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-08/txt/msg00341.txt.bz2 On 8/1/19 3:38 PM, Simon Marchi wrote: > Running > > make check-read1 TESTS="gdb.mi/list-thread-groups-available.exp" > > on my machine results in timeout failures. Running it while having > `tail -F testsuite/gdb.log` on the side shows that the test is never > really blocked, it is just slow at consuming the large output generated > by `-list-thread-groups --available` (which lists all the processes on > the system). > > If I increase the timeout to a large value, the test passes in ~30 > seconds (compared to under 1 second normally). > > Increase the timeout for the particular mi_gdb_test that is long to > execute under read1. The new timeout value is a bit arbitrary. The > default timeout is 10 seconds, so I set the new timeout to be > "old-timeout * 10", so 100 seconds in the typical case. > > gdb/testsuite/ChangeLog: > > PR gdb/24863 > * gdb.mi/list-thread-groups-available.exp: Increase timeout for > -list-thread-groups --available test. A better approach to fix this is match a line at a time using gdb_test_multiple and exp_continue. -re "$process_entry_re" { exp_continue } No need to bump the timeout that way, since by default exp_continue resets the timeout timer. Thanks, Pedro Alves