From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70597 invoked by alias); 10 Jan 2017 15:20:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70558 invoked by uid 89); 10 Jan 2017 15:20:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_50 autolearn=ham version=3.3.2 spammy=4.3, 975, Hx-languages-length:2163, stackc X-HELO: sessmg23.ericsson.net Received: from sessmg23.ericsson.net (HELO sessmg23.ericsson.net) (193.180.251.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jan 2017 15:20:16 +0000 Received: from ESESSHC019.ericsson.se (Unknown_Domain [153.88.183.75]) by (Symantec Mail Security) with SMTP id E3.30.22046.EABF4785; Tue, 10 Jan 2017 16:20:14 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Jan 2017 16:20:27 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.50.115] (192.75.88.130) by DBXPR07MB398.eurprd07.prod.outlook.com (10.141.14.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.845.6; Tue, 10 Jan 2017 15:19:40 +0000 Subject: Re: [PATCH] Update help of the "frame" command To: Yao Qi , Simon Marchi References: <20170106151610.28872-1-simon.marchi@ericsson.com> <20170109172726.GA9518@E107787-LIN> <47dca06e2fcc932db67832e6c1867e92@polymtl.ca> <20170110110032.GE9518@E107787-LIN> CC: From: Simon Marchi Message-ID: <8ee30316-2e82-b514-7a49-30325fe60793@ericsson.com> Date: Tue, 10 Jan 2017 15:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170110110032.GE9518@E107787-LIN> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CY1PR20CA0083.namprd20.prod.outlook.com (10.163.250.51) To DBXPR07MB398.eurprd07.prod.outlook.com (10.141.14.148) X-MS-Office365-Filtering-Correlation-Id: 665386bb-9fb9-4382-4321-08d4396c195e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DBXPR07MB398; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB398;3:/7cdg+bTgY6NN6DxGiknvybDzQRYrp5UYTlsvjFQgTCZCNjue1sA8gDVDdIE5JKhhAeQQzPLu/Zs3I3ioR2dLHxMRtGU3ksgywlV7AZ+mrZARWqvXVjn5rXdqdbOxvv3+y1yovn3QlEwi0nldxRrAhN+cTlsglnLZ7RwwiDHeOiHeD5g/quzZfh5wnqBVYma5mwTkgsrjwgFvj1VxKbNmuDHUG2klUaDaWNzPwwkZZS1ntYqujRxK2ut+jyivIWUfnCHG7LbaaHNZSNECYCFQw== X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB398;25:MX58JY7tzMjD1ciwdqxxCkvdd+cjaEibsaefPFSLdm+pCnAVD5T+2WqIUOsb20kstPpsvyysSdNH3dPl2ytQSQBdykeFzIDmjMO4yxxDGwtne0CD2t0ldljVeO0hBKsFF+D/u5WGK3uNXu0jJjDZdipqsc+15IvIqx8BNXn6EDYdbpbBaI/vpz897PczwScWzzuhGo/PqdXz78c4ZWcrrXugwWTWxp+Cl/MxrT41j/MAJHWT4xJMOtNUWJMzll5pjL179+1SRimSqRmim7MpgZRs5K7IgUgsrpFvJ1WI4mGLqb4XIlSCxC8fBkyP3HNvtG0hA2r8qDIUvZZiBLtnAYPtXzY5x7NEvad3CE5tFDjNki8bY+piuqAX4jsNmDJB1jaYuSeoO0i0I1xfCjq9b7fLyZ6nt/27ETFa0yL1h/dSPio7SY30mDmswDsFFGlRSzIg7oCJTqcPDA1TmjMmhR7cd+DAl7PqqqLTpvvm8Rt1S0ovpY3JhZ3XqzjSaOXiQ3nTnReeKstIfgOGvVSDqtPf93DKPAYUPuWOSnlAnDh7hvLnSyTLT03PKK8PE97ZfyhnsMSih1JTFs9543YSJHD7exyZJxn5t7ZsMmYrs3h7Z+9w+LRFGbGFosrYqmyFXJP3mKtDAt7ayhJ+iNZXf/NS1oYt9ZxJscGkpZTDZ6SdaMAXN/aCyTZ4gfeCE7OeD5yUDJoiNE9qMDGgH59plPNdcSAh4xm6fabe3E4hjsDxIARTt6TsSRH+LFBxLZ5L X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB398;31:meP7X/OK1pigfse2NNfYnJqWxt4BK0pVZQ2T0jM+v3gyiqLrh2dmM+mB9NNaLJM+8/MpJkaMBklz6uDdIZs0BO+zQhbGpBeF3fClRmzBgbaoGtF4Sv+QBKE+HRmeUD9IFcJBUlrw1ppZFD/a7u0Os8caSKzRN4PI+imieeS8r8eXAzR6WxpT0fpobdai4Rcn4dJGHUSXH4MOVrNXE/kg3MsTlbYmrc0+O3ok5+kDjhKHhDIcMo5Dbe2vRtBeEOLrauFPsPIZjNvlAeovxL0YUusuxKHXEsboEqza0NlDz5YThuXhjujxYn2nRcLH0ZpP;20:BYZgmVqYiM/IL1knt1007qzJClzLyDGTUx93fY1GNyjIEoRzLFNHnrbdLBiujLmI8VSYVqV7h/8va3rvPAtHI/qb4WwJo4H0yENyHRxRx+m5h0rhkGMQs8fv1/kZhlXruhvRxZzOgzB9TXTCv7FBCmBMQEeQu/kQjsxmirHNl9gn+Q2ekH9Qg3ftVaLxwFU0l64f90M8QzmPNFanQF0N9DsKW7jslH34cntP08UU8cZ5utHNsYdHEbjtyZdl6Fl8zDF/oHarVvXx+iznKRVSjMICbaye1wvmqmik408a2u2suDYMSXG4pVcR9x8auREV5vxA3voxm6QcpX9B6xa+3QBcgTxBU5Ps+FpWIOP3xAz5xCRUNlyvMD0PYPEVKIsbeCztBoxwW+Vy7YnHPiQV0Uu8hsojOkFOWtCjKMrsZwVXAe01WiM6cf65pna4CfO2/fMmzTIM7EyyFTsiNtEWxHFBgs7tsB8D75SDo8GlDZY2912vk/C95J32D6Uy1zsQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:DBXPR07MB398;BCL:0;PCL:0;RULEID:;SRVR:DBXPR07MB398; X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB398;4:DY2+mjkepbt4SU92nkWspqpRq3SpjXiZZ7bDVH0QXqgtCjvWNSDZqk3MEJ/iIFoOGZIrFnn84xlm0QAxFPJhS1jJVc3Orf3gVuJ7c7avmIb5eWzADJXBYF4jJjZBnx7EXxAtaUUZq7BQ0hOFfmTWhOATGGPkKthQ6OZ+fOyy+Dq+QV6M8fnmjyxS1ACN/U5spCtRFbqRwVC0RAK+CbQfOzJAMaHhBuJhjxNH+ghQF2r68eNk99enVpcvirJBdrUAEXuHCkKg4woNl514eJtoPtN5zvy0q9YMWWNoH8PxiRqiU8YcakJ43RCkBfphPkhUkQBjo1nK4G7buWfaLJ9OK2QU13xw3PeTJMIEYnSdsux06GhaD0dIs68pPL22hFzO5DJhKqUIhMjAykNVnlUXdOnePf9aOUS2IJBjWrcpaBbWFf2eskhDDhUFnoyvAwOKZiYzNFNuWVb3lcaOvTv11VDi6/vEp9eZQVt4FWnjquOuWl3nv2hUrp8I9xTKD9/thkG3tHLjFSfHd+Wvnl1iW3AAgCvx+0gfI7+8YIzceH1XCyBHJ4IWfGH6Ia4mDfeNhMpF6JzYgg4PDVAg7LjI+Q== X-Forefront-PRVS: 01834E39B7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39450400003)(377454003)(377424004)(199003)(189002)(24454002)(229853002)(86362001)(54356999)(64126003)(42186005)(2950100002)(6666003)(68736007)(7736002)(50986999)(50466002)(305945005)(76176999)(101416001)(4001350100001)(97736004)(5001770100001)(189998001)(31696002)(33646002)(105586002)(8676002)(81156014)(81166006)(5660300001)(36756003)(6116002)(106356001)(3846002)(230700001)(66066001)(47776003)(65806001)(65956001)(31686004)(93886004)(65826007)(23676002)(83506001)(90366009)(2906002)(25786008)(4326007)(39060400001)(92566002)(6486002)(38730400001);DIR:OUT;SFP:1101;SCL:1;SRVR:DBXPR07MB398;H:[142.133.50.115];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQlhQUjA3TUIzOTg7MjM6T0s1MXc0UkY3ckczNjU5c2M1VVVVV3BIYjc0?= =?utf-8?B?UGd1NVZrcCtKV3BxdzdWdGJsdWp1RDZqWGthZFJGdTNMR1o5YlVZVUJ3dWM2?= =?utf-8?B?Z1NUUDlCTXdoTktSaGYxRWNGVUwzL2x0c3BpOS9GU2hldTMrK21zK0hjbkMw?= =?utf-8?B?OWdlbTV4Z3hUNFB6Q2lRSFhINTczcXUySWx1MzBEQnJacGwxMCtvQ09BeElL?= =?utf-8?B?VjY4VDVJa2lBOFdtYnUvWTBkVmJYWElEcnJCVERQMFg0dmZEYVdVeEdTN0to?= =?utf-8?B?elh0NzdXVWVUSVkzcU9nT2todWp1Ri9NdHlkaU9zYVlxbTFVWGlablhDM0Ra?= =?utf-8?B?Q2ovSzEyaUE4MkRSY2NnbGtEOXY1SnA4MHZleFhsYklMSVVyQWhPbHpqZzVa?= =?utf-8?B?b2FSdjg1OFMyZnhmSFlTUktpQU1sRnBLSXRmeThwWVZXM3ZOQmdja0VEWWR6?= =?utf-8?B?b2FvSTVEZDYvRTFtTy9kN3d5MG1lU0EvS0cyUFp1YTVYYXhnajE1ejd2UXkv?= =?utf-8?B?M2dnZy80RWVZcCtNeWREc0lBY2hiUEJ1QmpKVHhaL2krb0l3cEhXdDB2K0pY?= =?utf-8?B?d0YyOW82RE1CemRzQi8xTWFnT2dhVGNaSGM3M01FQkc5VFZVMitXTFgxbXh3?= =?utf-8?B?WlVSSldneEc3bHgzVXJBVzlJYW4rZVk1L0hDY1NJaE9jSE9IZVNWTjZraG5Y?= =?utf-8?B?a3F5UGpjWjdnUnJsbjA4cXhVUktEMXh3cVZ2SkRoNXhJcWZHekk2SGNIOWcr?= =?utf-8?B?T3hXR3pVNVowVzd6RkZkaEdtYlNBK0pWTnVSS2pVbDMwdDk1L1Myd1VlQkVF?= =?utf-8?B?dTNWeGZYTVlkTG9GL09mdFhHWlRwN1NFSzM3OHh5dzBORnZhV2pBTXZVeFRK?= =?utf-8?B?WjZlTnIxczMraDdGVDNib01HZktkd1FRQ0kyMWM2bCtqTnpYWTdNRlpDNnBF?= =?utf-8?B?NU1Dc0dJUDJoV1UyUUQvcFpnY3Iyd3hlZXZrQ2dqMDdWMHJzZkFhQ05Td3Mw?= =?utf-8?B?QXNGSTNVaW1DWEI4M2dlcEUzYXpnRXh5Z29jU0ZQb2xRKzhOOXFBd1kxMmNi?= =?utf-8?B?aGMwRlRldWZBS3lsMG5vQXRZMDhPVFAvQitxMC9EVTNqWDlKTjdsbTJxV1Y4?= =?utf-8?B?bHJ5K2NnN2puMjJkdlBhOVVUNEN4Ry83bktualErVElqRkpzKzliV0ZJUzRl?= =?utf-8?B?dGs4WXlUQlQ2Y005b2tyUmFIaHRBUXptT2lBTHpKUmRKeHRHQjI0NVphMUhw?= =?utf-8?B?Qm5tQXhjSGlLaDBPcUZNOGdncDhyQ0tldFgwdXN0dGppQVpvSCtoSkx3bkd2?= =?utf-8?B?VmpFOFZiTGErTU5PSmExb0REdEthMFl6bG9sODhpUUtsOEh2dEdScWgrTGFI?= =?utf-8?B?a1pvU2JXbEQzUThTakpxRmxwQWFra3pidzAvRDZEOXVzOUVDS0lDaXM0ZmVT?= =?utf-8?B?RjNlYTlla09vaVBxbE1VNmdpNGZ4UTkxUG9kUHQvZDBmODRuYno5UGgyOE5o?= =?utf-8?B?eVYxY3JCNmtML0IrZUJXcDR4OFVvclkvVlp1RnJvK3R4U05XbmlJMkZMUm9K?= =?utf-8?B?eUJ6YVFJdk5HNGk5SlpuQlY1ZUNYMDVpSmhXc2NlL01yTUpBSE5HWjQ0OXYv?= =?utf-8?B?MldlWHhuUFpONTNrZ3M2MXp0eDZRckZ5Q0QrNUdhWUMyUG5IZnpBVU9NRmdM?= =?utf-8?B?NHYzRXdkamZEOVJuamRQdFVyMFF2OXdJYzlvYzlxcTdiZW0rTTYrRDd3YXJH?= =?utf-8?B?SnRnVTZ1NFYyVStWZlRWMzR2UUJBRUlLN3E4Z1VaMEQ4MU1sdmN3Ukp6ZEkr?= =?utf-8?B?eEhHdFI4YW8zWlR3blRidWpuNFpjTFZ2ckkvWkpLMFJka014Nzg3azdIS3ll?= =?utf-8?Q?7+IgHNnXqA=3D?= X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB398;6:CZ7qEA0ibpvhSF+mHTXdrR06jdrmIOvpmt133qgYnSSafEz4rxvqYHHueqYDfhhzfvRv2CzaOcGD6JypYo4L66+QgTDNYfif8eplgI6FS2zGldDUTYZm33VY46U0IAnimMpmoBEUpTvr1gpxML4+qg2aOx7CAydWsJap5WH4tMctveI2QOhWINuGq60BHsygYMJVjl7NRlEbDkwDs9MFKvakRKE8HcbTZoLG4T/OR630JIw27tKGjuS1q7ZkljdyDCv+iUth0IS8DxX52kqtovQuWeZzP50cfi0bo3oObXaUolylBca0p/EdtzjLv77PeX5p7X+sdmRjYRNa8vAMhwYgr0/Bvrjpe9A5cW/UABewgt7dvJWOv7T9bu5Cw1wrJ/QmDzUmIWtujRZzsPqorms2IRL5k0AE8Tz+rmYWPUU=;5:oJOE5mBCUrW8ccSBmg+euaktOcOtvotVzSwh/t7yl/9QdzDwols0RYNCAaDaTlB2wfJle6h53wKuD2rNAntBsdvr35FYhafb3Bk12NtCqCdYM8WNbSSel3Zpo6uPb34cgnu9veiPnS8WIo60U4VtHA==;24:G0BPrUskwI4SoVvaEkmrB+IPynlCkW0J5Tv0C7mIImDjbgJd6+i79UIyi/STD6GnyC407PFjjKiCeOL0wXUsdfZxTR+Dyi5WqXSaH2LcXHo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DBXPR07MB398;7:bZcH37A7e5rvpnU18TB4am524UhBhK1UiOI9Q6ZdbOvdXGf4IKn/jGLiZB0XDtNYbbNnNZO75HbngWxjbPW7yRYLSY0ttFMpGOZdIUinSG95DGCda7SH2rmrssxoahjomLuWt6EVJY4F4Yy9vHuTDIhgk+w14LL5gNY7o7gSRrL0pSbgwVZNjrw1tP3k2t3+RmluJ2vQosN3ra3UIL3fddUa81+4YX2o9JJpg4wdnHXYGqJ9cZtJkmS6jMx2OlfADwanpt9iOPMxnPZOVCm9N8MAdlVDKjKkzAkurpHeOn7Z4IaAmtdXGtdrDi8q5U1Ua3OVzwDlx5YQ209JuFYMYce+ZMQV0P9kAZDARSvUF9Y9ShSJHzspuBZfRyvr/3qy8fYxWVOzbisMXH927XEYoOqt4ol0oK7uhHqaAQPIBznZXHgxJWetpl4KqVcrwdZwJq3SEF8DJWyffK7NeQw0JQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2017 15:19:40.2384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR07MB398 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00163.txt.bz2 On 17-01-10 06:00 AM, Yao Qi wrote: > On 17-01-09 13:13:42, Simon Marchi wrote: >> Indeed, it's the commit "Initial creation of sourceware repository". >> I checked out that commit and looked at the code, but couldn't find >> anything that would suggest that the output of the frame command >> would not be printed when it's executing in a script or user >> command. >> >> I went earlier using the old tarballs on the website [1], and found >> that in old gdb's, there was code like this: >> >> 965 if (!from_tty) >> 966 return; >> 967 >> 968 print_stack_frame (selected_frame, selected_frame_level, 1); >> >> The (!from_tty) check disappeared in gdb 4.3. I think it's this change: >> >> 873 Thu Oct 24 09:33:44 1991 John Gilmore (gnu at cygnus.com) >> 874 >> 875 * stack.c (frame_command): Always print. Use new >> 876 frame_select_command to select a frame without printing. >> >> after that, the frame_command function becomes simply: >> >> 974 static void >> 975 frame_command (level_exp, from_tty) >> 976 char *level_exp; >> 977 int from_tty; >> 978 { >> 979 select_frame_command (level_exp, from_tty); >> 980 print_stack_frame (selected_frame, selected_frame_level, 1); >> 981 } >> >> So I think it's safe. > > Thanks for digging it up. Patch is OK. > >> >> Side-question, is there a git repo somewhere with all these old gdb >> versions, those that predate what's in the current git tree? It >> would be useful to have a repo with one commit per version. Here I >> had to download many tarballs and bisect manually, but if they had >> been in a repo it would have been trivial. If it doesn't exist yet, >> I think I'll do it. >> >> [1] ftp://sourceware.org/pub/gdb/old-releases/ > > They were imported into the git repository. The change you found > above is in b00771232fab861fb31e42dfd5f6643ba1b43cc9 > Ah ok, it seems like there is a disconnect at "Initial creation of sourceware repository", my blame tool doesn't allow me to go past that. But indeed, if I manually checkout a previous commit I see the older versions. I added a reference to that commit in my commit log and pushed the patch, thanks.