From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13319 invoked by alias); 30 May 2019 20:01:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13287 invoked by uid 89); 30 May 2019 20:01:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.128.66, H*RU:209.85.128.66 X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 May 2019 20:01:20 +0000 Received: by mail-wm1-f66.google.com with SMTP id e19so6548761wme.1 for ; Thu, 30 May 2019 13:01:19 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id d3sm3026839wrs.8.2019.05.30.13.01.15 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 30 May 2019 13:01:16 -0700 (PDT) Subject: Re: [PATCH 15/24] Introduce rename_cmd To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20190522205327.2568-1-palves@redhat.com> <20190522205327.2568-16-palves@redhat.com> <1558814323.1454.22.camel@skynet.be> <3db59d5f-481b-64d0-5684-060b9585c3ac@redhat.com> <1559211760.1454.35.camel@skynet.be> From: Pedro Alves Message-ID: <8ebca3ef-ecac-4ded-5ef8-1e42e4881779@redhat.com> Date: Thu, 30 May 2019 20:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1559211760.1454.35.camel@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00727.txt.bz2 On 5/30/19 11:22 AM, Philippe Waroquiers wrote: > On Wed, 2019-05-29 at 19:30 +0100, Pedro Alves wrote: >> On 5/29/19 5:03 PM, Pedro Alves wrote: >> >>> There are other ways to implement this. I could move the >>> "raw-frame-arguments" option_def out of the frame_print_option_defs >>> array, so that it doesn't get installed as a command, and leave the >>> "set print raw frame-arguments" add_setshow... call in place. >>> I guess it wouldn't be a big deal. >> >> So turns out the change would be pretty simple. >> >> I'm undecided which version to use... I suppose this version >> is simpler and a little bit more efficient. Preferences? > > As 'frame-arguments' is the only command that uses the prefix 'set print raw' > and that this prefix should not be used for further options, I would mark > 'set print raw' obsolete, to avoid an inconsistency (at user level) > only for this option. > But not a big deal ... Alright, you've convinced me. And it turned out to be quite simple. I don't remember exactly what problems I had run into the first time... I've now posted a v2 of the series, https://sourceware.org/ml/gdb-patches/2019-05/msg00712.html Of course I forgot to mention that I pushed it to users/palves/cli-options-v2... I've kept the v1 branch around for now, if someone wants to compare, renamed to users/palves/cli-options-v1. Thanks, Pedro Alves