Re: [PATCH v3 09/16] [gdb/aarch64] sme: Signal frame support

Luis Machado via Gdb-patches
2023-07-31T12:23:37Z

On 7/27/23 23:25, Thiago Jung Bauermann wrote:
>
> Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> @@ -385,6 +414,38 @@ aarch64_linux_sigframe_init (const struct tramp_frame *self,
>> break;
>> }
>>
>> + case AARCH64_ZA_MAGIC:
>> + {
>> + if (!tdep->has_sme ())
>> + {
>> + section += size;
>> + break;
>> + }
>> +
>> + /* Check if the section is followed by a full ZA dump, and set
>> + za_state if it is. */
>> + gdb_byte buf[2];
>> +
>> + if (target_read_memory (section + AARCH64_SVE_CONTEXT_VL_OFFSET,
>
> Shouldn't this line use AARCH64_SME_CONTEXT_SVL_OFFSET? It has the same
> value as AARCH64_SVE_CONTEXT_VL_OFFSET so in practice there's no
> difference, but conceptually it's less confusing.
>

Agreed. Changed now.