From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6AZCKQMqeWKWRAUAWB0awg (envelope-from ) for ; Mon, 09 May 2022 10:49:39 -0400 Received: by simark.ca (Postfix, from userid 112) id A36DD1E220; Mon, 9 May 2022 10:49:39 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=t0wpcmYo; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2BAD51E00D for ; Mon, 9 May 2022 10:49:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D1A3D394FC10 for ; Mon, 9 May 2022 14:49:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D1A3D394FC10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652107778; bh=CQ2M0FgJZk4aebY8kjNrud2SUW7d1eC7kRbN3liXwgQ=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=t0wpcmYoE6ggqzz/aQSf1iEu4eg15W7wSAsMJwLg1JrVTdyEFvSJfwMNnu4DVgEW8 S3JHT+fi568l7RrV9LLq3pr6Dem+MMUfBfp846TXIr2Wf2JFHDLbXpbqytcnC/FfW+ OL6KpHyD8+5atwyDnePlgsRvspuqQUwUzwf6waow= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id B342A394D80B for ; Mon, 9 May 2022 14:46:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B342A394D80B Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B33061F912; Mon, 9 May 2022 14:46:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 84B07132C0; Mon, 9 May 2022 14:46:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 90gJHmEpeWKcCgAAMHmgww (envelope-from ); Mon, 09 May 2022 14:46:57 +0000 Message-ID: <8e46617e-387a-1d9f-3f27-fa23571aa16a@suse.de> Date: Mon, 9 May 2022 16:46:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH][gdb] Add gdb/syscalls/Makefile Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220503145732.GA26729@delia.home> <6420bb1d-2660-ff8d-c1bd-b0392cb65295@simark.ca> <7f7ae721-fd30-ee17-1f9e-df5211474194@suse.de> <129577b3-8c3a-a0c3-e4e3-046873f048bb@simark.ca> In-Reply-To: <129577b3-8c3a-a0c3-e4e3-046873f048bb@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/9/22 16:41, Simon Marchi wrote: > On 2022-05-09 06:26, Tom de Vries via Gdb-patches wrote: >> [ Re: [PATCH][gdb/tdep] Support catch syscall pipe2 for i386 ] >> >> On 5/5/22 15:20, Simon Marchi wrote: >>>> [gdb/tdep] Support catch syscall pipe2 for i386 >>>> >>>> With test-case gdb.base/catch-syscall.exp and target board unix/-m32, we run >>>> into: >>>> ... >>>> (gdb) catch syscall pipe2^M >>>> Unknown syscall name 'pipe2'.^M >>>> (gdb) FAIL: gdb.base/catch-syscall.exp: determine pipe syscall: catch syscall pipe2 >>>> ... >>>> >>>> Fix this by: >>>> - adding a pipe2 entry in gdb/syscalls/i386-linux.xml.in, and >>>> - regenerating gdb/syscalls/i386-linux.xml using >>>>    "xsltproc --output i386-linux.xml apply-defaults.xsl i386-linux.xml.in". >>> >>> The patch LGTM, assuming this is the right number for pipe2 :). >>> >> >> Thanks for the review, committed. >> >> And, I'd say, yes, the correct number: >> ... >> $ grep pipe2 ./arch/x86/entry/syscalls/syscall_32.tbl >> 331     i386    pipe2                   sys_pipe2 >> ... >> >>> I suppose we are missing more syscalls than that, given that new >>> syscalls are added regularly, e.g. rseq: >>> >>>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d7822b1e24f2 >>> >>> As long as rseq is not listed in this file, it means a user wouldn't be >>> able to use "catch syscall rseq", I suppose?  We would need a procedure >>> to add new syscalls periodically. >>> >>> Could we add a simple Makefile (as a separate patch) that contains these >>> xslt commands?  I think you searched a little bit how those files were >>> originally generated, so it would be nice to save the trouble in the >>> future. >> >> Good idea, how about this? >> >> Thanks, >> - Tom > > LGTM. I would probably use a hand-written list of files in the Makefile > rather than the "shell ls", but it the end it doesn't matter much. Ack, committed ... and CC-ing bfin authorized committer about the new gdb/syscalls/bfin-linux.xml file. Thanks, - Tom