From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52661 invoked by alias); 14 Aug 2017 13:35:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52631 invoked by uid 89); 14 Aug 2017 13:35:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:8c4a X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 13:35:51 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73BDE2E95A2; Mon, 14 Aug 2017 13:35:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 73BDE2E95A2 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C5F380F92; Mon, 14 Aug 2017 13:35:48 +0000 (UTC) Subject: Re: [RFA v2 13/13] Remove verbose code from backtrace command To: Tom Tromey , gdb-patches@sourceware.org References: <20170814034030.20863-1-tom@tromey.com> <20170814034030.20863-14-tom@tromey.com> From: Pedro Alves Message-ID: <8dd86c4c-17c9-729f-8c4a-f03e0c8c620d@redhat.com> Date: Mon, 14 Aug 2017 13:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170814034030.20863-14-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00289.txt.bz2 On 08/14/2017 04:40 AM, Tom Tromey wrote: > In https://sourceware.org/ml/gdb-patches/2017-06/msg00741.html, > Pedro asks: > >> Doesn't the "info verbose on" bit affect frame filters too? > > The answer is that yes, it could. However, it's not completely > effective, because the C code can't guess how many frames might need > to be unwound to satisfy the request -- a frame filter will request as > many frames as it needs. > > Also, I tried removing this code from backtrace, and I think the > result is better without it. In particular, now the expansion line > occurs just before the frame that caused the expansion, like: > > (gdb) bt no-filters > #0 0x00007ffff576cecd in poll () from /lib64/libc.so.6 > Reading in symbols for ../../binutils-gdb/gdb/event-loop.c...done. > #1 0x00000000007ecc33 in gdb_wait_for_event (block=1) > at ../../binutils-gdb/gdb/event-loop.c:772 > #2 0x00000000007ec006 in gdb_do_one_event () > at ../../binutils-gdb/gdb/event-loop.c:347 > #3 0x00000000007ec03e in start_event_loop () > at ../../binutils-gdb/gdb/event-loop.c:371 > Reading in symbols for ../../binutils-gdb/gdb/main.c...done. > #4 0x000000000086693d in captured_command_loop ( > Reading in symbols for ../../binutils-gdb/gdb/exceptions.c...done. > data=0x0) at ../../binutils-gdb/gdb/main.c:325 > > So, I am proposing this patch to simply remove this code. > > ChangeLog > 2017-08-13 Tom Tromey > > * stack.c (backtrace_command_1): Remove verbose code. This is fine with me. Thanks, Pedro Alves