From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gPBTCZ6iImCkYAAAWB0awg (envelope-from ) for ; Tue, 09 Feb 2021 09:56:30 -0500 Received: by simark.ca (Postfix, from userid 112) id 206B21EF4F; Tue, 9 Feb 2021 09:56:30 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A5D861E590 for ; Tue, 9 Feb 2021 09:56:29 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F85E398B860; Tue, 9 Feb 2021 14:56:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5F85E398B860 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612882589; bh=+eaGE1k0jHWQGZqxaqIz9bkaPDT8czQF2jnbD2WwVS4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wdzMMpapkmPEUOwwuXJWJqgGI7tWWI7AAfe8DX15l3rN86KMyM4lRAREZLVfNklLH 8P1uQTvLSNRxJM+Z4upFd0LwG2PTW1wB/ki9MDNuVgNuNbrDpqexpoy9gyZBB8QIvw Yyna2q8tqVKp6lN5YgYkudSfyWLNqQs9plvZ5f0I= Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2060.outbound.protection.outlook.com [40.107.244.60]) by sourceware.org (Postfix) with ESMTPS id F3E683835421 for ; Tue, 9 Feb 2021 14:56:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F3E683835421 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SgmdtjqsiRPULGWDD2asli0DF3PK9oxmIQ7Joovnk+2CGa1ckWv4LmVVDeMcq/eZUE0fsSWVnxyusLAWJK/nNt1UMr6w+V5F5tV147KQHHMEBVQ+QaXOs+lwPIblAYVuTdNv3zsZ237tb5f3FGb7927Gec2HB5sqEVAPtv+iachoCL92H7w04bIIOJp2X6nueGbCqUWtSn6P6rRgoPPg0Stqm3Ql3OUMZ5+AsiRjuslB8Dx6vGutnqQlgboLe4rb9VSc8Jdq/X6VbnUoQUw3LvTerTqe8YQOfob7v9o5qws5FCySXcc0sRTQjUYsr0/X7TxAFj8YqLIkAzMaWfcv+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+eaGE1k0jHWQGZqxaqIz9bkaPDT8czQF2jnbD2WwVS4=; b=cZlQMr7RG9n+Xr4Wm5pxSgoAGGgzE/Q/QExLSeyfp2QG1O8BGSRmMpM0v+y+ozhM/7oiZ8mYfsW2o232ZMqrJfw5IkV5OrZd4bZ3bJOwDpMQXHr+cRwiqHdNb1hu5bTEDuO3hJvcQqMbSRLLx4j6dM3rTRZMCoApGW/qYfPLRlCrJ6SmeVCz8Iu8iQh5rxdgreUwJEWw2r2CQKJJTMSYcr/xxfS3Kftf22V+FRExF1lI+pG28nA+Daw10hNs9YVUEGl1suY/ZMNdt9w2+pEAFAq0SK1gr9KuOkgyfxvYv7M63YCwQ3j5SD3KEr3H0G618aeICCf8RQQculkyfyDRww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB4532.namprd12.prod.outlook.com (2603:10b6:5:2af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20; Tue, 9 Feb 2021 14:56:25 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::31d8:f503:f7b2:f44%3]) with mapi id 15.20.3825.030; Tue, 9 Feb 2021 14:56:25 +0000 Subject: Re: [PATCH 14/30] Simplify dwarf_expr_context class interface To: Tom Tromey , Zoran Zaric via Gdb-patches References: <20201207190031.13341-1-Zoran.Zaric@amd.com> <20201207190031.13341-15-Zoran.Zaric@amd.com> <87r1lqdyuu.fsf@tromey.com> Message-ID: <8dca72bd-a8db-12a9-3914-e19868e6c203@amd.com> Date: Tue, 9 Feb 2021 14:56:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 In-Reply-To: <87r1lqdyuu.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:b142:b2da:a877:6c3] X-ClientProxiedBy: AM0PR10CA0108.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::25) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:b142:b2da:a877:6c3] (2a00:23c7:5a85:6801:b142:b2da:a877:6c3) by AM0PR10CA0108.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.19 via Frontend Transport; Tue, 9 Feb 2021 14:56:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4d6cb641-9aa1-4497-9aee-08d8cd0adf7a X-MS-TrafficTypeDiagnostic: DM6PR12MB4532: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9t7ymN3mWzCSA8M44zFXOqeKY1rFONgoEZkA2ef2s4ITdVOm5qKqVH66ei4XuQ+/SA5ovhHlJkOLqxYfYA2iNn7dvcCnsoXj6W/krocSfYjyyLtt0kH0teo6zK1viEdk3Skate4uXS2/iP/Ha7c7rs7AOr9afbphYtPw+n8z+siTzlnKI5/WWtQAGmz8DHtrZVVnmEkrB/dg0CfWvPLrGzapzynoAAW1soAGRimtmYeaZl0pQAxCZ1nk0QOoidcdtIbxWEybBpNapoBrD5Do+aKk7zqLv6GlLqcETqyz0s8KCnNTcrxFpwyiLA227HFwdZ2qFx/qhfIYy1EeyLnYlNbM5yr74gPa0QJ9u2aTiSiT6Z3DaAn47D5Pn0/UN0jjG7oPhQTg6y6wGDGxzfHMO6UUi1fPiqMdcmaA+mfU5qL/oHIDe7LMPeZiaL8AfCmcj4+ayhlvAYDXMthsLzIeDHgjH97I+nDrucdn8qjmHboMymfqPZH0m96NTB2ldotyUqKnkyskOGGC4GB9+r09NhS8gagDIjxk1usHbatpd2meNa61SZuyqAXyl47ze4KroOkCAK5/iM4ZG8uRjGn09RBEU5jbQUPdp9PTNW3u5aU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(8676002)(478600001)(186003)(16526019)(4744005)(66946007)(53546011)(66476007)(86362001)(6486002)(8936002)(66556008)(5660300002)(31696002)(36756003)(316002)(110136005)(2616005)(6666004)(31686004)(2906002)(52116002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TncrSG1kSFYvaXVLU1pla0pEZHdKN3k0cHo2cFQzWWNMNWlFVjA1U2ZndENy?= =?utf-8?B?MW1udllNbHEwMUxOL0tlVmdOSW4wWStNZ2tINnVNSnRMZWhHZXJRc3lNNlRF?= =?utf-8?B?SGxxcFd2bVJ0ZjhPSFU3U0hPUlhUcnd6R1NKZFlYck43Ulp4VHRWNU9YRE9a?= =?utf-8?B?T3VScUJtK1ByUmhMYmNNdW45Si9BcTlhalQ4UmhBdUpPSFVTNWZyYVFaRHAv?= =?utf-8?B?SExGOHpVN2dLK1hlM2tPMjN3dUVhelB2andTaUVkZWJvaDIwdnVEdksrNjkw?= =?utf-8?B?cmpXazZ4NGhiSFVSbExqVTRISDkvWFIwd3d5YUJRaWtoWTNmeTlMeFpBWHZs?= =?utf-8?B?WFhpK3ZHQXI3SVdqVlhvSVhVN0NUK244VkVxSGpnUGY2YlFsbHhzdXFCWGNv?= =?utf-8?B?VXpqRTZKaXV2NUlaOGNpZFY3bE10WllUS0JyUDlJbmRpR2VjaG5oTlJ5Q0or?= =?utf-8?B?V2VMK1NNL050ZEFVSktaazR0Y2dvUUlWOHZBQS9LVisrbml4QkYwaGZLK0xI?= =?utf-8?B?cUdZcmQ5b3F3dXl3VVFCclEyajhZYlFzcTBBbmd4ZkU3elp4cTlRUlBmT3Q4?= =?utf-8?B?ZExrNFAzYk44TTZweTdjZ0trVDhxeWY2MlIwTWFoTTVsY1YvTlIrSUErVXE2?= =?utf-8?B?WExBMGdGbTBZRTFHbmZaSG1rdVFNUTR0ci9tUU1BZk9UaWZLQlBhWFFUaVA5?= =?utf-8?B?cjR1VC90RHNyV3J4OXhkM2JncVM4TmJOU25XMmlnUFg1SERkb25Vb3NyVW41?= =?utf-8?B?a0ZaLzlSZ1FqeklLZzEyTVFTa2RleGJnbVE4RExOc0c4YS9qVmtoSGUyTDlL?= =?utf-8?B?a1JERXNoMFlzRjhySCtuZXluU0NLbjE2RVg5NlZ1dFN0VDBleGNtNDdoejdz?= =?utf-8?B?SjNOZUxuNHh0RGx3eFZib1Via2RlVW42Rld3VXJab2FLMmJmN3Q4cE1wZHpR?= =?utf-8?B?NHk4TXgwZXVVbE5HK1RCWXE5bHV0Q1I5MGZnKzBKVEhnMFphc0tZVmtPS3JK?= =?utf-8?B?dDB4eFJlYURuT3VrRkJYamZlaVE2ZE9GSUh5eDlxRnRHTVpEUWRlcWp3SFh1?= =?utf-8?B?cXAwZjdUL1hCeHRpdTNOU2dKU2g2RVBNQWJnMDBLOU82YnRFaFZUZlJGMlVh?= =?utf-8?B?WDhSQ3FHUUZFRnNNRTZXaHFFRC9yNHBHSmVJWnV3MTJuRE1PTHpHTVRYWXI3?= =?utf-8?B?Y296UzBMUTV2Ri83ZVNzeXJOS1REZGZDbk91bFJ6N2JqNExnWHBOZGFzZVht?= =?utf-8?B?M2lXYldFdGZaZ21ueUFqZllNOTVsTW1QQzVLeStxWWdLdUtTWDJrZnNKcFFF?= =?utf-8?B?QVZ3UGlhRUc3VHJiQjJuaEhLbkFVTjFhWTBGVzREWGVGRWtXWEtUSm1TQmRY?= =?utf-8?B?QlFZV2J3SzkwSGJvYm82WVQ4bk0zbnpzOHVNbGdmQURtd0xvcENUMnJHV0VW?= =?utf-8?B?a3NGeUM5REhmR1E1dnB2QmxjOGg4UlhSRTFiak1Uc044Y29BekIvVVFmZVU0?= =?utf-8?B?eFNEK2QydGVvS2FXckg0RjVNSm5WYlJqNkN0OVVXSENhUGs3c0pZeVVrTjlu?= =?utf-8?B?aVFLR0tpbjBERVJOdkNBRDRrejN4dTRmTVNISTBjWnZ3WnNDRG5IMHMyNk84?= =?utf-8?B?SCswK2V2a1p0OC8rc2QyaDlRVkxLU1pFMW5zaDNTb3dGbFNjTVRCekR3Mkd3?= =?utf-8?B?OUFtYmZLckRsTlFSdVB4N0M3ZXpnNE51eTJ2aFhGVVFmYk5uSkthSlp5TzYy?= =?utf-8?B?a0tFZm1yMnI2OHhPaURKdU9rTGY0Q1NKdEc2WjVGaDdDWW91VE1WbFE0aU5h?= =?utf-8?B?L2xDUjluYi9MbklnTVFhaytZU0lxdElmWE1OcGYxcWxBYmlIWnRrcmE1WEZB?= =?utf-8?Q?z/OzDXaEfF2Ii?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d6cb641-9aa1-4497-9aee-08d8cd0adf7a X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 14:56:25.6845 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cd29PXcaP3cP7A8v0pGG8xReswW7xC7Scr0dEvBG+EHaqOh3U91FK8NDPIemvqEc32VtbNh+0L1qbNcQmdmtPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4532 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2/8/21 9:38 PM, Tom Tromey wrote: > [CAUTION: External Email] > >>>>>> "Zoran" == Zoran Zaric via Gdb-patches writes: > > Zoran> The eval_exp method is the method that evaluates a DWARF expression > Zoran> and provides the evaluation result, in a form of a single struct > Zoran> value object that describes a location. > > How about just calling this method "evaluate"? > Same length, but no abbreviations. > > Otherwise this looks good to me. > > Tom > Makes sense. I will change it in the next version. Zoran