From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id JvjnB4ZznWmcXwgAWB0awg (envelope-from ) for ; Tue, 24 Feb 2026 04:46:46 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=lP5oN8bV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Rit9Dn/0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=lP5oN8bV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Rit9Dn/0; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DFAC71E0BA; Tue, 24 Feb 2026 04:46:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BFA441E089 for ; Tue, 24 Feb 2026 04:46:44 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 17B8D4B9DB64 for ; Tue, 24 Feb 2026 09:46:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 17B8D4B9DB64 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=lP5oN8bV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Rit9Dn/0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=lP5oN8bV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Rit9Dn/0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id BB0374B9DB64 for ; Tue, 24 Feb 2026 09:46:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB0374B9DB64 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB0374B9DB64 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771926375; cv=none; b=bvC9+CO+ntrkqW5cnzcpwpN+7NzBzyj5RSG0cyoy54ZeqFEYpPC7hAAETy4kAZkQJLZRLIzLxZyu9DG6RnwXbS3jNWZXoDe4SRzG3wMOrGYLP7wKG3RfjJY7iwI4Jm6uufU3aBfgrD+zYo8jcN70/eWr0oU7Zeile5P/1AVtIFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771926375; c=relaxed/simple; bh=NeMWh+qN1Ojcxc6tZsRYVk0cjvu+PA1oDYHh8RMW7sc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Yz5OE/C6bpGyyV2CvEQlHd24W3N/CimssfQTuHDMoVBtZWOQ5x5lEgHbhejnEOWka7ri9cy+4Mp+r5rxNrjKiXYceVJC4ezCdOH7/TGLDF9Lz3cpW914Khs0kpjVq2sS9M9k7YdM590nPOMVirHLICuOLJAVxXcxe8IS0Fq/yaY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB0374B9DB64 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8EF153F153; Tue, 24 Feb 2026 09:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771926374; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWUHoqjM/8KMp1BKH8KnKl2qJTcnECFzomOKZfziEXg=; b=lP5oN8bVTV2EvOEwVMwi+EaRgDelsu3l2dEc78fwLFT6fN3mNInELOKFhXx7rzaypFEb73 EmFefh8ZAVAw3nn4XNoLJpwwpNAbALB2LQAT4SmucG6qr/Q3hW5EtfUhUZsS2E6qrYyhKP ztQf3Pxih8veRyF2ZMv1zKvsYIVhK1s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771926374; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWUHoqjM/8KMp1BKH8KnKl2qJTcnECFzomOKZfziEXg=; b=Rit9Dn/0r8C9LyBmGq9jPkwJGCjR0DCcnqLvQ/1vCfiZvo1do0kEmvbVyDotEAOg4FsVjJ FBHUNGB3XFjceBCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1771926374; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWUHoqjM/8KMp1BKH8KnKl2qJTcnECFzomOKZfziEXg=; b=lP5oN8bVTV2EvOEwVMwi+EaRgDelsu3l2dEc78fwLFT6fN3mNInELOKFhXx7rzaypFEb73 EmFefh8ZAVAw3nn4XNoLJpwwpNAbALB2LQAT4SmucG6qr/Q3hW5EtfUhUZsS2E6qrYyhKP ztQf3Pxih8veRyF2ZMv1zKvsYIVhK1s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1771926374; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LWUHoqjM/8KMp1BKH8KnKl2qJTcnECFzomOKZfziEXg=; b=Rit9Dn/0r8C9LyBmGq9jPkwJGCjR0DCcnqLvQ/1vCfiZvo1do0kEmvbVyDotEAOg4FsVjJ FBHUNGB3XFjceBCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5AB1B3EA68; Tue, 24 Feb 2026 09:46:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sKS2FGZznWmgEQAAD6G6ig (envelope-from ); Tue, 24 Feb 2026 09:46:14 +0000 Message-ID: <8dad6812-28c8-4c9f-aa0f-7271cd67f6e4@suse.de> Date: Tue, 24 Feb 2026 10:46:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/8] Correctly handle inline functions with dwz To: Tom Tromey , gdb-patches@sourceware.org Cc: Eli Zaretskii References: <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-0-bf923dc5fb19@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260223-dw-inline-fixup-pr-symtab-30728-2-v4-0-bf923dc5fb19@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/24/26 2:16 AM, Tom Tromey wrote: > The new indexer does not correctly handle inline functions when 'dwz' > is used to compress the DWARF. This series fixes the bug, cleaning up > a number of other things on the way. > > I've separately regression tested each patch in this series on x86-64 > Fedora 41. I've also regression tested the series as a whole with the > dwz, gdb-index, and debug-names boards. > > Even with that I messed up somehow, so v1 didn't actually fix the bug > in question. I must have modified the patches after testing..? > > Anyway in v2 I've moved the line recording the CU inclusion and added > a comment explaining the placement. I re-ran the aformentioned tests > and didn't touch anything. > Hi Tom, I've looked through the series, reviewed the smaller patches and browsed the larger one (#7). LGTM. Acked-By: Tom de Vries Thanks, - Tom > Signed-off-by: Tom Tromey > --- > Changes in v4: > - Update assert in .debug_names writer, and add regression test > - Link to v3: https://inbox.sourceware.org/gdb-patches/20260220-dw-inline-fixup-pr-symtab-30728-2-v3-0-98ae8ab28fab@tromey.com > > Changes in v3: > - Minor updates per review > - Rebased; which required some changes to the > iterate_over_one_compunit_symtab patch > - Link to v2: https://inbox.sourceware.org/gdb-patches/20260126-dw-inline-fixup-pr-symtab-30728-2-v2-0-8ab183d1911c@tromey.com > > Changes in v2: > - Fixed fix from Tom de Vries for IS_INLINED debug display > - Moved line to record inclusion > - Link to v1: https://inbox.sourceware.org/gdb-patches/20260125-dw-inline-fixup-pr-symtab-30728-2-v1-0-e9973a4a401a@tromey.com > > --- > Tom Tromey (8): > Don't call add_dependence from index_imported_unit > Skip partial units in process_psymtab_comp_unit > Don't consider DW_TAG_inlined_subroutine as interesting > Combine two cases in cooked_index_functions::search > Remove C++ special case from process_imported_unit_die > Have iterate_over_one_compunit_symtab search included symtabs > Handle inline functions with dwz > Update .debug_names documentation > > gdb/doc/gdb.texinfo | 37 +++++ > gdb/dwarf2/abbrev.c | 1 - > gdb/dwarf2/cooked-index-entry.c | 24 ++++ > gdb/dwarf2/cooked-index-entry.h | 39 +++++- > gdb/dwarf2/cooked-index-worker.c | 14 ++ > gdb/dwarf2/cooked-index-worker.h | 26 ++-- > gdb/dwarf2/cooked-indexer.c | 60 ++++++--- > gdb/dwarf2/cooked-indexer.h | 8 +- > gdb/dwarf2/cu.h | 6 +- > gdb/dwarf2/index-write.c | 224 ++++++++++++++++++------------- > gdb/dwarf2/read.c | 85 +++++++----- > gdb/dwarf2/read.h | 37 +++++ > gdb/symfile-debug.c | 23 ++-- > gdb/testsuite/gdb.cp/breakpoint-locs.exp | 8 ++ > 14 files changed, 415 insertions(+), 177 deletions(-) > --- > base-commit: 2a2b24ecc13988a6d87619f53b36faa2bcb61beb > change-id: 20260125-dw-inline-fixup-pr-symtab-30728-2-7c31bf38fbe3 > > Best regards,