From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pObKCEPY0mcqOA4AWB0awg (envelope-from ) for ; Thu, 13 Mar 2025 09:06:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1zdpHm9u; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=I6Ax7r3i; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=j1twso/C; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=U+h9r6lf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 108FF1E105; Thu, 13 Mar 2025 09:06:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 316241E08E for ; Thu, 13 Mar 2025 09:06:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 729AC385842C for ; Thu, 13 Mar 2025 13:06:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 729AC385842C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1zdpHm9u; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=I6Ax7r3i; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=j1twso/C; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=U+h9r6lf Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id E4A793858D33 for ; Thu, 13 Mar 2025 13:05:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4A793858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4A793858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741871136; cv=none; b=qHi5S6osPltdLcUoclYX/L3UeelmdJp4Q/kIhcmTP2Iw6SiKdv3mHXwDPtXcGJTGA1CH6I+Q5TYPMS/rb6rT3FpukY/K/LC0rvYUPy6gCZQ6Mz/gw8BynDzcCgDNzQ9Nwl20Y8zTBDiTOGL9qwo61/i1/HcyB1aGlA4UohRIf2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741871136; c=relaxed/simple; bh=pEbth9eqXOzb6Ln2H/xwt3b6MnshcuV8aSKPW4xwQkM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=sQO7uP53FQtgiLyW17oig04dGMtMeaLQooLD2GhCPAH/AWWYlrhOcV63CQDZXajrPV/0m+dTIjvErlRLztIBedM1CraET5ofIOHVw9KJUesPvaPGb4Ac+2uBwVeYC17ueK3dVFfYyw5r6Kk4UsweRKdiENJmB7kubUNHnDgjjB8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4A793858D33 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D278D21192; Thu, 13 Mar 2025 13:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1741871135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XVddOGFxtgLUviN57NtgDiN35T0VpnjcdEYo09AreW8=; b=1zdpHm9uM5vTUK2bpkeCfvowLfWiod/6JYlbin9SccPjqPHn6poQ2nSMcpOFAQhQx8huCB GBwLKmwXNlzamzQtV+qaONbHkDzBfijE0NT4lyD1Gn5sRXmLpKZbebAItbNj38Y4ntbskI 8IvArOZE4GNjqs2oQRy41z43K8JIuAQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1741871135; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XVddOGFxtgLUviN57NtgDiN35T0VpnjcdEYo09AreW8=; b=I6Ax7r3iXLcsch456nXms32NyULmRgAR4EblQMyicy6VR8k5ZksN3zbj9sEHElOT7YvzL1 vGePY1x57B/ygWCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="j1twso/C"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=U+h9r6lf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1741871133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XVddOGFxtgLUviN57NtgDiN35T0VpnjcdEYo09AreW8=; b=j1twso/CP6qM+GCxSTlVtqHpzcmvBdvVq4fE2t1Ghh29JGlYpnfyoPA07+qzCuynZfJRXK syi6KVy2OEItrf5TGggTEz30/3TOQCOkXsdD+R1Hmjd/WJbchI+D6nn/5qFS29Cxc1qs/u GWo+v1AJarwjcNP0tng9GNWp/XJWF9U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1741871133; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XVddOGFxtgLUviN57NtgDiN35T0VpnjcdEYo09AreW8=; b=U+h9r6lf4L56MjLcRfgdnGrIwprh/85gjikMmHA/Rb2SSQEOh5UQtTkWcqHvgTe+QxEbbq vQ+Oacls3V6H/bBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BB3D813797; Thu, 13 Mar 2025 13:05:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CNxvLB3Y0meAcwAAD6G6ig (envelope-from ); Thu, 13 Mar 2025 13:05:33 +0000 Message-ID: <8d94c39e-86f3-4f4c-8443-4f9ce786743f@suse.de> Date: Thu, 13 Mar 2025 14:06:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Backport i386_canonicalize_syscall rewrite to gdb-16-branch To: Guinevere Larsen , gdb-patches@sourceware.org References: <20250313095325.23876-1-tdevries@suse.de> <6cab43c6-85c9-4834-9f44-9cc1267621b7@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <6cab43c6-85c9-4834-9f44-9cc1267621b7@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D278D21192 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/13/25 13:40, Guinevere Larsen wrote: > On 3/13/25 6:53 AM, Tom de Vries wrote: >> Commit fbfb29b304e ("[gdb/tdep] Rewrite i386_canonicalize_syscall") fixes >> PR32770, which reproduces on the gdb-16-branch, but the commit is not >> ideal >> for backporting because it completely rewrites i386_canonicalize_syscall. >> >> Instead, this is a version of the patch that adds a single line entry >> for each >> syscall value for which i386_canonicalize_syscall gives a different >> result >> with and without the patch. >> >> Consequently, the two versions give identical results.  I've checked >> this for >> syscalls 0 to 466. >> >> Tested on x86_64-linux with target board unix/-m32, on top of gdb-16- >> branch. >> >> PR tdep/32770 >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32770 >> --- > > Hi! > > I looked over all the special cases, and it mostly looks ok. There are > quite a few syscalls where we have an older or similar enough version, > like execveat and execve, or faccessat and faccessat2, but I can see > from the accept4 patch why you wouldn't have done that... however, for > the semtimedop_time64 syscall, you just converted to the semtimedop > version. What is special about that one? > Good question. This was one of the syscalls I came across while reviewing the gdb_syscall enum values >= 500. And since the recording support doesn't actually record the timeout parameter, the time64 part of semtimedop_time64 seemed irrelevant. So, what was special here was that gdb_sys_semtimedop was supported, but there was no corresponding mapping from i386. For the execveat case, gdb_sys_execveat is missing. That makes it similar to the accept4 case. I hope that answers your question. Thanks, - Tom