Re: [PATCH] Update help of the "frame" command

[Luis Machado <lgustavo@codesourcery.com>]

On 01/06/2017 09:16 AM, Simon Marchi wrote:
> The help message of the "frame" command states that nothing is printed
> if the command is executed from the command file or user-defined
> command.  My testing leads me to think that this is not true (at least
> today).
>
>   (gdb) bt
>   #0  bar (n=17) at test.c:9
>   #1  0x00000000004006e0 in foo (v=17) at test.c:13
>   #2  0x00000000004006f0 in main () at test.c:21
>   (gdb) frame
>   #0  bar (n=17) at test.c:9
>   9	    baz(n);
>   (gdb) define foo
>   Type commands for definition of "foo".
>   End with a line saying just "end".
>   >frame 1
>   >end
>   (gdb) foo
>   #1  0x00000000004006e0 in foo (v=17) at test.c:13
>   13	    bar(v);
>
> This patch simply removes that bit from the help message.  I didn't find
> anything corresponding to this in the documentation that needs to be
> fixed.
>
> gdb/ChangeLog:
>
> 	* stack.c (_initialize_stack): Update "frame" command help message.
> ---
>  gdb/stack.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/gdb/stack.c b/gdb/stack.c
> index 64224d0aad..201a358833 100644
> --- a/gdb/stack.c
> +++ b/gdb/stack.c
> @@ -2666,9 +2666,7 @@ This is useful in command scripts."));
>  Select and print a stack frame.\nWith no argument, \
>  print the selected stack frame.  (See also \"info frame\").\n\
>  An argument specifies the frame to select.\n\
> -It can be a stack frame number or the address of the frame.\n\
> -With argument, nothing is printed if input is coming from\n\
> -a command file or a user-defined command."));
> +It can be a stack frame number or the address of the frame.\n"));
>
>    add_com_alias ("f", "frame", class_stack, 1);
>
>

Sounds reasonable to me. I ran into other help text block 
inconsistencies. It looks like there is potential for more corrections 
in that area.