From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-163454-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 56448 invoked by alias); 23 Jan 2020 22:45:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 55872 invoked by uid 89); 23 Jan 2020 22:45:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jan 2020 22:45:06 +0000
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218])	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id E1EA81E5FD;	Thu, 23 Jan 2020 17:45:04 -0500 (EST)
Subject: Re: [PATCH] gdb: fix variable shadowing error in darwin-nat.c
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org, Iain Sandoe <idsandoe@googlemail.com>
References: <20200123220256.1293-1-simon.marchi@efficios.com> <87zhedpzsz.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <8d80abd9-c043-1ba7-e2aa-eacfb55bb201@simark.ca>
Date: Thu, 23 Jan 2020 22:49:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <87zhedpzsz.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2020-01/txt/msg00768.txt.bz2

On 2020-01-23 5:34 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> Fix it by moving the declaration of `inf` in the specific scopes that
> Simon> need it.  I think it's clearer this way anyway, as it shows that it's
> Simon> not the same `inf` that is used in these different scopes.
> 
> I agree.  This looks good to me.
> 
> Tom
> 

Thanks, I pushed it.

Simon