From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116951 invoked by alias); 20 Apr 2018 15:59:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116942 invoked by uid 89); 20 Apr 2018 15:59:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,LIKELY_SPAM_BODY autolearn=ham version=3.3.2 spammy=advertising, yao X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Apr 2018 15:59:55 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 59564FE5CA; Fri, 20 Apr 2018 15:59:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEB76AFD66; Fri, 20 Apr 2018 15:59:50 +0000 (UTC) Subject: Re: ping: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones To: Eli Zaretskii References: <20170327210753.GA29656@host1.jankratochvil.net> <20171018195237.GA19714@host1.jankratochvil.net> <867evczxik.fsf@gmail.com> <20171103220437.GA13979@host1.jankratochvil.net> <20180321190316.GA32598@host1.jankratochvil.net> <1e06eb53-60f4-0800-a4f6-458e02f840bd@redhat.com> <83po2tyiu0.fsf@gnu.org> Cc: jan.kratochvil@redhat.com, qiyaoltc@gmail.com, gdb-patches@sourceware.org From: Pedro Alves Message-ID: <8d4d9262-305c-eb71-8752-80d729e0cc6a@redhat.com> Date: Fri, 20 Apr 2018 15:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <83po2tyiu0.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00408.txt.bz2 On 04/20/2018 04:54 PM, Eli Zaretskii wrote: >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 25c404bfc37..38043c4ff2e 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -35,6 +35,16 @@ SH-5/SH64 ELF sh64-*-elf*, SH-5/SH64 support in sh* >> SH-5/SH64 running GNU/Linux SH-5/SH64 support in sh*-*-linux* >> SH-5/SH64 running OpenBSD SH-5/SH64 support in sh*-*-openbsd* >> >> +* Aarch64/Linux hardware watchpoints improvements >> + >> + Hardware watchpoints on unaligned addresses are now properly >> + supported when running Linux kernel 4.10 or higher: read and access >> + watchpoints are no longer spuriously missed, and all watchpoints >> + lengths between 1 and 8 bytes are supported. On older kernels, >> + watchpoints set on unaligned addresses are no longer missed, with >> + the tradeoff that there is a possibility of false hits being >> + reported. > > I wonder whether we need this NEWS entry. We don't normally call out > bugfixes there, do we? Yao requested one in an earlier review. I'm borderline about it myself, with no strong opinion. There's a tradeoff here, which may be worth advertising, and the mention of kernel version might be useful too. Thanks, Pedro Alves