From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18348 invoked by alias); 5 Apr 2017 16:34:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18330 invoked by uid 89); 5 Apr 2017 16:34:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 16:34:09 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DFB9D7F7A7 for ; Wed, 5 Apr 2017 16:34:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DFB9D7F7A7 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DFB9D7F7A7 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 784C57A317; Wed, 5 Apr 2017 16:34:07 +0000 (UTC) Subject: Re: [commit/obvious] Fix PR 21352: Command tsave does not support -r argument To: Sergio Durigan Junior , GDB Patches References: <20170405163129.24815-1-sergiodj@redhat.com> From: Pedro Alves Message-ID: <8d200237-58fe-45c3-c0a6-2f15413a988b@redhat.com> Date: Wed, 05 Apr 2017 16:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170405163129.24815-1-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00118.txt.bz2 On 04/05/2017 05:31 PM, Sergio Durigan Junior wrote: > This is an obvious fix for PR 21352. The problem is that the argument > parsing loop is not using an "else if" where it should, and therefore > the '-r' option ends up unrecognized by GDB. We have a few tests under gdb.trace/ that exercise "tsave". Would it be easy to augment some to exercise this? Thanks, Pedro Alves