From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8XCBHyPk82EEewAAWB0awg (envelope-from ) for ; Fri, 28 Jan 2022 07:40:03 -0500 Received: by simark.ca (Postfix, from userid 112) id 699761F3B7; Fri, 28 Jan 2022 07:40:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E183C1EA69 for ; Fri, 28 Jan 2022 07:40:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4E4BF3947429 for ; Fri, 28 Jan 2022 12:40:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4E4BF3947429 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643373602; bh=4C5BwjOtx5ZP7tqFkcwqL3EQr1IzniUeE4UgBxlmuyA=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QYG+Un1qMshcy/rG3qC197CNVqWaOHneQvnWM/7w66egHjoelro0TgbHN06ZNh2Gk mQX02JB4nPFf7oRAivGVNzy88+ZhFOghO6VlO3rnM0oUjHh0ib8MH+bZwPzk1pmqAv FahfqNSMKocb+jWyyy5ROM2TlQgOFGiA0QStszYI= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1023E3858402 for ; Fri, 28 Jan 2022 12:39:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1023E3858402 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 20SCcYWV026464 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Jan 2022 07:38:39 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 20SCcYWV026464 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4FFD41EA69; Fri, 28 Jan 2022 07:38:34 -0500 (EST) Message-ID: <8cd45f68-74bf-32d9-7955-fcf8c72366b3@polymtl.ca> Date: Fri, 28 Jan 2022 07:38:33 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2] gdb: make thread_info::m_thread_fsm a std::unique_ptr Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20220128110107.38775-1-lancelot.six@amd.com> In-Reply-To: <20220128110107.38775-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 28 Jan 2022 12:38:34 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: lsix@lancelotsix.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > @@ -443,6 +444,32 @@ class thread_info : public refcounted_object, > m_suspend.stop_reason = reason; > } > > + /* Get the FSM associated with the thread. */ > + > + struct thread_fsm *get_thread_fsm () const Style comment: I don't know if this is a consistent style, but at least in my changes, I usually omit the "get_" prefix for the getters. > + { > + return m_thread_fsm.get (); > + } > + > + /* Get the owning reference to the FSM associated with the thread. > + > + After a call to this method, "get_thread_fsm == null". */ null -> nullptr. LGTM with those changed. Simon