From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35610 invoked by alias); 18 Apr 2017 20:17:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35563 invoked by uid 89); 18 Apr 2017 20:17:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:wordpress.com X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Apr 2017 20:17:33 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9414C61D26; Tue, 18 Apr 2017 20:17:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9414C61D26 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9414C61D26 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A543F83295; Tue, 18 Apr 2017 20:17:32 +0000 (UTC) Subject: Re: [PATCH 2/4] Change return type of gdbarch_software_single_step to vector To: Simon Marchi , gdb-patches@sourceware.org References: <20170416141430.2585-1-simon.marchi@polymtl.ca> <20170416141430.2585-3-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <8ccc3ab3-91e8-7121-7494-cce45d31f8b2@redhat.com> Date: Tue, 18 Apr 2017 20:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170416141430.2585-3-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-04/txt/msg00527.txt.bz2 On 04/16/2017 03:14 PM, Simon Marchi wrote: > This is a relatively straightforward patch that changes > gdbarch_software_single_step so it returns an std::vector > instead of a VEC (CORE_ADDR). LGTM. BTW, FYI, in general, {} initialization of vectors may not always be a good idea. See e.g.: https://akrzemi1.wordpress.com/2016/07/07/the-cost-of-stdinitializer_list/ C++17 will make it better (though not fully ideal). But in this case CORE_ADDR is a scalar and it doesn't really matter. Thanks, Pedro Alves