From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39326 invoked by alias); 25 Nov 2016 18:39:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39316 invoked by uid 89); 25 Nov 2016 18:39:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=naked, Great X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 18:39:56 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8092C05B1DC; Fri, 25 Nov 2016 18:39:54 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAPIdqYM007016; Fri, 25 Nov 2016 13:39:53 -0500 Subject: Re: [PATCH 1/8] Fixup testcases outputting own name as a test name To: Luis Machado , Simon Marchi References: <1480093744-13771-1-git-send-email-lgustavo@codesourcery.com> <1480093744-13771-2-git-send-email-lgustavo@codesourcery.com> <2b7ca30d-f563-dd11-7934-60505d261a24@codesourcery.com> <5cfc70b2ea19762c664d61f752c02a41@polymtl.ca> <0b33f003-4d18-05dd-c74b-96d2026fcf2f@redhat.com> <81665d33-cfb5-8af5-342e-a743d54bb80a@codesourcery.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <8ca2fb8a-940c-a834-8331-df1b23fffc62@redhat.com> Date: Fri, 25 Nov 2016 18:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <81665d33-cfb5-8af5-342e-a743d54bb80a@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00834.txt.bz2 On 11/25/2016 06:26 PM, Luis Machado wrote: > On 11/25/2016 12:02 PM, Simon Marchi wrote: >> On 2016-11-25 12:55, Pedro Alves wrote: >>> Or just not pass anything about the target file? >>> "failed to compile" works just as well, IMO. If you need more detail, >>> it's in the gdb.log. >> >> Agreed, I think that's even better. I was first thinking it would be >> useful to have the dest file, in the cases where the same source file is >> compiled multiple times to multiple destinations. But you're right that >> if you want details, you'll go look at gdb.log. It's enough for the >> test name to give a rough idea of what failed. > > Great. I'll adjust things. > > Should i get the existing tests that already output srcfile paths on > compilation failures fixed up and standardized with this patch as well > or with a separate one? IMO, whatever you prefer. There's no harm in doing it incrementally. It'd make a difference if the previous version of the patch was mostly OK except some detail that only mattered in a few hunks. Bundling everything would force reviewers to waste time rereading what was already OKed. In such a case, I'd rather the OKed parts were pushed in and the NAKed parts to be left for a separate follow up patch. But in this patch's case, you'll end up retouching most hunks anyway. Thanks, Pedro Alves