From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TmMlDZ0BhmBpUwAAWB0awg (envelope-from ) for ; Sun, 25 Apr 2021 19:56:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 197671F11C; Sun, 25 Apr 2021 19:56:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 175361E783 for ; Sun, 25 Apr 2021 19:56:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9BB063846454; Sun, 25 Apr 2021 23:56:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9BB063846454 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619394971; bh=HwK6Dnn0IV9cq7fYKdfE24nRDB0HGp2nRWNXw+yPAYs=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hb7BjQvumw+soR5mvNubnGX7zD1Xz6crRxptMIrR90fRiW7oanmZ5l3ZKBMbEZxpT FvKJmFjer98fqRtyMde7OKtO1QjyO5VlJtUA+MB0gE75/mvOPlNMaJGINih9j7s3C2 MbgFEiYDyKi9Jo1Vm1hgdaae2x3z8K0hq+Cm+wJ0= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E36523846454 for ; Sun, 25 Apr 2021 23:56:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E36523846454 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13PNts6F003569 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 25 Apr 2021 19:55:59 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13PNts6F003569 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 148031E783; Sun, 25 Apr 2021 19:55:54 -0400 (EDT) Subject: Re: [PATCH] gdb: fix sparc build failure of linux-nat To: Sergei Trofimovich , gdb-patches@sourceware.org References: <20210425200324.1953421-1-slyfox@gentoo.org> Message-ID: <8c8e919b-e886-3fdf-1370-01fd3d74cb12@polymtl.ca> Date: Sun, 25 Apr 2021 19:55:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210425200324.1953421-1-slyfox@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 25 Apr 2021 23:55:54 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Sergei Trofimovich Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-25 4:03 p.m., Sergei Trofimovich via Gdb-patches wrote: > From: Sergei Trofimovich > > On sparc build failed as: > > ``` > gdb/sparc-linux-nat.c: In member function > 'virtual void sparc_linux_nat_target::fetch_registers(regcache*, int)': > gdb/sparc-linux-nat.c:36:37: > error: cannot convert 'regcache*' to 'process_stratum_target*' > 36 | { sparc_fetch_inferior_registers (regcache, regnum); } > | ^~~~~~~~ > | | > | regcache* > ``` > > The fix adopts gdb/sparc-nat.h API change in d1e93af64a6 > ("gdb: set current thread in sparc_{fetch,collect}_inferior_registers"). > > gdb/ChangeLog: > > * sparc-linux-nat.c (sparc_linux_nat_target): fix sparc build > by passing `process_stratum_target*` parameter. > --- > gdb/sparc-linux-nat.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/sparc-linux-nat.c b/gdb/sparc-linux-nat.c > index c644d441228..33a17afa21e 100644 > --- a/gdb/sparc-linux-nat.c > +++ b/gdb/sparc-linux-nat.c > @@ -33,10 +33,10 @@ class sparc_linux_nat_target final : public linux_nat_target > public: > /* Add our register access methods. */ > void fetch_registers (struct regcache *regcache, int regnum) override > - { sparc_fetch_inferior_registers (regcache, regnum); } > + { sparc_fetch_inferior_registers (this, regcache, regnum); } > > void store_registers (struct regcache *regcache, int regnum) override > - { sparc_store_inferior_registers (regcache, regnum); } > + { sparc_store_inferior_registers (this, regcache, regnum); } > }; > > static sparc_linux_nat_target the_sparc_linux_nat_target; > Thanks, this is OK, and sorry about the breakage. If you don't have push access, tell me and I'll push it for you (but there's one commit where you are the committer, so I presume you have push access). Simon