From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QXlaEda+DGnwXyYAWB0awg (envelope-from ) for ; Thu, 06 Nov 2025 10:29:26 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IIcmC6Jl; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qDU5Blq8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IIcmC6Jl; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qDU5Blq8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 37B591E04C; Thu, 06 Nov 2025 10:29:26 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D92191E04C for ; Thu, 06 Nov 2025 10:29:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 637DF385DDC2 for ; Thu, 6 Nov 2025 15:29:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 637DF385DDC2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IIcmC6Jl; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qDU5Blq8; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=IIcmC6Jl; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qDU5Blq8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 679E1385417D for ; Thu, 6 Nov 2025 09:24:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 679E1385417D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 679E1385417D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762421041; cv=none; b=CYSoprkHm/fYfuTWht9+r5x/ew4yO6XgvcTL3ZUl9UyjJUux2ODpXo+bd5kQ7+pDT2QlIoZileItd3TT7N4j1Qx7JVlKChCFjuHHJHZJJOnvAYEJfRJIs9gLh7aSOvMiymneBUcBte+GJWv1u/qb2dVZi9ODib/prlakhB2e1uE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762421041; c=relaxed/simple; bh=5FTeCP+W+983unxhadQAHtnKCxPDzfNysYwnjpPv+CI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=lVRNmS9bsKXEEU80Ul7DQosnjHYOkxgEFTk8EIoQcTR46HVofEKRUySZk30uYTPW8inpUvo4XHP/OZMG5ybu1cKV859oh/sahOM68mdzJDr6ylGltVdY9SM9j/uHmxhg4pVnTnh5q59LKfbZVXeyP6kBgEjfyOEAfA61bVEF3xM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 679E1385417D Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 429B41F457; Thu, 6 Nov 2025 09:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1762421040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=boDdW7Ic3g51LnD4VIB4v227ZP9P4OPlX+hdHlCAnd0=; b=IIcmC6Jl87hqJkGZrKhlU8wtxgFLkBMYWLfvKywuWYlutJVUJkjAkGy53hYCAD1V1ht5bB sdQeF6qASKAA28/w87x0zhhlSYtBA1N7y4tBNoZbbYZwFP2ojwWFqtnxNQZ/JsxI5x319l 7AaRbFrlNqI1f12Ky/MxOscjStNZWsM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1762421040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=boDdW7Ic3g51LnD4VIB4v227ZP9P4OPlX+hdHlCAnd0=; b=qDU5Blq8kslJAP2dK+3j5GpPL6dfkxg08wdyrM4+ldw542aY6KXus0nn7mhSue8YyH2JW6 OXy628m9j99xUQBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1762421040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=boDdW7Ic3g51LnD4VIB4v227ZP9P4OPlX+hdHlCAnd0=; b=IIcmC6Jl87hqJkGZrKhlU8wtxgFLkBMYWLfvKywuWYlutJVUJkjAkGy53hYCAD1V1ht5bB sdQeF6qASKAA28/w87x0zhhlSYtBA1N7y4tBNoZbbYZwFP2ojwWFqtnxNQZ/JsxI5x319l 7AaRbFrlNqI1f12Ky/MxOscjStNZWsM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1762421040; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=boDdW7Ic3g51LnD4VIB4v227ZP9P4OPlX+hdHlCAnd0=; b=qDU5Blq8kslJAP2dK+3j5GpPL6dfkxg08wdyrM4+ldw542aY6KXus0nn7mhSue8YyH2JW6 OXy628m9j99xUQBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2E440139A9; Thu, 6 Nov 2025 09:24:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5vUQCjBpDGkkEAAAD6G6ig (envelope-from ); Thu, 06 Nov 2025 09:24:00 +0000 Message-ID: <8c0929d3-596a-483e-a247-b40409b0f9ab@suse.de> Date: Thu, 6 Nov 2025 10:23:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: fix command_classes name clash To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org References: <20251105225914.1492360-1-simon.marchi@polymtl.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <20251105225914.1492360-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_MATCH_FROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/5/25 11:59 PM, simon.marchi@polymtl.ca wrote: > From: Simon Marchi > > I currently see this build failure: > > CXX guile/scm-cmd.o > /home/simark/src/binutils-gdb/gdb/guile/scm-cmd.c:551:54: error: ‘const scheme_integer_constant command_classes []’ redeclared as different kind of entity > 551 | static const scheme_integer_constant command_classes[] = > | ^ > In file included from /home/simark/src/binutils-gdb/gdb/defs.h:63, > from : > /home/simark/src/binutils-gdb/gdb/command.h:71:42: note: previous declaration ‘using command_classes = class enum_flags’ > 71 | DEF_ENUM_FLAGS_TYPE (enum command_class, command_classes); > | ^~~~~~~~~~~~~~~ > /home/simark/src/binutils-gdb/gdb/../gdbsupport/enum-flags.h:58:9: note: in definition of macro ‘DEF_ENUM_FLAGS_TYPE’ > 58 | using flags_type = enum_flags; \ > | ^~~~~~~~~~ > > This looks like an unfortunate name clash. Fix it by renaming the > variable in scm-cmd.c. Hi Simon, I also ran into this problem, thanks for fixing this. The fix looks trivial enough, and I managed to build gdb and run the testsuite past gdb.guile without any fallout, so LGTM, please apply. Approved-By: Tom de Vries Thanks, - Tom > > Change-Id: I226b052c28eb8d09fd6840337845a387cd818085 > --- > gdb/guile/scm-cmd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c > index d2172d986187..bfd11917df96 100644 > --- a/gdb/guile/scm-cmd.c > +++ b/gdb/guile/scm-cmd.c > @@ -548,7 +548,7 @@ gdbscm_parse_command_name (const char *name, > /* NOTREACHED */ > } > > -static const scheme_integer_constant command_classes[] = > +static const scheme_integer_constant scm_command_classes[] = > { > /* Note: alias and user are special; pseudo appears to be unused, > and there is no reason to expose tui, I think. */ > @@ -576,9 +576,9 @@ gdbscm_valid_command_class_p (int command_class) > { > int i; > > - for (i = 0; command_classes[i].name != NULL; ++i) > + for (i = 0; scm_command_classes[i].name != NULL; ++i) > { > - if (command_classes[i].value == command_class) > + if (scm_command_classes[i].value == command_class) > return 1; > } > > @@ -903,7 +903,7 @@ gdbscm_initialize_commands (void) > = gdbscm_make_smob_type (command_smob_name, sizeof (command_smob)); > scm_set_smob_print (command_smob_tag, cmdscm_print_command_smob); > > - gdbscm_define_integer_constants (command_classes, 1); > + gdbscm_define_integer_constants (scm_command_classes, 1); > gdbscm_define_functions (command_functions, 1); > > for (i = 0; i < N_COMPLETERS; ++i) > > base-commit: 1518f2e087d31997711fc7f4472ab382c24fa903