From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zGYjIrQBAGPA9ikAWB0awg (envelope-from ) for ; Fri, 19 Aug 2022 17:33:40 -0400 Received: by simark.ca (Postfix, from userid 112) id 7F3151E4A7; Fri, 19 Aug 2022 17:33:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 971A71E21F for ; Fri, 19 Aug 2022 17:33:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 79FC93858437 for ; Fri, 19 Aug 2022 21:33:38 +0000 (GMT) Received: from mail.voxelsoft.com (45-56-90-239.ip.linodeusercontent.com [45.56.90.239]) by sourceware.org (Postfix) with ESMTPS id 1282F3858D28 for ; Fri, 19 Aug 2022 21:33:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1282F3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=voxelsoft.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=voxelsoft.com Received: by mail.voxelsoft.com (Postfix, from userid 65534) id 319081B3D9; Fri, 19 Aug 2022 17:33:26 -0400 (EDT) Received: from [192.168.1.196] (unknown [95.148.75.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.voxelsoft.com (Postfix) with ESMTPS id D5CF51B362; Fri, 19 Aug 2022 17:33:24 -0400 (EDT) Message-ID: <8bfea13a0966a62eca9cd39617918cff04915b34.camel@voxelsoft.com> Subject: Re: [PATCH] dwarf2: Fix dwarf stack fetch array view size mismatch From: Denis Lukianov To: gdb-patches@sourceware.org, Simon Marchi Date: Fri, 19 Aug 2022 22:33:08 +0100 In-Reply-To: References: <36c80f43b57fcfce3b9db6619e75366db360ae9c.camel@voxelsoft.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1-0ubuntu1 MIME-Version: 1.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew.burgess@embecosm.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Thu, 2022-08-18 at 12:27 -0400, Simon Marchi wrote: > On 8/8/22 07:24, Denis Lukianov wrote: >=20 >=20 > Your patch reminded me of a pending patch I had in the same area, > which > I just merged: >=20 > =C2=A0 > https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommit;h=3Dbde195b84= a862f31ac111c0881ad13b89ee89492 >=20 > Maybe you were seeing the same problem as described there? >=20 > Simon Hi Simon, Your check_typedef fixes my use case on little endian architectures. However, note that DWARF_VALUE_STACK case also re-slices the source val. It looks like after that it remains mismatched to the destination which also must be re-sliced to match (as per my patch, or implicitly back when this was a simple memcpy with a single length). I have no big endian resource configured to test this. Best regards, Denis