From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3f0sKpKimGnWBQMAWB0awg (envelope-from ) for ; Fri, 20 Feb 2026 13:06:10 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=dzfOufgE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8C3911E089; Fri, 20 Feb 2026 13:06:10 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 172F71E089 for ; Fri, 20 Feb 2026 13:06:05 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AEAD74B9DB69 for ; Fri, 20 Feb 2026 18:06:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AEAD74B9DB69 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=dzfOufgE Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id B0DF84BA2E19 for ; Fri, 20 Feb 2026 18:05:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B0DF84BA2E19 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B0DF84BA2E19 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771610737; cv=none; b=EMATQA+jNYsqs5J62bnGEPkqPdN3rhOhrW4miBfYvRkYZq6/SqF+kj91s6cmxRGz1bMuoKQg/7n2tCF/1PGjIq5HyF2d9G6A5j/fC67HKIPQrY4Pg87XWkUYxFuUYGxjNNH48gNEWoUaYBmhT4x5h3Q8u/ZVeF8/HrTdtIxJKOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1771610737; c=relaxed/simple; bh=w5MVqPg055ZPf4SVz30g8lpCW5Vwb4A9nHB1PQ9SUEg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=c3/L5mMRyFfl3muR5Jg244V4hmKjb8DzBnTJsM2ezwHK13KoR9J03l3juFfxe4QaUFvKz7aiqW7FA3jxcCI6zpJD+FLvpYu8E+G+Nnoq/L+EmrGbpLdFEODyRe0JFrOyjzY2C29Arf1esVP0GATDK/idY/1yLtmGI6+oLCdvZXY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0DF84BA2E19 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 61KI5QIU067883 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 13:05:31 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 61KI5QIU067883 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1771610732; bh=GpMIvkveq3X0qvGNO6teQy81EybEb8PdQtqnDlIUmaw=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=dzfOufgEDIvX6PSp+olRNwNY1P5G4dkPqB/O4vNLeNRxwLrqwGIAirZdOxpuQNqO5 VRs3pkAwipzHXKGgYkd77VNks16jxgUCBCM6Q0gwFt6Zt5sQASA1L2KvX10EXjCnL7 r7W5+eN8pP6b9BLBNSY6M4u1LdoY+yOrj2X6iGFNNqtjrXU7L40aUHbFDz/wec4ONA cathsME6Rye+xPr6s2Lith4/eh48mWYuXJW7f3UAkQsJiqeKsyBmhsFQN/+SSyDGFX 8aQ+9dbT5ce4NeE0P85aYQKaea+ZMlzpidD77nGYHt+5sudW7rcKcJUJmMGCij31Be iSew0h5Ugtx8g== Received: by simark.ca (Postfix) id 276361E089; Fri, 20 Feb 2026 13:05:26 -0500 (EST) Message-ID: <8bf3d8c0-2ac8-4f67-bbab-571381e950a5@polymtl.ca> Date: Fri, 20 Feb 2026 13:05:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/solib-frv: remove manual memory management To: Kevin Buettner , gdb-patches@sourceware.org Cc: Simon Marchi References: <20260217211650.3999842-1-simon.marchi@polymtl.ca> <20260217163253.0a8f635e@f42-zbm-amd> Content-Language: fr From: Simon Marchi In-Reply-To: <20260217163253.0a8f635e@f42-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 20 Feb 2026 18:05:26 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/17/26 6:32 PM, Kevin Buettner wrote: > On Tue, 17 Feb 2026 16:16:44 -0500 > simon.marchi@polymtl.ca wrote: > >> From: Simon Marchi >> >> - Make fetch_loadmap return a unique pointer, adjust callers >> - Make fetch_loadmap use a unique pointer for ext_ldmbuf >> - Replace some fields of lm_info_frv to be unique pointers >> - Make main_executable_lm_info a unique pointer >> >> I can only build-test this. > > I haven't had access to an FR-V machine in a long, long time, so I can't > properly test it either. > > I found a comment that should be updated... > >> @@ -102,19 +105,20 @@ struct int_elf32_fdpic_loadmap { >> struct int_elf32_fdpic_loadseg segs[1 /* nsegs, actually */]; >> }; >> >> +using int_elf32_fdpic_loadmap_up >> + = gdb::unique_xmalloc_ptr; >> + >> /* Given address LDMADDR, fetch and decode the loadmap at that address. >> Return NULL if there is a problem reading the target memory or if >> there doesn't appear to be a loadmap at the given address. The >> allocated space (representing the loadmap) returned by this >> function may be freed via a single call to xfree(). */ > > The remark about xfree should be removed and NULL should be replaced > with nullptr. Fixed. > >> -static struct int_elf32_fdpic_loadmap * >> +static int_elf32_fdpic_loadmap_up >> fetch_loadmap (CORE_ADDR ldmaddr) > > [Above lines included for context.] > > Okay with that comment fixed... > > Approved-by: Kevin Buettner Thanks, pushed. Simon