From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kXFAAPAscWg82jEAWB0awg (envelope-from ) for ; Fri, 11 Jul 2025 11:25:36 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=VrxNN0va; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E5BA51E11C; Fri, 11 Jul 2025 11:25:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0A1FA1E089 for ; Fri, 11 Jul 2025 11:25:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A36833857B8C for ; Fri, 11 Jul 2025 15:25:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A36833857B8C Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=VrxNN0va Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2110.outbound.protection.outlook.com [40.107.115.110]) by sourceware.org (Postfix) with ESMTPS id ECD833857400 for ; Fri, 11 Jul 2025 15:24:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECD833857400 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ECD833857400 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.110 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1752247472; cv=pass; b=uUFKYB6bc5uFCycpeNWaA4sBT44o+wRadhkJ9jDnItHN+SZnGjnHD9YljiSyjkey/N6DvqElSFo7+hU6xTXZueuyTrUYkx3seQYYrE6PejL0YPqKT4l4a/V0yQCyzVIBE1SG2UpBAFWg7SH07M/v/epc7wtIL2G+zG97cwcl/EA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1752247472; c=relaxed/simple; bh=7Y+d6c3uPbM564MxbMAsBBg+rnFcuLBH5uTIJNXMrrY=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=UrJpe610JjRjzy+YOCMAMo3hNSYp50kz6xy0c/US0JefjBw/9yDEIR2cMaLadrsAxIVhzlzq4ZMFg0X8voopD43FrEAb52HP1ZKZjct1rubLxwwTA5hMDvCySIJCndHxWOpQPMg7rejLxQJsQalEvzBXiVxeJuMw4QGrzyL/qsA= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECD833857400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XLDD+3uxtAxWClKUsJ1fL3b4bD5PK+q5xZTfRI9jXpDGGw7QoS8pCj+Z6B8l8EA6273+mrjWxzLjNZnCFcjQTQKu+1o3jazmKq0zxpI6q9Y0XCI2CPcyyxjBuDoyTbcbXcPqDeb5+jedn2qypZsY8Go2CC/J1+cmA0zgj7TTytz/CtIb937Q95Vxb3uhINHw4KccYKEHl8j/wg2h+Vwiw01gFubyCVTlKg0RIdzX/Sktoe3pOyUe5DdAunK9ztMke6BAIr8bKhUk+qkTz++M9SsEqsU5KjVJ9lgUiEBbgZZqO9eyMTvV9Vhy5d7++c3sanamRoWdS7SGtGlxVDHJrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l7b6DYIRsJ/v06TqLXKWan5MStuQBvu/qgTyOGQBWic=; b=iuDiiUxAsylB0RaDfmuNuaPALDthhD5MjNv0ELh2f54yH9HMrvSe1Al0BzcMHqUP96gel4ddmfqgfNrJ+mv6ckUawbJ3uOFU6+BGRFdHyqiXGVsJEXnNzEDLY1ZqpsAsoA+MBhCWH/N+ohcCS5NbtjyHZ+KuA/EaTq3CdFD2lIAicmnAaUdi031yS2sBhqmh+h8Abd5vQrtWO5Xk7zLCvtdIGAy8YGyXs/0RVG22SS4FbDkNZ1AHO6dzOhvrQ8jdvQ2MWP5xftgOuU2NywD+AbWaFwpVZIVLnK2HVylOBP+k8zHATLpZd/mG3nm8YgYA/BvDVkdbzFYIMyAJutIVfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l7b6DYIRsJ/v06TqLXKWan5MStuQBvu/qgTyOGQBWic=; b=VrxNN0vaLpfuiOfqwqMrzyc5X4DkZj2Xzl7h/8FY//kmqgqThghUhfKZ/I6IV9aPXTpTOvWN4R28aa8CzevDvdDmkFVbTbeEyYzFV87GvoM4zW/smcJxhk7zDzNPsedASgbjv8CIn4fxsObrKIatYLO4n0hB7WB5MX75IWvD1EEmUoe1SFATXaErWsp3zKBW6y5kok849cuFzS58U3iF2CynOyTdDcOkqszn+H0Z+HAkO9LcitvHw3Wbot1Lyjg8tbVJlLvJBaLhhDYPGXpmQKdEdC/TCLjb6pMLjEfA0NKeiuk8kEE0Cw7gzYs4AslTKDnDe1IUmuU+hXXNU6Y1Qg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2793.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::21) by YQBPR0101MB8399.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:53::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.27; Fri, 11 Jul 2025 15:24:28 +0000 Received: from YT1PR01MB2793.CANPRD01.PROD.OUTLOOK.COM ([fe80::cebe:dc91:3d91:68a7]) by YT1PR01MB2793.CANPRD01.PROD.OUTLOOK.COM ([fe80::cebe:dc91:3d91:68a7%3]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 15:24:27 +0000 Message-ID: <8bcdc5c0-558e-4200-aaa8-6560dddd7006@efficios.com> Date: Fri, 11 Jul 2025 11:24:25 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/solib-svr4: use program space from solib in find_debug_base_for_solib To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20250709141848.155865-1-simon.marchi@efficios.com> <20250709194423.3080d185@f41-zbm-amd> Content-Language: fr From: Simon Marchi In-Reply-To: <20250709194423.3080d185@f41-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0076.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4::9) To YT1PR01MB2793.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2793:EE_|YQBPR0101MB8399:EE_ X-MS-Office365-Filtering-Correlation-Id: ab6d91af-1f73-426b-1ef3-08ddc08f065b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OFZZbDUyMDBYWUdMYUlQMnBUWUpuUDRuTzFZRWp3VCs0ZjNoQkdZVjJOMlNL?= =?utf-8?B?aThHMlZNVmRRWW5ibVpkbWtiVmlWaVJFMUM5QWtnVG9qRkpOOENHSnNPMU1L?= =?utf-8?B?N2Fxc3NPS212Qzd4Z1FJZ3BuYmgydVFDTUh6Vk02eVNMK3RVRXdBNmVpRU5I?= =?utf-8?B?SmUwV2tiaEhJWWs2bTNnVHVDK2s2RERPNWhJcXN3elZYUmZsUkJRVUpjV0s2?= =?utf-8?B?eWp5UC8vQkR5aVdDN3crOFBPdHo2YmtQYTQrYjM3cFlIektUVlUyRzIzK3Zm?= =?utf-8?B?RStnem52SUNiSTNWdytMMURhTWRjb2FLb25WV2xRLzNMMldxcFhPS2RqY1RL?= =?utf-8?B?MlRNa2NZK2Z2cUo3eFRoc3owK3FyOVZ2eU1YdEllTGdKaE1CQ3hHWFNZYW5u?= =?utf-8?B?Q1BqYWFSV3JtR1Bwc0ZUYUZGOEZLQXlPdyt3TmEvbDF4SHk1c1orbVNZdmdq?= =?utf-8?B?MUZ5NFljaTYvRWU4ek0xYVdKc2ZIc0NhZEZaTnZoZGFJMUpDdC84dysrMnk4?= =?utf-8?B?a3Mzcm96QWJHK1E3ZW5TUS9qQzRrOFNwdDhUYTlBbFBuV1dLdnBYQ2YxM25p?= =?utf-8?B?U1RHU3N0d2FPRVlHaVZDQmpLem9BRlcrY0hBRWVEK0txK2NFYitkUmV3aCtR?= =?utf-8?B?UlZIVXRCR1RKWXM0cmwwYjd2R0hhOWY0eGkrZXc3T3JrV01nVU9vckE0dStX?= =?utf-8?B?RkVrNitNdnV4OG82WDhMcFNEQllWVHg2S2NwVG1oc3RLa0UzZmwzU0x1YnV5?= =?utf-8?B?aGM0RXBBcWRIazBJSnM5N1dmTnFpaDRDUStpR252ZzhBcldTZjI1MXJNZHI5?= =?utf-8?B?V2dlbWExbW9xVGNVMCtVcjZrU3h3WW5KY3VOejZjRllaK0kzSUVaVmExRFJs?= =?utf-8?B?U2VrM0gwZWlCTkI5NmI2Q0g4cGYwSS9LM3ZSeWFXYVRib1RjRy9tYmhBNXRV?= =?utf-8?B?MVJPQkpLUGcrdVhBOHM2blVwMUJWRVMvTUhzS2VqSmp5Mm8zMzV4dDVwOTlK?= =?utf-8?B?ak9aUlMxVHlJcnpLb1RIWFhqN1RXVy9FRkRqdTlITDJ1NU5rbHQ5UnA0MHFD?= =?utf-8?B?MS93dncyc3NYVHVFMk1TNmQzT0QrQ3ZqR2VtRzFNSmdhenNOR3BsSXNoODBD?= =?utf-8?B?SFBXVkk5emNFR3RtU3kzSWZiSEU2Y2tSckVqeHZKcEFacjRabEVoOENuUmZs?= =?utf-8?B?cndWRDhWd05yMWw5eFpkUXJIQlFtd0lLN0JFUmluM2tpU282N3hZUHZoM1VE?= =?utf-8?B?T1VDRll0RER5TmIvZXBEZFJBOFFFU05zeGJtRjhYNzBJeHdSM1Q5Q2lYSldY?= =?utf-8?B?ZjVFV3Z6MTZYdWdPOFptQWNXTHV4UVo0bFhDbnpuVzc0aE9KUEZtdG16Z3Nm?= =?utf-8?B?VkgzVFBEL09CRmpWMGoxbkY0MG9vN3BRamZTbjdtMW16WE1iV3dEckpPM2dk?= =?utf-8?B?L2tLUmNBSVFnRVB0VWVieForaGxqeVIzaTFNcjFSMkVVNUNpTlB2L2NHYTR5?= =?utf-8?B?VWNoL0RKYzJHYVovRHBxRlNnNGVnSzNJYU8yTkp1L0tWdmpJMWorazRIOG9S?= =?utf-8?B?aHI0WnlIVGhoS0FLbDhyYW5VRzF5dlorMWFmWVc0K2lKU01EQUdTZ0I0Mk5N?= =?utf-8?B?MlVQOGxtc1RyNnRVV3pNL0M5N0pSZUlVd1BkWkI2Ynh2bjdyOFlBQ2FQc1BN?= =?utf-8?B?V3ZDd0dGS3hIeHZLaThqRmZlNkNIV1FtTFc2MS9aa2NES0xPWFpsMVViRzJP?= =?utf-8?B?QUhMK0FTQXpMalFSb1pyOVMrcnB2ODVJTXRRWTJzejJyQTZKb01XTTVEUWxD?= =?utf-8?B?Y2JLc1BvSkx2ZnJYUkJuRS9oWFpvMUNTd2RLL21yZXhxS1ZyT25KZ3hzK1Rh?= =?utf-8?B?NUpIOTJUNDFKSUtQdGNRaXBrTmxJSFNDTWVtemZyZWFVL09xSVdWT2lnaERi?= =?utf-8?Q?x8aOiHcBqqg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT1PR01MB2793.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(7053199007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTVlS2xzUUI3SkNqUTVyeU1NSm9xa3h0ZU5LZTNtU3ltMVcrN1BhQktDU2Ux?= =?utf-8?B?ZFpCTERsMVJwcmRZMXRtYURnc013RmZUdS9CS0ZtbnB1UTFzZmVEdTJvLzd6?= =?utf-8?B?dGQxZXFyZ0pCNUxja2ZaeElSYkUzejVGUDVkZkxGTXdZSmhCdkVjRE1yckMy?= =?utf-8?B?bUFBb2tJVUJZcHJkSElabFU5SHlGY1Arbk1YWjFKd2E2WTJvdkFNejI3NlhQ?= =?utf-8?B?eUkrMkV6bUpjejBpZHFIY0VGQ0NPQ3ZSKzF4dTlCNS9TYlo2em9IcStYZTky?= =?utf-8?B?VkNXa0drY1cwejUvTUtUTktnN1AwcWV6VjhLeFJUTFNEVlpBNW5wMlowN2Ra?= =?utf-8?B?NFM4bEpIWW9LYVhZWTZaZXlXdzJuM0JzdEhQQlNWTWgwU1NyOWdDN3VNN1lQ?= =?utf-8?B?OUxKTGgwb2Ivbk1pV1BwK1BLckhwSWUyNUhjcjBlQzZTZEh2MzgxVWtwbFoy?= =?utf-8?B?NFBaVHIzOHk0eHdVeVBINC9HV0s4bW5pUTlCWFl0aGYzL0lZMkhwR0tsWkFF?= =?utf-8?B?bFlPMXRyMWFYbUhrbTRWeFRFcDVydWVFcWlrQnZQNTh2bHdFVDAyT2gvL2N0?= =?utf-8?B?dFRGejFqckltQ1Exa04vRHpIWThLOEVKalMzbEFGOE9td25qdjFEQ2J3WjJk?= =?utf-8?B?MW45d0E2bURjeGZlcTBESndHL1hxNVo2Zm1MOWlnYjFlenBCeHBDaHZ0NFBQ?= =?utf-8?B?bEgrK0dQLzBmcnNCaFBwWDJ6ZlBEaTFpVk12czFYbXRpSk9WQVJ1RHpJZ2JG?= =?utf-8?B?ZkkzV1ArOEtzck43L2tWaCtFTFJYbkl2T3Jsc0J6TGNBb1kwclU0Rkl1UFh6?= =?utf-8?B?enpkeitmNlROdVVsM0FHSWJvZm1icmNMZjk0MDk5YktrQU9mZGZpUXUwc09V?= =?utf-8?B?aXNSOGY4TGRUVE1jbk9oaWVpcytDS1VWdXFmdW12czFuc2FwSm1oc0loUE9w?= =?utf-8?B?RjFxYXdQSzVZRG1qWmZtZ2tibWFzVHJDQVlObTF0NURza1dBdjFhVHNrUE9w?= =?utf-8?B?NHJaQzJib1k2ZzhWcWlCcnJ1cURDdTNYK1hYSW92dFBxN0l2MmhYRkgvcmdV?= =?utf-8?B?VVRPNFhQVUhBTmx6Vk1YWmJ6bWhTOFFUQ3FTS29hRXV0UThpYm5mVjRxbERi?= =?utf-8?B?dlF2enJiMWhQeFZMMHcwelRKRGY3LzlVemJpNFdVa0dUMkxjWEhvNUFtTGZJ?= =?utf-8?B?VDhLazZpamcweEVXK0VpeGcvOTZqQlZLZTZjdDlFbmNCUVZpMEVpOFJ2OGlL?= =?utf-8?B?bHljMm90V0RWTmJSYW1aR2ExOWZZZEtSamhxU0NCZFZJL0RjMFhsWUVwUXdo?= =?utf-8?B?RDhiVHp3UlJPUFRNMHQ3UXpNc0N4QTVLVFdhWTVQdWp4dGVxdk16UkwvSXdH?= =?utf-8?B?RlZCT2JMNmNycjRTT2Z5L21CejV1ejFoZXYzTVlRR1NxeGx6S3Bwazh0b1pF?= =?utf-8?B?OHpOZS9lSk1JMU9Kd0JCNWZGekJ2ZStCZVhIRVZ0dnRNZnhkVkRyOXdsODE4?= =?utf-8?B?bzJsbXB0VVcvVElTdUtrSk5hVENGU0o5UWt5eFd2VVZSTGJJbzBNdS9jVllQ?= =?utf-8?B?UDYrK0h1eWZlbkszbWlTemZ3dkd0RHZvK2poM2h4WUlGbHRyRTZ5UWI3VHc2?= =?utf-8?B?Um5lNjR5d2xJZ3BJdHc1REJjcHAxcnFWdndoeEd5NVBDNnFDRys4K29SK0Nw?= =?utf-8?B?a3VxNngraWtIeHY0TXZqVjhOc0VhU1lBcmUvbGJKZkRoWlU2T0Jzeks4V1RB?= =?utf-8?B?VGJrQUhTR2FqRjl3Z3BPSmZhUlJRRG44UEdQdEdmNW5mRzh3NHVUSmJVMTFq?= =?utf-8?B?RDl2RXl2ZW9kRk5nR1J3OThGVFhRTUdoRmZybjErSkptZS9DLzhaY3JEaXA4?= =?utf-8?B?bk9sZ3Y0bjJ2S3dOYW1TU2RJS2N3RThKYzNNZ2ZleDNlT1FDaHNHdXhWK1Y2?= =?utf-8?B?NXNjU1RvQThLNkdMdStjUVhkN2o1aWdDRkdqaFErd2d6bUdaYzVKVUxyWlpI?= =?utf-8?B?Qy9xR0FMSFc5aWpBSlhtYnByZVZrTlAwSzN5anFGVnhlNStIRTAvM1VreXJ1?= =?utf-8?B?M01NTHFnai9ldGtvazVQK25tLzRsd05lS2ZKWUNRN2NLb000eFZmNzhaMjd6?= =?utf-8?Q?55L+/kn6AcBo4VhVnjhg9HKoZ?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab6d91af-1f73-426b-1ef3-08ddc08f065b X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2793.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 15:24:27.8620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NrbtK10QiYUDZ9Oa2OugY17xPUEf7tpR9ehVdlzDSQpz0cyoRIRiV1R6O2OU89Ihwqvv9IEJO3UHB70pHN/LDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB8399 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/9/25 10:44 PM, Kevin Buettner wrote: > On Wed, 9 Jul 2025 10:18:46 -0400 > Simon Marchi wrote: > >> Instead of using the current global program space, I think it makes >> sense to fetch the program space from the solib. The comment for >> solib::objfile indicates that it may be nullptr (which is true), but in >> this case, the callers (all in >> svr4_iterate_over_objfiles_in_search_order) find the solib from an >> objfile, so we know that solib::objfile (the link in the opposite >> direction) is set for these solibs at this point. > > Looks right to me. > > Approved-by: Kevin Buettner > Thanks, pushed. Simon