From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8791 invoked by alias); 28 Sep 2009 22:41:57 -0000 Received: (qmail 8780 invoked by uid 22791); 28 Sep 2009 22:41:56 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-gx0-f210.google.com (HELO mail-gx0-f210.google.com) (209.85.217.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Sep 2009 22:41:51 +0000 Received: by gxk2 with SMTP id 2so2965889gxk.4 for ; Mon, 28 Sep 2009 15:41:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.86.12 with SMTP id o12mr8714717ybl.253.1254177709543; Mon, 28 Sep 2009 15:41:49 -0700 (PDT) In-Reply-To: <20090928163248.GF9003@adacore.com> References: <200909272149.n8RLnRxc032281@d12av02.megacenter.de.ibm.com> <20090928163248.GF9003@adacore.com> Date: Mon, 28 Sep 2009 22:41:00 -0000 Message-ID: <8ba6bed40909281541y1d9455fas873a602caf2508fa@mail.gmail.com> Subject: Re: [rfc] Fix Obj-C method calls on 64-bit PowerPC From: Matt Rice To: Joel Brobecker Cc: Ulrich Weigand , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00889.txt.bz2 On Mon, Sep 28, 2009 at 9:32 AM, Joel Brobecker wro= te: >> =A0 =A0 =A0 * eval.c (evaluate_subexp_standard) [OP_OBJC_MSGCALL]: Suppo= rt >> =A0 =A0 =A0 platforms that use function descriptors. =A0Prefer to use fu= nction >> =A0 =A0 =A0 pointer types instead of function types. >> =A0 =A0 =A0 * linespec.c (decode_objc): Support function descriptors. = =A0Fully >> =A0 =A0 =A0 initialize SAL result. >> =A0 =A0 =A0 * objc-lang.c (find_methods): Support function descriptors. >> =A0 =A0 =A0 Do not require function symbol to point to text section. >> >> =A0 =A0 =A0 * ppc-sysv-tdep.c (ppc64_sysv_abi_push_dummy_call): When cal= ling >> =A0 =A0 =A0 via a function pointer, use the descriptor it point to. > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^^^^^ points ;-) > > Seems fine to me. Given that this fixes SEGVs, we should consider it > for inclusion in the 7.0 branch. You might want to ask ratmice@gmail.com > to give it a test before installing on 7.0, but I don't think it would > buy us much given that you already tested on s390. At least the risk > is limited to ObjC. I ran this and the tests against cvs head on x86-64 Additionally I did some tests for things by hand that aren't yet covered by the testsuite all seemed fine, thanks for looking into this.