From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3034 invoked by alias); 25 Sep 2009 04:03:14 -0000 Received: (qmail 2964 invoked by uid 22791); 25 Sep 2009 04:03:13 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-bw0-f208.google.com (HELO mail-bw0-f208.google.com) (209.85.218.208) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Sep 2009 04:03:05 +0000 Received: by bwz4 with SMTP id 4so1894259bwz.24 for ; Thu, 24 Sep 2009 21:03:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.50.22 with SMTP id c22mr1819055muk.54.1253851381007; Thu, 24 Sep 2009 21:03:01 -0700 (PDT) In-Reply-To: <20090924005319.GD5134@adacore.com> References: <8ba6bed40903051731s41c9183aha18af51113f3c0ea@mail.gmail.com> <20090306173345.GI3744@adacore.com> <200903061913.43419.pedro@codesourcery.com> <8ba6bed40903070407q3e91f0ffs6fc67b2b9c329081@mail.gmail.com> <8ba6bed40903080716k3fbeb56t5605aef1864b26a3@mail.gmail.com> <8ba6bed40903081910t695c9d93jc34ba1c5d2793a2e@mail.gmail.com> <8ba6bed40909110443v61597c4ci7effd224ce26f937@mail.gmail.com> <20090924005319.GD5134@adacore.com> Date: Fri, 25 Sep 2009 04:03:00 -0000 Message-ID: <8ba6bed40909242103m3a33cd1ck385bf3240298462c@mail.gmail.com> Subject: Re: gdb.objc/objcdecode.exp test error.. From: Matt Rice To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016e659f4022a850c04745f062c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00778.txt.bz2 --0016e659f4022a850c04745f062c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1193 On Wed, Sep 23, 2009 at 5:53 PM, Joel Brobecker wro= te: > =A0 =A0(gdb) break create > > can result in numerous breakpoints being set if create just happens > to be the name any ObjC method. And as it turns out, the NSThread > class has a method called "main"... > > I really think that allowing the above shortcut is a mis-feature > that we should consider removing. We could possibly think about > introducing another syntax meaning all "create" methods in all > classes, if it really is needed by ObjC developers. here is a patch which does this.... the previous patches i'd sent (category.diff) i keep finding failures that aren't covered by my tests. so i'll keep working on that and getting more complete test coverage, I will have to update the tests that I had previously sent because they tested the various failure modes of this feature mostly, if we remove it, there are lots of invalid tests in there that need to be tweaked. 2009-09-24 Matt Rice * linespec.c: (is_objc_method_format): Allow '[' .... ']' formatted objc methods. (decode_line_1): Don't call decode_objc unless its an objc method format. --0016e659f4022a850c04745f062c Content-Type: application/octet-stream; name="disable-misfeature.patch" Content-Disposition: attachment; filename="disable-misfeature.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g00emmz50 Content-length: 2522 ZGlmZiAtLWdpdCBhL2dkYi9kb2MvZ2RiLnRleGluZm8gYi9nZGIvZG9jL2dk Yi50ZXhpbmZvCmluZGV4IDUyMTQ5ZjAuLmQ1Mzg4NmYgMTAwNjQ0Ci0tLSBh L2dkYi9kb2MvZ2RiLnRleGluZm8KKysrIGIvZ2RiL2RvYy9nZGIudGV4aW5m bwpAQCAtMTEwODUsMTUgKzExMDg1LDYgQEAgZW50ZXI6CiBsaXN0ICtbTlNU ZXh0IGluaXRpYWxpemVdCiBAZW5kIHNtYWxsZXhhbXBsZQogCi1JbiB0aGUg Y3VycmVudCB2ZXJzaW9uIG9mIEB2YWx1ZXtHREJOfSwgdGhlIHBsdXMgb3Ig bWludXMgc2lnbiBpcwotcmVxdWlyZWQuICBJbiBmdXR1cmUgdmVyc2lvbnMg b2YgQHZhbHVle0dEQk59LCB0aGUgcGx1cyBvciBtaW51cwotc2lnbiB3aWxs IGJlIG9wdGlvbmFsLCBidXQgeW91IGNhbiB1c2UgaXQgdG8gbmFycm93IHRo ZSBzZWFyY2guICBJdAotaXMgYWxzbyBwb3NzaWJsZSB0byBzcGVjaWZ5IGp1 c3QgYSBtZXRob2QgbmFtZToKLQotQHNtYWxsZXhhbXBsZQotYnJlYWsgY3Jl YXRlCi1AZW5kIHNtYWxsZXhhbXBsZQotCiBZb3UgbXVzdCBzcGVjaWZ5IHRo ZSBjb21wbGV0ZSBtZXRob2QgbmFtZSwgaW5jbHVkaW5nIGFueSBjb2xvbnMu ICBJZgogeW91ciBwcm9ncmFtJ3Mgc291cmNlIGZpbGVzIGNvbnRhaW4gbW9y ZSB0aGFuIG9uZSBAY29kZXtjcmVhdGV9IG1ldGhvZCwKIHlvdSdsbCBiZSBw cmVzZW50ZWQgd2l0aCBhIG51bWJlcmVkIGxpc3Qgb2YgY2xhc3NlcyB0aGF0 IGltcGxlbWVudCB0aGF0CmRpZmYgLS1naXQgYS9nZGIvbGluZXNwZWMuYyBi L2dkYi9saW5lc3BlYy5jCmluZGV4IDcwZTI3ZjcuLmY0ZGM0YTcgMTAwNjQ0 Ci0tLSBhL2dkYi9saW5lc3BlYy5jCisrKyBiL2dkYi9saW5lc3BlYy5jCkBA IC00NjYsNiArNDY2LDggQEAgaXNfb2JqY19tZXRob2RfZm9ybWF0IChjb25z dCBjaGFyICpzKQogICBpZiAoKHNbMF0gPT0gJzonKSAmJiAoc3RyY2hyICgi Ky0iLCBzWzFdKSAhPSBOVUxMKSAKICAgICAgICYmIChzWzJdID09ICdbJykg JiYgc3RyY2hyKHMsICddJykpCiAgICAgcmV0dXJuIDE7CisgIGVsc2UgaWYg KHNbMF0gPT0gJ1snICYmIHN0cmNocihzLCAnXScpKQorICAgIHJldHVybiAx OyAKICAgLyogSGFuZGxlIGFyZ3VtZW50cyB0aGF0IGFyZSBqdXN0IFNZTUJP TC4gICovCiAgIGVsc2UgaWYgKChzdHJjaHIgKCIrLSIsIHNbMF0pICE9IE5V TEwpICYmIChzWzFdID09ICdbJykgJiYgc3RyY2hyKHMsICddJykpCiAgICAg cmV0dXJuIDE7CkBAIC03MzksMTMgKzc0MSwxNCBAQCBkZWNvZGVfbGluZV8x IChjaGFyICoqYXJncHRyLCBpbnQgZnVuZmlyc3RsaW5lLCBzdHJ1Y3Qgc3lt dGFiICpkZWZhdWx0X3N5bXRhYiwKIAogICAvKiBDaGVjayBpZiB0aGUgc3lt Ym9sIGNvdWxkIGJlIGFuIE9iamVjdGl2ZS1DIHNlbGVjdG9yLiAgKi8KIAot ICB7Ci0gICAgc3RydWN0IHN5bXRhYnNfYW5kX2xpbmVzIHZhbHVlczsKLSAg ICB2YWx1ZXMgPSBkZWNvZGVfb2JqYyAoYXJncHRyLCBmdW5maXJzdGxpbmUs IE5VTEwsCi0JCQkgIGNhbm9uaWNhbCwgc2F2ZWRfYXJnKTsKLSAgICBpZiAo dmFsdWVzLnNhbHMgIT0gTlVMTCkKLSAgICAgIHJldHVybiB2YWx1ZXM7Ci0g IH0KKyAgaWYgKGlzX29iamNfbWV0aG9kKQorICAgIHsKKyAgICAgIHN0cnVj dCBzeW10YWJzX2FuZF9saW5lcyB2YWx1ZXM7CisgICAgICB2YWx1ZXMgPSBk ZWNvZGVfb2JqYyAoYXJncHRyLCBmdW5maXJzdGxpbmUsIE5VTEwsCisJCQkg ICAgY2Fub25pY2FsLCBzYXZlZF9hcmcpOworICAgICAgaWYgKHZhbHVlcy5z YWxzICE9IE5VTEwpCisgICAgICAgIHJldHVybiB2YWx1ZXM7CisgICAgfQog CiAgIC8qIERvZXMgaXQgbG9vayBsaWtlIHRoZXJlIGFjdHVhbGx5IHdlcmUg dHdvIHBhcnRzPyAgKi8K --0016e659f4022a850c04745f062c--