From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17792 invoked by alias); 24 Sep 2009 06:48:33 -0000 Received: (qmail 17772 invoked by uid 22791); 24 Sep 2009 06:48:29 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_34,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-yw0-f201.google.com (HELO mail-yw0-f201.google.com) (209.85.211.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Sep 2009 06:48:23 +0000 Received: by ywh39 with SMTP id 39so1684487ywh.12 for ; Wed, 23 Sep 2009 23:48:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.119.27 with SMTP id r27mr5929037ybc.206.1253774900547; Wed, 23 Sep 2009 23:48:20 -0700 (PDT) In-Reply-To: <20090923231317.GA18470@adacore.com> References: <8ba6bed40903051731s41c9183aha18af51113f3c0ea@mail.gmail.com> <20090306173345.GI3744@adacore.com> <200903061913.43419.pedro@codesourcery.com> <8ba6bed40903070407q3e91f0ffs6fc67b2b9c329081@mail.gmail.com> <8ba6bed40903080716k3fbeb56t5605aef1864b26a3@mail.gmail.com> <20090923231317.GA18470@adacore.com> Date: Thu, 24 Sep 2009 06:48:00 -0000 Message-ID: <8ba6bed40909232348j47027093of7a2bafb8120e5ce@mail.gmail.com> Subject: Re: gdb.objc/objcdecode.exp test error.. From: Matt Rice To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00741.txt.bz2 On Wed, Sep 23, 2009 at 4:13 PM, Joel Brobecker wro= te: > Matt, > >> attached are new tests, and patches for the bug, > > I'm only going to look at the testcase patch for now, since it appears > that the code patches are not ready yet (they fix your issues, but > at the price of breaking other things, right?). We can work on the > code patches separately (but, if you don't mind, summarize again what > the issues are all about, because i'm having a tough time going through > the scattered emails). Thats fine > 2009-03-05 =A0Matt Rice =A0 > > =A0 =A0 =A0 =A0* gdb.objc/objcdecode.exp: Set the multiple symbols found = behaviour > =A0 =A0 =A0 =A0to ask for the original test. Add tests for the multiple s= ymbols > =A0 =A0 =A0 =A0found behaviour of all. > >> +do_objc_tests > > I know it's not your fault, but it's definitely a misleading name for > a routine that simple restarts the debugger... Would you mind renaming > it to something more meaningful? I noticed also that a couple of global > declarations are not referenced from that routine, and so can be > removed: objdir and gdb_prompt. > > Thanks! :) np, this is also duplicated in the 2 .exp files, i should figure out if i can somehow include it from the gdb.objc? >> +gdb_test "set multiple-symbols all after main" "" > > Uh oh, looks like you merged the command being sent to GDB with > the description of the test :) oops, >> +gdb_test_multiple "break multipleDef" $name \ >> +{ >> + =A0-re "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*\r\nBreakpoint \[= 0-9\]+ at 0x\[0-9a-f\]+: file .*\r\n$gdb_prompt $" { pass $name } >> + =A0-re ".*$gdb_prompt $" =A0 { fail $name } >> +} > > The following can be simplified into a simple call to gdb_test, no? > Also, please consider adding a call to setup_kfail if we expect > the test to fail with the current sources. =A0This is true of most if not > all the tests that are you adding. > yeah, I tried to fix all of these in the patch, there are a couple gdb_test_multiple's left that looks like they need to be. I also added the setup_kfails, adjusted the existing kfails to use the bugzilla #. I will try to remember to go through grep and look for more in testsuite/ well, theres a lot of tests that pass that just involve various setup for the tests which fail, i think ideally, these would not be tests, but e.g. if i just do send_gdb I seem to run into lots of timing issues, i just kfailed the ones that do f= ail. ChangeLog is in the git patch header. > The call to gdb_exit before do_objc_tests is unnecessary. k >> +gdb_exit >> +return 0 > > I don't think that this is necessary. All scripts do a little bit of > cleanup before starting the meat of the testcase, so let's not do double > pollution... k