From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8299 invoked by alias); 19 Sep 2009 12:01:43 -0000 Received: (qmail 8162 invoked by uid 22791); 19 Sep 2009 12:01:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-yw0-f184.google.com (HELO mail-yw0-f184.google.com) (209.85.211.184) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 Sep 2009 12:01:36 +0000 Received: by ywh14 with SMTP id 14so2317346ywh.26 for ; Sat, 19 Sep 2009 05:01:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.20.17 with SMTP id x17mr5029935ybi.102.1253361694449; Sat, 19 Sep 2009 05:01:34 -0700 (PDT) In-Reply-To: References: Date: Sat, 19 Sep 2009 12:01:00 -0000 Message-ID: <8ba6bed40909190501k3bd165f5xf062d18fe7d9ba8d@mail.gmail.com> Subject: Re: Patch: implement new dynamic varobj spec From: Matt Rice To: tromey@redhat.com Cc: gdb-patches@sources.redhat.com Content-Type: multipart/mixed; boundary=000e0cd4b10492a0ed0473ed023b X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00629.txt.bz2 --000e0cd4b10492a0ed0473ed023b Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Content-length: 465 On Tue, Sep 15, 2009 at 11:48 AM, Tom Tromey wrote: > Thanks. I am checking in the appended. gcc 4.5 gets =91children_changed=92 may be used uninitialized in this funct= ion, even though update_dynamic_varobj_children sets it unconditionally, seems conservative not to rely on the other function to initialize it through the pointer passed. 09-19-2009 Matt Rice * varobj.c (varobj_update): Initialize children_changed. --000e0cd4b10492a0ed0473ed023b Content-Type: application/octet-stream; name="foo.diff" Content-Disposition: attachment; filename="foo.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fzsarj3n0 Content-length: 545 ZGlmZiAtLWdpdCBhL2dkYi92YXJvYmouYyBiL2dkYi92YXJvYmouYwppbmRl eCA3MjM1NjM1Li44ZjIyMTU2IDEwMDY0NAotLS0gYS9nZGIvdmFyb2JqLmMK KysrIGIvZ2RiL3Zhcm9iai5jCkBAIC0xNzU4LDcgKzE3NTgsNyBAQCBWRUMo dmFyb2JqX3VwZGF0ZV9yZXN1bHQpICp2YXJvYmpfdXBkYXRlIChzdHJ1Y3Qg dmFyb2JqICoqdmFycCwgaW50IGV4cGxpY2l0KQogICAgICAgaWYgKHYtPnBy ZXR0eV9wcmludGVyKQogCXsKIAkgIFZFQyAodmFyb2JqX3ApICpjaGFuZ2Vk ID0gMCwgKm5ldyA9IDAsICp1bmNoYW5nZWQgPSAwOwotCSAgaW50IGksIGNo aWxkcmVuX2NoYW5nZWQ7CisJICBpbnQgaSwgY2hpbGRyZW5fY2hhbmdlZCA9 IDA7CiAKIAkgIGlmICh2LT5mcm96ZW4pCiAJICAgIGNvbnRpbnVlOwo= --000e0cd4b10492a0ed0473ed023b--