From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2294 invoked by alias); 7 Mar 2009 12:07:44 -0000 Received: (qmail 2283 invoked by uid 22791); 7 Mar 2009 12:07:43 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-fx0-f177.google.com (HELO mail-fx0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 07 Mar 2009 12:07:34 +0000 Received: by fxm25 with SMTP id 25so695233fxm.24 for ; Sat, 07 Mar 2009 04:07:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.247.14 with SMTP id z14mr1540087mur.70.1236427651547; Sat, 07 Mar 2009 04:07:31 -0800 (PST) In-Reply-To: <200903061913.43419.pedro@codesourcery.com> References: <8ba6bed40903051731s41c9183aha18af51113f3c0ea@mail.gmail.com> <20090306173345.GI3744@adacore.com> <200903061913.43419.pedro@codesourcery.com> Date: Sat, 07 Mar 2009 12:07:00 -0000 Message-ID: <8ba6bed40903070407q3e91f0ffs6fc67b2b9c329081@mail.gmail.com> Subject: Re: gdb.objc/objcdecode.exp test error.. From: Matt Rice To: gdb-patches@sourceware.org Cc: Joel Brobecker Content-Type: multipart/mixed; boundary=001636765bbdf602280464863e42 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00093.txt.bz2 --001636765bbdf602280464863e42 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 4014 Joel Wrote: >but it would be better if you had a proper copyright assignment >at least for GDB (I suggest to assign any past and future changes >to any GNU software and be done with it, but I understand if you prefer >to choose a more limited list of projects). Thanks, I wasn't aware I could assign to all gnu projects, I've started the paperwork, i'll let you know when its gone through. >In the meantime, this looks reasonable to me. I can check it in >for you if you'd like. it doesn't matter much to me, we might as well just wait and get the new tests in. On Fri, Mar 6, 2009 at 11:13 AM, Pedro Alves wrote: > Joel Wrote: >> Matt Rice wrote: >> > i should probably come up with another test for multiple-symbols all, >> > so neither failure gets forgotten, but i'll have to learn more about >> > dejagnu before i'm able to do that. > >> That would be very nice if you could add these extra tests. >> It makes sense to test the behaviour in the "ask" case, but we really >> ought to try to test the default case as well. > > Indeed. =A0This test internal-errors for me currently, but the patch masks > it. =A0I don't see any internal error mentioned in the PRs which > are linked from the kfails? =A0It looks like a different bug. > > =A0http://sourceware.org/bugzilla/show_bug.cgi?id=3D8341 > =A0http://sourceware.org/bugzilla/show_bug.cgi?id=3D8343 > > (gdb) PASS: gdb.objc/objcdecode.exp: break on multiply defined method > run > Starting program: /home/pedro/gdb/baseline/build/gdb/testsuite/gdb.objc/o= bjcdecode > ../../src/gdb/breakpoint.c:7451: internal-error: breakpoint_re_set_one: A= ssertion `sals.nelts =3D=3D 1' failed. > A problem internal to GDB has been detected, > further debugging may prove unreliable. > yes this is a different albeit somewhat related bug, (same cause, different effect), it doesn't get this far when using 'ask'. I went ahead and tried to do some new tests, when trying to clean those up to use gdb_continue_to_breakpoint, I discovered that it works correctly after we've hit main, so i added some tests for that since it appears to be touching different code paths. below is some more information, on further reducing the test, I wasn't sure if or how I should incorporate into the test, as i'm not sure about the reliability of hard coding breakpoint numbers nor a way to delete a breakpoint by function name, it probably doesn't matter its already pretty much reduced. let me know if you guys have any issues with the tests or ideas on doing things cleaner, still pretty new to dejagnu and its mostly just modifications of the original 'ask' test. Use the "delete" command to delete unwanted breakpoints. (gdb) info b Num Type Disp Enb Address What 1 breakpoint keep y 0x000000000040072c in -[Decode multipleDef] at ../.././gdb/testsuite/gdb.objc/objcdecode.m:14 2 breakpoint keep y 0x0000000000400753 in multipleDef at ../.././gdb/testsuite/gdb.objc/objcdecode.m:28 (gdb) delete 2 (gdb) r Starting program: /home/ratmice/git/gdb/gdb/testsuite/gdb.objc/objcdecode function multipleDef Breakpoint 1, -[Decode multipleDef] (self=3D0x604f20, _cmd=3D0x601450) at ../.././gdb/testsuite/gdb.objc/objcdecode.m:14 14 printf("method multipleDef\n"); (gdb) c Continuing. method multipleDef Program exited normally. (gdb) delete 1 (gdb) break multipleDef Breakpoint 3 at 0x40072c: file ../.././gdb/testsuite/gdb.objc/objcdecode.m, line 14. Breakpoint 4 at 0x400753: file ../.././gdb/testsuite/gdb.objc/objcdecode.m, line 28. warning: Multiple breakpoints were set. Use the "delete" command to delete unwanted breakpoints. (gdb) delete 3 (gdb) r Starting program: /home/ratmice/git/gdb/gdb/testsuite/gdb.objc/objcdecode breakpoint.c:7450: internal-error: breakpoint_re_set_one: Assertion `sals.nelts =3D=3D 1' failed. so it only fails on the multipleDef function, not the multipleDef method. --001636765bbdf602280464863e42 Content-Type: application/octet-stream; name="foo.diff" Content-Disposition: attachment; filename="foo.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_frzr3jhq0 Content-length: 4181 ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvQ2hhbmdlTG9nIGIvZ2RiL3Rl c3RzdWl0ZS9DaGFuZ2VMb2cKaW5kZXggNTBlNjFjZS4uNDYxN2M0ZCAxMDA2 NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9DaGFuZ2VMb2cKKysrIGIvZ2RiL3Rl c3RzdWl0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSw5IEBACisyMDA5LTAzLTA1 ICBNYXR0IFJpY2UgIDxyYXRtaWNlQGdtYWlsLmNvbT4KKworCSogZ2RiLm9i amMvb2JqY2RlY29kZS5leHA6IFNldCB0aGUgbXVsdGlwbGUgc3ltYm9scyBm b3VuZCBiZWhhdmlvdXIKKwl0byBhc2sgZm9yIHRoZSBvcmlnaW5hbCB0ZXN0 LiBBZGQgdGVzdHMgZm9yIHRoZSBtdWx0aXBsZSBzeW1ib2xzCisJZm91bmQg YmVoYXZpb3VyIG9mIGFsbC4KKwogMjAwOS0wMy0wNSAgUGF1bCBQbHV6aG5p a292ICA8cHBsdXpobmlrb3ZAZ29vZ2xlLmNvbT4KIAogCSogc29saWItZGlz cGxheS5leHA6IE5ldyBmaWxlLgpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0 ZS9nZGIub2JqYy9vYmpjZGVjb2RlLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2Ri Lm9iamMvb2JqY2RlY29kZS5leHAKaW5kZXggYjc1MWZiOS4uMWI3N2FhNiAx MDA2NDQKLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIub2JqYy9vYmpjZGVjb2Rl LmV4cAorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5vYmpjL29iamNkZWNvZGUu ZXhwCkBAIC01OSw3ICs1OSw4IEBAIGRvX29iamNfdGVzdHMKICMKICMgQnJl YWsgb24gbXVsdGlwbHkgZGVmaW5lZCBtZXRob2QgKFBSIG9iamMvMTIzNikK ICMKLXNldCBuYW1lICJicmVhayBvbiBtdWx0aXBseSBkZWZpbmVkIG1ldGhv ZCIKK3NldCBuYW1lICJicmVhayBvbiBtdWx0aXBseSBkZWZpbmVkIG1ldGhv ZCB1c2luZyBtdWx0aXBsZS1zeW1ib2xzIGFzayIKK2dkYl90ZXN0ICJzZXQg bXVsdGlwbGUtc3ltYm9scyBhc2siICIiCiBnZGJfdGVzdF9tdWx0aXBsZSAi YnJlYWsgbXVsdGlwbGVEZWYiICRuYW1lIFwKIHsKICAgICAtcmUgIlxcXFsw XFxcXSBjYW5jZWxcclxuXFxcWzFcXFxdIGFsbFxyXG5cXFxbMlxcXF0gLS5E ZWNvZGUgbXVsdGlwbGVEZWYuIGF0IC4qXHJcblxcXFszXFxcXSBtdWx0aXBs ZURlZiBhdCAuKlxyXG4+ICQiIHsKQEAgLTcwLDcgKzcxLDcgQEAgZ2RiX3Rl c3RfbXVsdGlwbGUgImJyZWFrIG11bHRpcGxlRGVmIiAkbmFtZSBcCiAgICAg LXJlICIuKiRnZGJfcHJvbXB0ICQiICAgeyBrZmFpbCAiZ2RiLzEyMzYiICRu YW1lIH0KIH0KIAotc2V0IG5hbWUgImNvbnRpbnVlIGFmdGVyIGJyZWFrIG9u IG11bHRpcGx5IGRlZmluZWQgc3ltYm9sIgorc2V0IG5hbWUgInJ1biBhZnRl ciBzZXR0aW5nIGJyZWFrcG9pbnRzIG9uIG11bHRpcGx5IGRlZmluZWQgc3lt Ym9sIgogZ2RiX3J1bl9jbWQKIGdkYl90ZXN0X211bHRpcGxlICIiICRuYW1l IFwKIHsKQEAgLTg0LDMgKzg1LDUzIEBAIGdkYl90ZXN0X211bHRpcGxlICIi ICRuYW1lIFwKIAkjIEl0IHdvdWxkIGJlIGRpZmZpY3VsdCB0byBkbyBhbnkg bW9yZSB0ZXN0cyBhZnRlciB0aGlzLgogICAgIH0KIH0KKworZG9fb2JqY190 ZXN0cworaWYgIVtydW50b19tYWluXSB7IGZhaWwgIkNhbid0IHJ1biB0byBt YWluIiB9CisKK3NldCBuYW1lICJicmVhayBvbiBtdWx0aXBseSBkZWZpbmVk IHN5bWJvbCB3aXRoIG11bHRpcGxlLXN5bWJvbHMgYWxsIGFmdGVyIG1haW4i CitnZGJfdGVzdCAic2V0IG11bHRpcGxlLXN5bWJvbHMgYWxsIGFmdGVyIG1h aW4iICIiCitnZGJfdGVzdF9tdWx0aXBsZSAiYnJlYWsgbXVsdGlwbGVEZWYi ICRuYW1lIFwKK3sKKyAgLXJlICJCcmVha3BvaW50IFxbMC05XF0rIGF0IDB4 XFswLTlhLWZcXSs6IGZpbGUgLipcclxuQnJlYWtwb2ludCBcWzAtOVxdKyBh dCAweFxbMC05YS1mXF0rOiBmaWxlIC4qXHJcbiRnZGJfcHJvbXB0ICQiIHsg cGFzcyAkbmFtZSB9CisgIC1yZSAiLiokZ2RiX3Byb21wdCAkIiAgIHsgZmFp bCAkbmFtZSB9Cit9CisKK3NldCBuYW1lICJjYW4gaGl0IG11bHRpcGx5IGRl ZmluZWQgYnJlYWtwb2ludCBvbiBmdW5jdGlvbiBhZnRlciBtYWluIgorZ2Ri X2NvbnRpbnVlX3RvX2JyZWFrcG9pbnQgImZ1bmN0aW9uIG11bHRpcGxlRGVm IgorCitzZXQgbmFtZSAiY2FuIGhpdCBtdWx0aXBseSBkZWZpbmVkIGJyZWFr cG9pbnQgb24gb2JqYyBtZXRob2QgYWZ0ZXIgbWFpbiIKK2dkYl9jb250aW51 ZV90b19icmVha3BvaW50ICJtZXRob2QgbXVsdGlwbGVEZWYiCitnZGJfZXhp dAorCitkb19vYmpjX3Rlc3RzCisKK3NldCBuYW1lICJicmVhayBvbiBtdWx0 aXBseSBkZWZpbmVkIHN5bWJvbCB3aXRoIG11bHRpcGxlLXN5bWJvbHMgYWxs IGJlZm9yZSBtYWluIgorZ2RiX3Rlc3RfbXVsdGlwbGUgImJyZWFrIG11bHRp cGxlRGVmIiAkbmFtZSBcCit7CisgIC1yZSAiQnJlYWtwb2ludCBcWzAtOVxd KyBhdCAweFxbMC05YS1mXF0rOiBmaWxlIC4qXHJcbkJyZWFrcG9pbnQgXFsw LTlcXSsgYXQgMHhcWzAtOWEtZlxdKzogZmlsZSAuKlxyXG4kZ2RiX3Byb21w dCAkIiB7IHBhc3MgJG5hbWUgfQorICAtcmUgIi4qJGdkYl9wcm9tcHQgJCIg ICB7IGZhaWwgJG5hbWUgfQorfQorCitzZXQgbmFtZSAiY2FuIGhpdCBtdWx0 aXBseSBkZWZpbmVkIGJyZWFrcG9pbnQgb24gZnVuY3Rpb24gYmVmb3JlIG1h aW4iCitnZGJfcnVuX2NtZAorZ2RiX3Rlc3RfbXVsdGlwbGUgIiIgJG5hbWUg XAoreworICAgLXJlICJCcmVha3BvaW50IFxbMC05XF0rLCBtdWx0aXBsZURl ZiBcXFwoXFxcKSBhdCAuKlxyXG4kZ2RiX3Byb21wdCAkIiB7CisJcGFzcyAk bmFtZQorICAgIH0KKyAgIC1yZSAiLiokZ2RiX3Byb21wdCAkIiB7IGZhaWwg JG5hbWUgfQorfQorCitzZXQgbmFtZSAiY2FuIGhpdCBtdWx0aXBseSBkZWZp bmVkIGJyZWFrcG9pbnQgb24gZnVuY3Rpb24gYmVmb3JlIG1haW4iCitnZGJf dGVzdF9tdWx0aXBsZSAiY29udGludWUiICRuYW1lIFwKK3sKKyAgIC1yZSAi QnJlYWtwb2ludCBcWzAtOVxdKywgLVxbRGVjb2RlIG11bHRpcGxlRGVmXF0g YXQgLipcclxuJGdkYl9wcm9tcHQgJCIgeworCXBhc3MgJG5hbWUKKyAgICB9 CisgICAtcmUgIi4qJGdkYl9wcm9tcHQgJCIgeyBmYWlsICRuYW1lIH0KK30K KworZ2RiX2V4aXQKK3JldHVybiAwCisK --001636765bbdf602280464863e42--