From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] python: Make two functions return gdbpy_ref<>
Date: Sun, 09 Sep 2018 07:14:00 -0000 [thread overview]
Message-ID: <8b5ce61f643215bc9bb8e1aa1b02b205@polymtl.ca> (raw)
In-Reply-To: <874lez5qhb.fsf@tromey.com>
On 2018-09-09 03:55, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> I noticed that we release a gdbpy_ref in pretty_print_one_value
> only to
> Simon> create it again later. This patch fills the gap by returning a
> Simon> gdbpy_ref all the way.
>
> Simon> gdb/ChangeLog:
>
> Simon> * python/py-prettyprint.c (pretty_print_one_value): Return
> Simon> gdbpy_ref<>.
> Simon> (print_string_repr): Adjust.
> Simon> (apply_varobj_pretty_printer): Return gdbpy_ref<>.
> Simon> * python/python-internal.h (apply_varobj_pretty_printer):
> Return
> Simon> gdbpy_ref<>.
> Simon> * varobj.c (varobj_value_get_print_value): Adjust.
>
> Thanks, this seems like a good improvement to me.
> I'm sure there are more of these lurking.
Thanks, I pushed it.
Simon
prev parent reply other threads:[~2018-09-09 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 23:22 Simon Marchi
2018-09-09 2:55 ` Tom Tromey
2018-09-09 7:14 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b5ce61f643215bc9bb8e1aa1b02b205@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox