From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127114 invoked by alias); 27 Oct 2016 14:55:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127101 invoked by uid 89); 27 Oct 2016 14:55:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bfd_vma, memaddr X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Oct 2016 14:55:35 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 720F03D95C; Thu, 27 Oct 2016 14:55:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9REtXnO026418; Thu, 27 Oct 2016 10:55:33 -0400 Subject: Re: [PATCH 10/13] Remove gdbarch_remote_breakpoint_from_pc To: Yao Qi , gdb-patches@sourceware.org References: <1472655965-12212-1-git-send-email-yao.qi@linaro.org> <1472655965-12212-11-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <8b263433-7234-dca6-c0c3-0e4f2eb41daf@redhat.com> Date: Thu, 27 Oct 2016 14:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472655965-12212-11-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00759.txt.bz2 On 08/31/2016 04:06 PM, Yao Qi wrote: > --- a/gdb/mips-tdep.c > +++ b/gdb/mips-tdep.c > @@ -7050,7 +7050,18 @@ gdb_print_insn_mips_n64 (bfd_vma memaddr, struct disassemble_info *info) > return gdb_print_insn_mips (memaddr, info); > } > > -/* Implement the breakpoint_kind_from_pc gdbarch method. */ > +/* Implement the breakpoint_kind_from_pc gdbarch method. > + > + Determine the remote breakpoint kind suitable for the PC. The following > + kinds are used: > + > + * 2 -- 16-bit MIPS16 mode breakpoint, > + > + * 3 -- 16-bit microMIPS mode breakpoint, > + > + * 4 -- 32-bit standard MIPS mode breakpoint, > + > + * 5 -- 32-bit microMIPS mode breakpoint. */ > Isn't this duplicating info that's now on the enum? I was surprised to find this in this mostly unrelated patch. > static int > mips_breakpoint_kind_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pcptr) > @@ -7178,15 +7189,6 @@ mips_sw_breakpoint_from_kind (struct gdbarch *gdbarch, int kind, Thanks, Pedro Alves