From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18692 invoked by alias); 29 Nov 2016 16:42:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18667 invoked by uid 89); 29 Nov 2016 16:42:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Nov 2016 16:42:19 +0000 Received: from ESESSHC006.ericsson.se (Unknown_Domain [153.88.183.36]) by (Symantec Mail Security) with SMTP id 61.BF.03096.7EFAD385; Tue, 29 Nov 2016 17:42:16 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 29 Nov 2016 17:42:14 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.49.242] (192.75.88.130) by AMSPR07MB390.eurprd07.prod.outlook.com (10.242.22.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.761.5; Tue, 29 Nov 2016 16:42:13 +0000 Subject: Re: [PATCH] Prevent turning record on while threads are running (PR 20869) To: Luis Machado , References: <20161129150758.29912-1-simon.marchi@ericsson.com> CC: From: Simon Marchi Message-ID: <8b198908-9a78-d2e8-1726-a471d3afb9b7@ericsson.com> Date: Tue, 29 Nov 2016 16:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN1PR16CA0059.namprd16.prod.outlook.com (10.163.13.27) To AMSPR07MB390.eurprd07.prod.outlook.com (10.242.22.13) X-MS-Office365-Filtering-Correlation-Id: 390fa88c-c4ed-4210-2ac6-08d41876ac40 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:AMSPR07MB390; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;3:8uwW6brPUHFQBzHK+/YLcQPifnhcNr4xWxm9sCqUpND6OEHojjoo2/BixhnsUED+29viDddbJ7UVaXjQcXk6GlsGr83QdW/ENl1OFFRWz6wTijUzudLne83sn4HHaImEww5oFvjZz/RGHUWXUWrOJogOCUA38FB8MobtJuTygr17fJIpu4c9Vs0pfnYP7mf1joxC/5ioBtvQcNyxn8LcXTxHuGl2jSYoiTNEZAHS42iXWzEqwnucXKF+aoM9N7iYXX1MD9uf4JPxxB4T7e1N0Q== X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;25:vOj4EDWEUKg6lLju2VhkDJY8owJDdgmGFhWkASf4vER4vhdUYwGfG0jC6BmyRuUXNPMFkDiFrEYy/MCuR925cD5s4zuQ/KUQqUKusOryhSXNLRbRgL8titWynvmxGCuJKcioY7v0r83wbULggGCeLzADzvK5pevl0Z9Yw58J2uSzKfMtUVBOoo2Dkw8Af9rsMMXK9PiDsruZLV3R+FUaINIfFfiIUwvgVVXSd0sDGec3nEbY2L/IpOjanLjdGEHmr6dFeZjixwyoBJFj6e6+lpOYXQbLnMgy/6AKE2eEe4TY05cgzWROuzBulwMIoYVMCje0q/rk+/1oYUoiKHjE0si4Dnoy/CW53l/8UwILtClREZ2wKkv9v5xqUMVp9rZ2PDjR5Fhh49Eo+Sm+1mPI1AfvbTtilMwiQessny3lnRFPcO2B7X4OfEV5RRzxyZaX5RmqEViOhxnotq6T2y2Xza8hWj/qF0ousV/XUV81nbfQNd8iiUk09fZtsgNjZT53UGM+eymi+Bevs2vp4yPYfLGdn3kmDuncvrXjKMd196n6GwG5dy3VdW8ENd5SPjpzasaOnFeXKx0xTogrOs9Fry3ieol8PqwWTg5QHTZICrt9kX/djrZ3CIiMcdvwa0b+tZ0K0F588kvc5BLbyJHzntQ8BwwtyLbS+eyxSIeJckQ2WlymmqVCkfVeUcCdgQAdDOFmAVbWBjbqqDIZHIUsuoCtBjpFIStoh+ZbwTwFO/3HVCPKxgVjFk5ARALz6mrV2ECFHPP+e5yZAJzqOZ1kJQ== X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;31:40XUeDwyT25/pKjAVN0whYKdm1LobOG4pSCWzErmPtfCawSDTbLiYbAhIMKZ5K4MLgTSMURvNhLbE0r4zXMQs7OuWJQ3AstkGHWlODj7gROzWgHQT0pXK7UF6fs/ahxJQ33/QkRbTuPZ9XdFHhel3/5RjkL2I+KFKhRQhCx5lEaPYHQdle3Lj30Jm77YvCYEKi3guyL35m+LlEVtdhnHYXE8P6/pARIx/0xRpQ06oJOaEOQqgE6NWz5mUOi7CVQ6hRReM/jf6Dj8iVjVZI3drg==;20:qD0AzOUiqn7FAnTqRR1meptgctLw4piT6mB0pQI9lGPM0yKJfZ5Adw9aOhpaEh3grbHaQpO/aCNOIrDufSvzW8EJcbBkre1jdb7OWdvKGZIfGdxITY0Lcw5Pz/27ArYRnbNYfxmTMUVoQoDr2Ftrqa1vWHc0IRCEOFjUTOTrf5dWrPn7/MJ2T6Z0bMdBEOOsKbuc3ooBDi5FgmVkhwsc2WhP848aOsMPGZbWCwhwiDv4ddu5DKz3qoC2u/qKMF9v6PML/lcpwEt0ra1yYGtTItCXoLCVAU7gfwkgBIEeM/nr8vqiYbX69kXVsdZ5n2kkXvarMfkvlVpCdmcOqn9qYO+vkJ5L29c137EoWqmyWxW/SF/OuJpNahe5Yc+/7QdZh8eXl/H6wVYVtGzQAEcD/2mPc3h4o2SMcyYhqPgVbO0VBJRx1U0OiLBhso3L3VmHmXhnbSe38biqV9I4vg/7c9UtWMV4tjbt+L1hgSgGtuAdczNWJ3+PPn/xWj2vn5CD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(6040361)(6045199)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6061324)(6041248)(20161123558021)(20161123555025)(20161123560025)(20161123564025)(20161123562025);SRVR:AMSPR07MB390;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB390; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;4:ErOUOuXk+1KvFRY2gEN18WjFyNNzVPZ6/vt70sJ6KyWWTEsUGzBVSGy2otDpAb5X/oIxbrXkY/KAvgd3nSR5jHJ8R/FpQMFq0HtqbDmZ4BQSiAZdNXWkEGX6eq6MJyHVHfQ242ZshwzajZ4yi1YTr7Uhjs3Ws42l4sVR8rwPYHZGO/NyKQl5waN2rIVCeMz1978Amzgo/Fil0fzGzs0Y+pd5rDUZlN3H5Wo9Et3QmA4KdnWk/nAmi2+j8vZlXasI49bd34cDkfoqFgr8Nana/lQz5naH1b3BW47aVyCGpsxFtF4aAyx9YcZbdJLGQen3PhYjHQcvv5kYKS7o1BwPWo0GWKIfHK0X3IEeG4f67cSL4a8QN7FobqlfUfYV1MyLTVneEElJqLy/SacDRQjHnF3KemCwNlSYR4elOA83JkXrR6fdimlIo353quHFnoaVV/dBCpLIQ1KEOjafHPKKqjXJiAngJum7cs0nVu3R1BxGbYEX5SRU6CKV0VcBzH+wv7M4HWW2G5DhmnL4fXTQO3E1jEuPuctMbwaJIqImXWZ3CLYLjvsph8ImEGFpAjPbLnxQ0JgWR4mA/HDMyqJomhEpUfeYNAdXAYLLiSyZ63diXvKqpIU6Mq+VAxaNqzQR+ii6UF+W0VLSPQ89+B4Yrw== X-Forefront-PRVS: 01415BB535 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(51914003)(199003)(377424004)(377454003)(189002)(24454002)(65826007)(66066001)(64126003)(4001350100001)(101416001)(50466002)(229853002)(6666003)(5001770100001)(97736004)(92566002)(5660300001)(50986999)(39380400001)(76176999)(54356999)(39450400002)(6486002)(733004)(38730400001)(189998001)(86362001)(23746002)(39400400001)(42186005)(3846002)(6116002)(81156014)(8676002)(305945005)(81166006)(105586002)(31686004)(106356001)(31696002)(230700001)(7846002)(7736002)(65956001)(36756003)(83506001)(39410400001)(2950100002)(2906002)(4326007)(68736007)(47776003)(65806001)(33646002);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB390;H:[142.133.49.242];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AMSPR07MB390;23:3zD7fgSy8JtaHTmPRnefMN2LBsMiYikG0qQzJR?= =?Windows-1252?Q?nQlsEDOVzWQPGYyfF22mqSB5gZAH0liZIy/DzIRWtg4StEWNhUfkKr27?= =?Windows-1252?Q?cHrMjhTOjt+N+PMF9cwAlf2k15efSbJcZ6QMiE3HaBB54HtV7jKKixPT?= =?Windows-1252?Q?+01u8MXEKVyJ8NgRhgTVErhLNAaacujnCErmOF6+C9af4ywKdG6Ez9hY?= =?Windows-1252?Q?8bVSyd09vDbER3QuD9IE+ycSH3VJ+Ekv3ijCZH3qQoryqW783ovKDRg1?= =?Windows-1252?Q?74Yp9SgobglKAtFtdmlgHU5p9w+NvMvQInTWeDe6mqPi7Cu8i5C6TC11?= =?Windows-1252?Q?+28pXJYfciNX73TwOZDss91yL4K0KABh4MCyFqx7u/17Mz+1CpE6rjU8?= =?Windows-1252?Q?Tn5d2FJyXXjqma2a7Nz4Bg4ooSrEgdyEyGzf69VcVMvo2LxiU+jHTFAM?= =?Windows-1252?Q?cnfFHMgoBn3zPqizPBW7y+0eu3koM1Tfba1wkj/nVFmILbBOnR/U7E/3?= =?Windows-1252?Q?vlOY6L9k6mLsndzZTg0Btm9g+asrKzkBYTibJsBuRVwmCe1RSsLZ3iXK?= =?Windows-1252?Q?9HD7dhp6RLH6Ps3995P9oEpWpL8pBFRSO5iiPI8UVWOP1ZK3iZLlyDYI?= =?Windows-1252?Q?kP3mar8S6XpkjeMokDaxhBccUHUFyFEmIPpiH21OOPk58g9UMSZxXl0X?= =?Windows-1252?Q?VZefsOUVx7n3aS5/DiKJZYhuxDtz8cDaxSeYWb22GOt4vnvdj4CLOQ7h?= =?Windows-1252?Q?FrKs/OUpTH2XWWr93O5QJ27HJ7NKz0SfOJz4wMlYvcC7PTZRffFrVg8U?= =?Windows-1252?Q?3q7BWUE5/wVOwJYbKOz7PaJy+KLN2J0AAeNLQ10o63cmTX+qXoySNZqp?= =?Windows-1252?Q?jKrVZSfjNJTrpdV81YVSx7XCvRKV166nfpeSr9GuwTC0bpqmGx3j/qE6?= =?Windows-1252?Q?6ZkG2B87050Ys4VYpPg0r+LgLUkGw5TnTv/NniqjOJoWtEEtUkXNtN7p?= =?Windows-1252?Q?ah2f4eHFcvE4eBhLb3hFKY0YsmEczi77a5h0L4KenTqJev5u0WlJGMl4?= =?Windows-1252?Q?ZiQhv3HdhAsaMtxW+V/97Dg9Gct3Cn97RKYkSpJhWDF2i1TDUB0SYQ/a?= =?Windows-1252?Q?osAUQmYCu1YLd18OY2s0gkTXzGMQ74nwBy4WF3DZPx7A1BrIAeaDLC5D?= =?Windows-1252?Q?qYjm4fOnlzwP4U7GvElnKyr8/5HriosZy0Zqqg/OpYvT8K54cAwFSg1A?= =?Windows-1252?Q?iMHrNo/pH27WuwzxKYRNMEjPNPT2kXiUC3froIwmMQe2Y7FbaWaXAMuP?= =?Windows-1252?Q?8SFCvS1d9zirWoRR9CRRI9kbwizkcTelcUdMFl9gCLL1FPz+dfX6a3wL?= =?Windows-1252?Q?G4JZScx1SVU6CmlDElzY/U+zTFt4CSGj5raWgyHUht8HeN0hZ3bIztD3?= =?Windows-1252?Q?B1LghTGYtW8FXMNoqL2RoHJ6ivauxElwVtSpognSLumIWtmH/pLZVPDj?= =?Windows-1252?Q?vx9a0sce1w1aF5KvQMf37TJTD7z1pep/RS1d18e+n9NIADqg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;6:ZyxVEA4p994TLFTQ5YowxGkj4XnPsW3da8gz3sH9LA9dM6xiE6NA0Lq6gLWeOYdk89exs1UXu5wlpKaOA045BkX7oANgXvL8wWiI2G5XziGHBCLWA3biIk2h0jS8VaQWAyD/86iiycP/S5rwpO5QPblXwdXU+ZjtDf0sIaq55l5f1vr0b0FZrG62RS2Rw9xOD7qSYOwa+WN4aVzpGZImislR6U9r8fjwCLrHolkEdEdFj7EEqkXX3qaTSlfeJ/F41ELQnvU0AXwv9T2ZyssYvX+5aMPR+OPUt8iFBAEIJNWWJna0xSZbh0ejF57nXkBICfmValEUIghwz/MnM5y3P2gRICHmFrksQBqUEYC9Cif+io5SuMG3TYT9KaVDIt31p2nRYSmmNWAy3vheS7mrbJBptAlkSZBeyTzRtkLkQQ49N8NO7MxMchUARWYYfR0pnX8AWmFp9br1zx/nnwcIyg==;5:+JqnZkgnXWjB82NbEdi15Hc+9bZWsuU+Wa2PluvDehGgxP/nT234DW/7x93pMxI5Z3wYATkCi0SANle2bWOkAsHDirz7W2Q7RvFmqAy6jhLzmXfI+a5M2gdANUiyx0TkNywjrk1uxQ33T/UW/BWwWg==;24:K8oRHHbLn7dQXBJAwIlJYS5+jHetWzpdfgTHkugSXvnooo2xUXLMFxORG2SZvRH2tXdaKaNQYmJVcauzmHY0cLiZ9YyaHnxZ1CxgSKHiQUg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;7:o5G2K7uobMn3VhSbc4pSZ9VZLd7mNutE1nRy9BD1yPAXkq4bEuKGuzXk+Oa01x5Kync0FiPPZKQXwK+y8nBs8rlu5DydrvTrw0THRJnIpTaDbG8YoME5IRUC9z9TUMqdcz5iErYOOShZBXBa/dohtLiU50DkIobC4XAtTAGt7RzTUQ0YZZBXJHJUKhOCYFxSDe6NIAdgNCeCpS0hyazHubWDdRLx7hBb4R2gQb/qMydQ3VDz65EpiBgtFy4Lk8r3Ix8Pax4nvEEwjRmSR/fuq+/phtCbPSWSRoa5IAZKsOWsnjG1yN9bACeYAJOtOdJrZOL7ySIPT43ShJhLBISjNrnavdh3+CK7F0cUhVKdAHg6hk3QQtHOBzvAEaneq74aKKOageyDml3++YHvNK34kh0f6ZRbPS/jhvWdBa0TEzkIyzXqwo/8GM5xqRSEyeeemE6UN6krNC1ZuIk576ZxVA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2016 16:42:13.2020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB390 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00961.txt.bz2 On 16-11-29 10:58 AM, Luis Machado wrote: >> +if ![supports_reverse] { > > Add an explicit untested call here? Right, adding: untested "reverse debugging not supported" >> +proc test_record_while_running { } { >> + gdb_test "continue &" "Continuing." >> + gdb_test "record" "Can't enable record while the program is running. Use \"interrupt\" to stop it first." > > I have mixed feelings with the above test names. I'd know what to look > for in case of failure, but more explicit test names wouldn't hurt for a > quick inspection of the logs. > > "move thread" > "switch record on when thread is moving" > > Feel free to pick it up though. Not a hard requirement. You are right, it helps when reading the test. The command by itself doesn't convey why we are using doing that command. How about: proc_with_prefix test_record_while_running { } { gdb_test "continue &" "Continuing." "resume target" gdb_test \ "record" \ "Can't enable record while the program is running. Use \"interrupt\" to stop it first." \ "switch record on while target is running" } PASS: gdb.reverse/record-while-running.exp: test_record_while_running: resume target PASS: gdb.reverse/record-while-running.exp: test_record_while_running: switch record on while target is running I added proc_with_prefix, I think it can help by giving some context to the messages. Thanks for the feedback, Simon