From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125998 invoked by alias); 16 Oct 2019 19:08:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125990 invoked by uid 89); 16 Oct 2019 19:08:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1009, valgrind, HTo:D*be, Philippe X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 19:08:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571252931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HqCHpLjWswrsa2ab2CoKucqF0YohrHdpTSAhp61acu8=; b=P0fULJQfBefKt6Vqha83R9E9LZKfq1nNSB9r+irBs/iPCqj7uxYxP+aqnEbVk4V1hzd4Ob djhfn3jcrWJiHoBnmOsZkLXtBey43Un4ZA+MsL03+vnRPDe7Fi/SkFbmXg7Nij2FNA3jhx EbwltQNQl5M+eOIoszXwSaoFu4cF8as= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-98NR752zPlyBAx9mP9YJ5g-1; Wed, 16 Oct 2019 15:08:50 -0400 Received: by mail-wm1-f71.google.com with SMTP id g67so1351037wmg.4 for ; Wed, 16 Oct 2019 12:08:50 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id t13sm52181068wra.70.2019.10.16.12.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 12:08:48 -0700 (PDT) Subject: Re: [PATCH 00/23] Multi-target support To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20190906232807.6191-1-palves@redhat.com> <2802fb1954a3756ec7e507141652b8d92127424a.camel@skynet.be> <6bed10d6-482f-917d-54f5-34c079ee9547@redhat.com> <6c1828abbbfda76da123926fda8b37816132075a.camel@skynet.be> From: Pedro Alves Message-ID: <8b0e3ad6-30ef-6246-0f61-cf0f0eb6ef1b@redhat.com> Date: Wed, 16 Oct 2019 19:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <6c1828abbbfda76da123926fda8b37816132075a.camel@skynet.be> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-10/txt/msg00509.txt.bz2 On 9/8/19 9:50 PM, Philippe Waroquiers wrote: >>> (gdb) infer 1 >>> [Switching to inferior 1 [Remote target] >>> (/home/philippe/valgrind/git/trunk_untouched/memcheck/tests/trivialleak= )] >>> [Switching to thread 1.1 (Thread 10050)] >>> #0 0x0000000004001090 in _start () from /lib64/ld-linux-x86-64.so.2 >>> (gdb) c >>> Continuing. >>> Connection 2 (remote lvgdb --pid=3D16727) does not support multi-target= resumption. >>> (gdb) >>> >>> So, the continue command is refused both in inferior 1 and inferior 2. I've finally debugged this, it was a simple bug in target.c. We need this: @@ -2181,7 +2181,7 @@ user_visible_resume_ptid (int step) process_stratum_target * user_visible_resume_target (ptid_t resume_ptid) { - return (resume_ptid =3D=3D minus_one_ptid + return (resume_ptid =3D=3D minus_one_ptid && sched_multi ? NULL : current_inferior ()->process_target ()); I'm folding that into the main multi-target patch, which introduces that function. Thanks, Pedro Alves