From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120831 invoked by alias); 10 Jul 2018 04:12:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120820 invoked by uid 89); 10 Jul 2018 04:12:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:605 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 04:12:05 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E97991E08D; Tue, 10 Jul 2018 00:12:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531195924; bh=hOBuCom92MiJfibVj5tXCyZQTrcgHvYq4msnSPfxF44=; h=Subject:From:To:References:Date:In-Reply-To:From; b=Cv+v64xH93uNsR4iL9/1FwGIToe+hpNdjbBgwFJrKnFcG7Ui1r1bfRw0pFdIHDp5q pcpXtXOIalYXjCYg5yrSKhN7wnMp0Dkd2o1V1z/Wcm/1rU+OjqDzNAeZQpVCqcb/CB 2hZ8Vs/TgX/FNCPPn8OeMCy/+SEsHMu0TruZX6mg= Subject: Re: [RFA 34/42] Add many methods to buildsym_compunit From: Simon Marchi To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-35-tom@tromey.com> <26b895ad-c6d9-2ca0-13d0-1b24d24fe4f0@simark.ca> Message-ID: <8ac9c633-f042-402f-7202-75c1fe64990d@simark.ca> Date: Tue, 10 Jul 2018 04:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <26b895ad-c6d9-2ca0-13d0-1b24d24fe4f0@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00254.txt.bz2 On 2018-07-10 12:08 AM, Simon Marchi wrote: > On 2018-05-23 12:58 AM, Tom Tromey wrote: >> +void >> +augment_type_symtab () >> +{ >> + gdb_assert (buildsym_compunit != nullptr); >> + buildsym_compunit->augment_type_symtab (); >> + reset_symtab_globals (); > > reset_symtab_globals () is called both here and in > buildsym_compunit->augment_type_symtab, is it intended? > > Same thing for end_symtab_from_static_block and the corresponding > method. > > Otherwise, LGTM. > > Simon > I just saw that patch 36 removes it anyway, so never mind. Simon