From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17892 invoked by alias); 25 Nov 2009 21:14:08 -0000 Received: (qmail 17872 invoked by uid 22791); 25 Nov 2009 21:14:04 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Nov 2009 21:13:58 +0000 Received: from zps38.corp.google.com (zps38.corp.google.com [172.25.146.38]) by smtp-out.google.com with ESMTP id nAPLDuYx005444 for ; Wed, 25 Nov 2009 13:13:56 -0800 Received: from pxi6 (pxi6.prod.google.com [10.243.27.6]) by zps38.corp.google.com with ESMTP id nAPLDNuw020275 for ; Wed, 25 Nov 2009 13:13:54 -0800 Received: by pxi6 with SMTP id 6so73988pxi.0 for ; Wed, 25 Nov 2009 13:13:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.115.116.37 with SMTP id t37mr2373418wam.79.1259183633842; Wed, 25 Nov 2009 13:13:53 -0800 (PST) In-Reply-To: <20091125204837.GH26004@adacore.com> References: <8ac60eac0911251142r62f0e95al5ebd44503cac645c@mail.gmail.com> <20091125204837.GH26004@adacore.com> Date: Wed, 25 Nov 2009 21:14:00 -0000 Message-ID: <8ac60eac0911251313r774f96a4h4b723062a698617e@mail.gmail.com> Subject: Re: [patch] Replace deprecated_memory_changed_hook with an observer. From: Paul Pluzhnikov To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016e64ea1d633c3ce04793889d7 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00563.txt.bz2 --0016e64ea1d633c3ce04793889d7 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 870 On Wed, Nov 25, 2009 at 12:48 PM, Joel Brobecker wrote: > It looks like you forgot to remove the definition in top.c. Indeed. Fixed patch attached. Thanks, -- Paul Pluzhnikov gdb/ChangeLog: 2009-11-25 Paul Pluzhnikov * ada-lang.c (ada_value_assign): Use observer_notify_memory_changed. * valops.c (value_assign): Likewise. * defs.h (deprecated_memory_changed_hook): Remove. * top.c (deprecated_memory_changed_hook): Likewise. * interps.c (clear_interpreter_hooks): Adjust. gdb/doc/ChangeLog: 2009-11-25 Paul Pluzhnikov * observer.texi: New memory_changed observer. gdb/gdbtk/ChangeLog: 2009-11-25 Paul Pluzhnikov * generic/gdbtk-hooks.c (gdbtk_memory_changed): Adjust. (gdbtk_add_hooks): Adjust. --0016e64ea1d633c3ce04793889d7 Content-Type: text/plain; charset=US-ASCII; name="gdb-memchange-cleanup-20091125-2.txt" Content-Disposition: attachment; filename="gdb-memchange-cleanup-20091125-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g2gldh810 Content-length: 8154 SW5kZXg6IGFkYS1sYW5nLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9hZGEtbGFuZy5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjIzNApkaWZmIC11IC1wIC11IC1yMS4yMzQgYWRhLWxh bmcuYwotLS0gYWRhLWxhbmcuYwkxOSBOb3YgMjAwOSAyMjo0NTo1NiAtMDAw MAkxLjIzNAorKysgYWRhLWxhbmcuYwkyNSBOb3YgMjAwOSAyMToxMDowMyAt MDAwMApAQCAtMjI4OSw5ICsyMjg5LDggQEAgYWRhX3ZhbHVlX2Fzc2lnbiAo c3RydWN0IHZhbHVlICp0b3ZhbCwgcwogICAgICAgICBtb3ZlX2JpdHMgKGJ1 ZmZlciwgdmFsdWVfYml0cG9zICh0b3ZhbCksCiAJCSAgIHZhbHVlX2NvbnRl bnRzIChmcm9tdmFsKSwgMCwgYml0cywgMCk7CiAgICAgICB3cml0ZV9tZW1v cnkgKHRvX2FkZHIsIGJ1ZmZlciwgbGVuKTsKLSAgICAgIGlmIChkZXByZWNh dGVkX21lbW9yeV9jaGFuZ2VkX2hvb2spCi0JZGVwcmVjYXRlZF9tZW1vcnlf Y2hhbmdlZF9ob29rICh0b19hZGRyLCBsZW4pOwotICAgICAgCisgICAgICBv YnNlcnZlcl9ub3RpZnlfbWVtb3J5X2NoYW5nZWQgKHRvX2FkZHIsIGxlbiwg YnVmZmVyKTsKKwogICAgICAgdmFsID0gdmFsdWVfY29weSAodG92YWwpOwog ICAgICAgbWVtY3B5ICh2YWx1ZV9jb250ZW50c19yYXcgKHZhbCksIHZhbHVl X2NvbnRlbnRzIChmcm9tdmFsKSwKICAgICAgICAgICAgICAgVFlQRV9MRU5H VEggKHR5cGUpKTsKSW5kZXg6IGRlZnMuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2RlZnMuaCx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS4yNTcKZGlmZiAtdSAtcCAtdSAtcjEuMjU3IGRl ZnMuaAotLS0gZGVmcy5oCTIxIE9jdCAyMDA5IDE4OjAyOjI1IC0wMDAwCTEu MjU3CisrKyBkZWZzLmgJMjUgTm92IDIwMDkgMjE6MTA6MDMgLTAwMDAKQEAg LTExMDgsNyArMTEwOCw2IEBAIGV4dGVybiB2b2lkICgqZGVwcmVjYXRlZF9y ZWFkbGluZV9iZWdpbl8KIGV4dGVybiBjaGFyICooKmRlcHJlY2F0ZWRfcmVh ZGxpbmVfaG9vaykgKGNoYXIgKik7CiBleHRlcm4gdm9pZCAoKmRlcHJlY2F0 ZWRfcmVhZGxpbmVfZW5kX2hvb2spICh2b2lkKTsKIGV4dGVybiB2b2lkICgq ZGVwcmVjYXRlZF9yZWdpc3Rlcl9jaGFuZ2VkX2hvb2spIChpbnQgcmVnbm8p OwotZXh0ZXJuIHZvaWQgKCpkZXByZWNhdGVkX21lbW9yeV9jaGFuZ2VkX2hv b2spIChDT1JFX0FERFIgYWRkciwgaW50IGxlbik7CiBleHRlcm4gdm9pZCAo KmRlcHJlY2F0ZWRfY29udGV4dF9ob29rKSAoaW50KTsKIGV4dGVybiBwdGlk X3QgKCpkZXByZWNhdGVkX3RhcmdldF93YWl0X2hvb2spIChwdGlkX3QgcHRp ZCwKIAkJCQkJICAgICAgc3RydWN0IHRhcmdldF93YWl0c3RhdHVzICpzdGF0 dXMsCkluZGV4OiBpbnRlcnBzLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9pbnRlcnBzLmMsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMzIKZGlmZiAtdSAtcCAtdSAtcjEuMzIgaW50ZXJw cy5jCi0tLSBpbnRlcnBzLmMJNiBGZWIgMjAwOSAyMTozMzo1OCAtMDAwMAkx LjMyCisrKyBpbnRlcnBzLmMJMjUgTm92IDIwMDkgMjE6MTA6MDMgLTAwMDAK QEAgLTM0Myw3ICszNDMsNiBAQCBjbGVhcl9pbnRlcnByZXRlcl9ob29rcyAo dm9pZCkKICAgZGVwcmVjYXRlZF9yZWFkbGluZV9ob29rID0gMDsKICAgZGVw cmVjYXRlZF9yZWFkbGluZV9lbmRfaG9vayA9IDA7CiAgIGRlcHJlY2F0ZWRf cmVnaXN0ZXJfY2hhbmdlZF9ob29rID0gMDsKLSAgZGVwcmVjYXRlZF9tZW1v cnlfY2hhbmdlZF9ob29rID0gMDsKICAgZGVwcmVjYXRlZF9jb250ZXh0X2hv b2sgPSAwOwogICBkZXByZWNhdGVkX3RhcmdldF93YWl0X2hvb2sgPSAwOwog ICBkZXByZWNhdGVkX2NhbGxfY29tbWFuZF9ob29rID0gMDsKSW5kZXg6IHRv cC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3Jj L3NyYy9nZGIvdG9wLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTczCmRp ZmYgLXUgLXAgLXUgLXIxLjE3MyB0b3AuYwotLS0gdG9wLmMJNSBOb3YgMjAw OSAyMDo0Mzo1MiAtMDAwMAkxLjE3MworKysgdG9wLmMJMjUgTm92IDIwMDkg MjE6MTA6MDMgLTAwMDAKQEAgLTI1OSw5ICsyNTksNiBAQCB2b2lkICgqZGVw cmVjYXRlZF9pbnRlcmFjdGl2ZV9ob29rKSAodm9pCiAgICB0aGF0IHNldmVy YWwgcmVnaXN0ZXJzIGhhdmUgY2hhbmdlZCAoc2VlIHZhbHVlX2Fzc2lnbiku ICovCiB2b2lkICgqZGVwcmVjYXRlZF9yZWdpc3Rlcl9jaGFuZ2VkX2hvb2sp IChpbnQgcmVnbm8pOwogCi0vKiBUZWxsIHRoZSBHVUkgc29tZW9uZSBjaGFu Z2VkIExFTiBieXRlcyBvZiBtZW1vcnkgYXQgQUREUiAqLwotdm9pZCAoKmRl cHJlY2F0ZWRfbWVtb3J5X2NoYW5nZWRfaG9vaykgKENPUkVfQUREUiBhZGRy LCBpbnQgbGVuKTsKLQogLyogQ2FsbGVkIHdoZW4gZ29pbmcgdG8gd2FpdCBm b3IgdGhlIHRhcmdldC4gIFVzdWFsbHkgYWxsb3dzIHRoZSBHVUkgdG8gcnVu CiAgICB3aGlsZSB3YWl0aW5nIGZvciB0YXJnZXQgZXZlbnRzLiAgKi8KIApJ bmRleDogdmFsb3BzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9zcmMvc3JjL2dkYi92YWxvcHMuYyx2CnJldHJpZXZpbmcgcmV2 aXNpb24gMS4yMjcKZGlmZiAtdSAtcCAtdSAtcjEuMjI3IHZhbG9wcy5jCi0t LSB2YWxvcHMuYwkxMCBOb3YgMjAwOSAyMjoxNzo1OCAtMDAwMAkxLjIyNwor KysgdmFsb3BzLmMJMjUgTm92IDIwMDkgMjE6MTA6MDMgLTAwMDAKQEAgLTg2 MSw4ICs4NjEsOCBAQCB2YWx1ZV9hc3NpZ24gKHN0cnVjdCB2YWx1ZSAqdG92 YWwsIHN0cnVjCiAJICB9CiAKIAl3cml0ZV9tZW1vcnkgKGNoYW5nZWRfYWRk ciwgZGVzdF9idWZmZXIsIGNoYW5nZWRfbGVuKTsKLQlpZiAoZGVwcmVjYXRl ZF9tZW1vcnlfY2hhbmdlZF9ob29rKQotCSAgZGVwcmVjYXRlZF9tZW1vcnlf Y2hhbmdlZF9ob29rIChjaGFuZ2VkX2FkZHIsIGNoYW5nZWRfbGVuKTsKKwlv YnNlcnZlcl9ub3RpZnlfbWVtb3J5X2NoYW5nZWQgKGNoYW5nZWRfYWRkciwg Y2hhbmdlZF9sZW4sCisJCQkJCWRlc3RfYnVmZmVyKTsKICAgICAgIH0KICAg ICAgIGJyZWFrOwogCkluZGV4OiBkb2Mvb2JzZXJ2ZXIudGV4aQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2Rv Yy9vYnNlcnZlci50ZXhpLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjI3CmRp ZmYgLXUgLXAgLXUgLXIxLjI3IG9ic2VydmVyLnRleGkKLS0tIGRvYy9vYnNl cnZlci50ZXhpCTE5IE9jdCAyMDA5IDA5OjUxOjQyIC0wMDAwCTEuMjcKKysr IGRvYy9vYnNlcnZlci50ZXhpCTI1IE5vdiAyMDA5IDIxOjEwOjAzIC0wMDAw CkBAIC0yMDgsNiArMjA4LDExIEBAIEVpdGhlciBAdmFsdWV7R0RCTn0gZGV0 YWNoZWQgZnJvbSB0aGUgaW4KIGV4aXRlZC4gIFRoZSBhcmd1bWVudCBAdmFy e3BpZH0gaWRlbnRpZmllcyB0aGUgaW5mZXJpb3IuCiBAZW5kIGRlZnR5cGVm dW4KIAorQGRlZnR5cGVmdW4gdm9pZCBtZW1vcnlfY2hhbmdlZCAoQ09SRV9B RERSIEB2YXJ7YWRkcn0sIGludCBAdmFye2xlbn0sIGNvbnN0IGJmZF9ieXRl ICpAdmFye2RhdGF9KQorQnl0ZXMgZnJvbSBAdmFye2RhdGF9IHRvIEB2YXJ7 ZGF0YX0gKyBAdmFye2xlbn0gaGF2ZSBiZWVuIHdyaXR0ZW4KK3RvIHRoZSBj dXJyZW50IGluZmVyaW9yIGF0IEB2YXJ7YWRkcn0uCitAZW5kIGRlZnR5cGVm dW4KKwogIEBkZWZ0eXBlZnVuIHZvaWQgdGVzdF9ub3RpZmljYXRpb24gKGlu dCBAdmFye3NvbWVhcmd9KQogVGhpcyBvYnNlcnZlciBpcyB1c2VkIGZvciBp bnRlcm5hbCB0ZXN0aW5nLiAgRG8gbm90IHVzZS4gIAogU2VlIHRlc3RzdWl0 ZS9nZGIuZ2RiL29ic2VydmVyLmV4cC4KSW5kZXg6IGdkYnRrL2dlbmVyaWMv Z2RidGstaG9va3MuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3NyYy9zcmMvZ2RiL2dkYnRrL2dlbmVyaWMvZ2RidGstaG9va3Mu Yyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40OQpkaWZmIC11IC1wIC11IC1y MS40OSBnZGJ0ay1ob29rcy5jCi0tLSBnZGJ0ay9nZW5lcmljL2dkYnRrLWhv b2tzLmMJMjQgTWF5IDIwMDkgMDg6Mzg6MjcgLTAwMDAJMS40OQorKysgZ2Ri dGsvZ2VuZXJpYy9nZGJ0ay1ob29rcy5jCTI1IE5vdiAyMDA5IDIxOjEwOjAz IC0wMDAwCkBAIC05NCw3ICs5NCw4IEBAIHN0YXRpYyB2b2lkIGdkYnRrX3By ZV9hZGRfc3ltYm9sIChjb25zdCAKIHN0YXRpYyB2b2lkIGdkYnRrX3ByaW50 X2ZyYW1lX2luZm8gKHN0cnVjdCBzeW10YWIgKiwgaW50LCBpbnQsIGludCk7 CiBzdGF0aWMgdm9pZCBnZGJ0a19wb3N0X2FkZF9zeW1ib2wgKHZvaWQpOwog c3RhdGljIHZvaWQgZ2RidGtfcmVnaXN0ZXJfY2hhbmdlZCAoaW50IHJlZ25v KTsKLXN0YXRpYyB2b2lkIGdkYnRrX21lbW9yeV9jaGFuZ2VkIChDT1JFX0FE RFIgYWRkciwgaW50IGxlbik7CitzdGF0aWMgdm9pZCBnZGJ0a19tZW1vcnlf Y2hhbmdlZCAoQ09SRV9BRERSIGFkZHIsIGludCBsZW4sCisJCQkJICBjb25z dCBiZmRfYnl0ZSAqZGF0YSk7CiBzdGF0aWMgdm9pZCBnZGJ0a19zZWxlY3Rl ZF9mcmFtZV9jaGFuZ2VkIChpbnQpOwogc3RhdGljIHZvaWQgZ2RidGtfY29u dGV4dF9jaGFuZ2UgKGludCk7CiBzdGF0aWMgdm9pZCBnZGJ0a19lcnJvcl9i ZWdpbiAodm9pZCk7CkBAIC0xMjksNiArMTMwLDcgQEAgZ2RidGtfYWRkX2hv b2tzICh2b2lkKQogICBvYnNlcnZlcl9hdHRhY2hfdHJhY2Vwb2ludF9tb2Rp ZmllZCAoZ2RidGtfbW9kaWZ5X3RyYWNlcG9pbnQpOwogICBvYnNlcnZlcl9h dHRhY2hfdHJhY2Vwb2ludF9kZWxldGVkIChnZGJ0a19kZWxldGVfdHJhY2Vw b2ludCk7CiAgIG9ic2VydmVyX2F0dGFjaF9hcmNoaXRlY3R1cmVfY2hhbmdl ZCAoZ2RidGtfYXJjaGl0ZWN0dXJlX2NoYW5nZWQpOworICBvYnNlcnZlcl9h dHRhY2hfbWVtb3J5X2NoYW5nZWQgKGdkYnRrX21lbW9yeV9jaGFuZ2VkKTsK IAogICAvKiBIb29rcyAqLwogICBkZXByZWNhdGVkX2NhbGxfY29tbWFuZF9o b29rID0gZ2RidGtfY2FsbF9jb21tYW5kOwpAQCAtMTU4LDcgKzE2MCw2IEBA IGdkYnRrX2FkZF9ob29rcyAodm9pZCkKICAgZGVwcmVjYXRlZF9kZXRhY2hf aG9vayAgICAgICAgICAgID0gZ2RidGtfZGV0YWNoOwogCiAgIGRlcHJlY2F0 ZWRfcmVnaXN0ZXJfY2hhbmdlZF9ob29rID0gZ2RidGtfcmVnaXN0ZXJfY2hh bmdlZDsKLSAgZGVwcmVjYXRlZF9tZW1vcnlfY2hhbmdlZF9ob29rID0gZ2Ri dGtfbWVtb3J5X2NoYW5nZWQ7CiAgIGRlcHJlY2F0ZWRfc2VsZWN0ZWRfZnJh bWVfbGV2ZWxfY2hhbmdlZF9ob29rID0gZ2RidGtfc2VsZWN0ZWRfZnJhbWVf Y2hhbmdlZDsKICAgZGVwcmVjYXRlZF9jb250ZXh0X2hvb2sgPSBnZGJ0a19j b250ZXh0X2NoYW5nZTsKIApAQCAtMzkzLDcgKzM5NCw3IEBAIGdkYnRrX3Jl Z2lzdGVyX2NoYW5nZWQgKGludCByZWdubykKIH0KIAogc3RhdGljIHZvaWQK LWdkYnRrX21lbW9yeV9jaGFuZ2VkIChDT1JFX0FERFIgYWRkciwgaW50IGxl bikKK2dkYnRrX21lbW9yeV9jaGFuZ2VkIChDT1JFX0FERFIgYWRkciwgaW50 IGxlbiwgY29uc3QgYmZkX2J5dGUgKmRhdGEpCiB7CiAgIGlmIChUY2xfRXZh bCAoZ2RidGtfaW50ZXJwLCAiZ2RidGtfbWVtb3J5X2NoYW5nZWQiKSAhPSBU Q0xfT0spCiAgICAgcmVwb3J0X2Vycm9yICgpOwo= --0016e64ea1d633c3ce04793889d7--