From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26730 invoked by alias); 25 Nov 2009 19:42:24 -0000 Received: (qmail 26711 invoked by uid 22791); 25 Nov 2009 19:42:22 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Nov 2009 19:42:16 +0000 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out.google.com with ESMTP id nAPJgDnE006597 for ; Wed, 25 Nov 2009 11:42:14 -0800 Received: from pwj15 (pwj15.prod.google.com [10.241.219.79]) by wpaz1.hot.corp.google.com with ESMTP id nAPJgAg9018336 for ; Wed, 25 Nov 2009 11:42:10 -0800 Received: by pwj15 with SMTP id 15so27572pwj.23 for ; Wed, 25 Nov 2009 11:42:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.30.7 with SMTP id d7mr3226309wad.30.1259178130389; Wed, 25 Nov 2009 11:42:10 -0800 (PST) Date: Wed, 25 Nov 2009 19:42:00 -0000 Message-ID: <8ac60eac0911251142r62f0e95al5ebd44503cac645c@mail.gmail.com> Subject: [patch] Replace deprecated_memory_changed_hook with an observer. From: Paul Pluzhnikov To: Joel Brobecker Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=00504502a1bc2bb9e10479374154 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00557.txt.bz2 --00504502a1bc2bb9e10479374154 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 970 On Wed, Nov 25, 2009 at 10:06 AM, Joel Brobecker wrote: >> Should I create a new memory_changed observer and remove >> deprecated_memory_changed_hook instead? > > After reviewing the history of that hook, I think it would be a desired > cleanup to have a memory_changed observer. Cleanup patch attached. Tested on Linux/x86_64 with no regressions. Thanks, -- Paul Pluzhnikov gdb/ChangeLog: 2009-11-25 Paul Pluzhnikov * ada-lang.c (ada_value_assign): Use observer_notify_memory_changed. * valops.c (value_assign): Likewise. * defs.h (deprecated_memory_changed_hook): Remove. * interps.c (clear_interpreter_hooks): Adjust. gdb/doc/ChangeLog: 2009-11-25 Paul Pluzhnikov * observer.texi: New memory_changed observer. gdb/gdbtk/ChangeLog: 2009-11-25 Paul Pluzhnikov * generic/gdbtk-hooks.c (gdbtk_memory_changed): Adjust. (gdbtk_add_hooks): Adjust. --00504502a1bc2bb9e10479374154 Content-Type: text/plain; charset=US-ASCII; name="gdb-memchange-cleanup-20091125.txt" Content-Disposition: attachment; filename="gdb-memchange-cleanup-20091125.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g2ghsx810 Content-length: 7227 SW5kZXg6IGFkYS1sYW5nLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9hZGEtbGFuZy5jLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjIzNApkaWZmIC11IC1wIC11IC1yMS4yMzQgYWRhLWxh bmcuYwotLS0gYWRhLWxhbmcuYwkxOSBOb3YgMjAwOSAyMjo0NTo1NiAtMDAw MAkxLjIzNAorKysgYWRhLWxhbmcuYwkyNSBOb3YgMjAwOSAxOToyMTo1NCAt MDAwMApAQCAtMjI4OSw5ICsyMjg5LDggQEAgYWRhX3ZhbHVlX2Fzc2lnbiAo c3RydWN0IHZhbHVlICp0b3ZhbCwgcwogICAgICAgICBtb3ZlX2JpdHMgKGJ1 ZmZlciwgdmFsdWVfYml0cG9zICh0b3ZhbCksCiAJCSAgIHZhbHVlX2NvbnRl bnRzIChmcm9tdmFsKSwgMCwgYml0cywgMCk7CiAgICAgICB3cml0ZV9tZW1v cnkgKHRvX2FkZHIsIGJ1ZmZlciwgbGVuKTsKLSAgICAgIGlmIChkZXByZWNh dGVkX21lbW9yeV9jaGFuZ2VkX2hvb2spCi0JZGVwcmVjYXRlZF9tZW1vcnlf Y2hhbmdlZF9ob29rICh0b19hZGRyLCBsZW4pOwotICAgICAgCisgICAgICBv YnNlcnZlcl9ub3RpZnlfbWVtb3J5X2NoYW5nZWQgKHRvX2FkZHIsIGxlbiwg YnVmZmVyKTsKKwogICAgICAgdmFsID0gdmFsdWVfY29weSAodG92YWwpOwog ICAgICAgbWVtY3B5ICh2YWx1ZV9jb250ZW50c19yYXcgKHZhbCksIHZhbHVl X2NvbnRlbnRzIChmcm9tdmFsKSwKICAgICAgICAgICAgICAgVFlQRV9MRU5H VEggKHR5cGUpKTsKSW5kZXg6IGRlZnMuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2RlZnMuaCx2CnJldHJp ZXZpbmcgcmV2aXNpb24gMS4yNTcKZGlmZiAtdSAtcCAtdSAtcjEuMjU3IGRl ZnMuaAotLS0gZGVmcy5oCTIxIE9jdCAyMDA5IDE4OjAyOjI1IC0wMDAwCTEu MjU3CisrKyBkZWZzLmgJMjUgTm92IDIwMDkgMTk6MjE6NTQgLTAwMDAKQEAg LTExMDgsNyArMTEwOCw2IEBAIGV4dGVybiB2b2lkICgqZGVwcmVjYXRlZF9y ZWFkbGluZV9iZWdpbl8KIGV4dGVybiBjaGFyICooKmRlcHJlY2F0ZWRfcmVh ZGxpbmVfaG9vaykgKGNoYXIgKik7CiBleHRlcm4gdm9pZCAoKmRlcHJlY2F0 ZWRfcmVhZGxpbmVfZW5kX2hvb2spICh2b2lkKTsKIGV4dGVybiB2b2lkICgq ZGVwcmVjYXRlZF9yZWdpc3Rlcl9jaGFuZ2VkX2hvb2spIChpbnQgcmVnbm8p OwotZXh0ZXJuIHZvaWQgKCpkZXByZWNhdGVkX21lbW9yeV9jaGFuZ2VkX2hv b2spIChDT1JFX0FERFIgYWRkciwgaW50IGxlbik7CiBleHRlcm4gdm9pZCAo KmRlcHJlY2F0ZWRfY29udGV4dF9ob29rKSAoaW50KTsKIGV4dGVybiBwdGlk X3QgKCpkZXByZWNhdGVkX3RhcmdldF93YWl0X2hvb2spIChwdGlkX3QgcHRp ZCwKIAkJCQkJICAgICAgc3RydWN0IHRhcmdldF93YWl0c3RhdHVzICpzdGF0 dXMsCkluZGV4OiBpbnRlcnBzLmMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9pbnRlcnBzLmMsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMzIKZGlmZiAtdSAtcCAtdSAtcjEuMzIgaW50ZXJw cy5jCi0tLSBpbnRlcnBzLmMJNiBGZWIgMjAwOSAyMTozMzo1OCAtMDAwMAkx LjMyCisrKyBpbnRlcnBzLmMJMjUgTm92IDIwMDkgMTk6MjE6NTQgLTAwMDAK QEAgLTM0Myw3ICszNDMsNiBAQCBjbGVhcl9pbnRlcnByZXRlcl9ob29rcyAo dm9pZCkKICAgZGVwcmVjYXRlZF9yZWFkbGluZV9ob29rID0gMDsKICAgZGVw cmVjYXRlZF9yZWFkbGluZV9lbmRfaG9vayA9IDA7CiAgIGRlcHJlY2F0ZWRf cmVnaXN0ZXJfY2hhbmdlZF9ob29rID0gMDsKLSAgZGVwcmVjYXRlZF9tZW1v cnlfY2hhbmdlZF9ob29rID0gMDsKICAgZGVwcmVjYXRlZF9jb250ZXh0X2hv b2sgPSAwOwogICBkZXByZWNhdGVkX3RhcmdldF93YWl0X2hvb2sgPSAwOwog ICBkZXByZWNhdGVkX2NhbGxfY29tbWFuZF9ob29rID0gMDsKSW5kZXg6IHZh bG9wcy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv c3JjL3NyYy9nZGIvdmFsb3BzLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu MjI3CmRpZmYgLXUgLXAgLXUgLXIxLjIyNyB2YWxvcHMuYwotLS0gdmFsb3Bz LmMJMTAgTm92IDIwMDkgMjI6MTc6NTggLTAwMDAJMS4yMjcKKysrIHZhbG9w cy5jCTI1IE5vdiAyMDA5IDE5OjIxOjU0IC0wMDAwCkBAIC04NjEsOCArODYx LDggQEAgdmFsdWVfYXNzaWduIChzdHJ1Y3QgdmFsdWUgKnRvdmFsLCBzdHJ1 YwogCSAgfQogCiAJd3JpdGVfbWVtb3J5IChjaGFuZ2VkX2FkZHIsIGRlc3Rf YnVmZmVyLCBjaGFuZ2VkX2xlbik7Ci0JaWYgKGRlcHJlY2F0ZWRfbWVtb3J5 X2NoYW5nZWRfaG9vaykKLQkgIGRlcHJlY2F0ZWRfbWVtb3J5X2NoYW5nZWRf aG9vayAoY2hhbmdlZF9hZGRyLCBjaGFuZ2VkX2xlbik7CisJb2JzZXJ2ZXJf bm90aWZ5X21lbW9yeV9jaGFuZ2VkIChjaGFuZ2VkX2FkZHIsIGNoYW5nZWRf bGVuLAorCQkJCQlkZXN0X2J1ZmZlcik7CiAgICAgICB9CiAgICAgICBicmVh azsKIApJbmRleDogZG9jL29ic2VydmVyLnRleGkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9kb2Mvb2JzZXJ2 ZXIudGV4aSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yNwpkaWZmIC11IC1w IC11IC1yMS4yNyBvYnNlcnZlci50ZXhpCi0tLSBkb2Mvb2JzZXJ2ZXIudGV4 aQkxOSBPY3QgMjAwOSAwOTo1MTo0MiAtMDAwMAkxLjI3CisrKyBkb2Mvb2Jz ZXJ2ZXIudGV4aQkyNSBOb3YgMjAwOSAxOToyMTo1NCAtMDAwMApAQCAtMjA4 LDYgKzIwOCwxMSBAQCBFaXRoZXIgQHZhbHVle0dEQk59IGRldGFjaGVkIGZy b20gdGhlIGluCiBleGl0ZWQuICBUaGUgYXJndW1lbnQgQHZhcntwaWR9IGlk ZW50aWZpZXMgdGhlIGluZmVyaW9yLgogQGVuZCBkZWZ0eXBlZnVuCiAKK0Bk ZWZ0eXBlZnVuIHZvaWQgbWVtb3J5X2NoYW5nZWQgKENPUkVfQUREUiBAdmFy e2FkZHJ9LCBpbnQgQHZhcntsZW59LCBjb25zdCBiZmRfYnl0ZSAqQHZhcntk YXRhfSkKK0J5dGVzIGZyb20gQHZhcntkYXRhfSB0byBAdmFye2RhdGF9ICsg QHZhcntsZW59IGhhdmUgYmVlbiB3cml0dGVuCit0byB0aGUgY3VycmVudCBp bmZlcmlvciBhdCBAdmFye2FkZHJ9LgorQGVuZCBkZWZ0eXBlZnVuCisKICBA ZGVmdHlwZWZ1biB2b2lkIHRlc3Rfbm90aWZpY2F0aW9uIChpbnQgQHZhcntz b21lYXJnfSkKIFRoaXMgb2JzZXJ2ZXIgaXMgdXNlZCBmb3IgaW50ZXJuYWwg dGVzdGluZy4gIERvIG5vdCB1c2UuICAKIFNlZSB0ZXN0c3VpdGUvZ2RiLmdk Yi9vYnNlcnZlci5leHAuCkluZGV4OiBnZGJ0ay9nZW5lcmljL2dkYnRrLWhv b2tzLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9z cmMvc3JjL2dkYi9nZGJ0ay9nZW5lcmljL2dkYnRrLWhvb2tzLmMsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNDkKZGlmZiAtdSAtcCAtdSAtcjEuNDkgZ2Ri dGstaG9va3MuYwotLS0gZ2RidGsvZ2VuZXJpYy9nZGJ0ay1ob29rcy5jCTI0 IE1heSAyMDA5IDA4OjM4OjI3IC0wMDAwCTEuNDkKKysrIGdkYnRrL2dlbmVy aWMvZ2RidGstaG9va3MuYwkyNSBOb3YgMjAwOSAxOToyMTo1NCAtMDAwMApA QCAtOTQsNyArOTQsOCBAQCBzdGF0aWMgdm9pZCBnZGJ0a19wcmVfYWRkX3N5 bWJvbCAoY29uc3QgCiBzdGF0aWMgdm9pZCBnZGJ0a19wcmludF9mcmFtZV9p bmZvIChzdHJ1Y3Qgc3ltdGFiICosIGludCwgaW50LCBpbnQpOwogc3RhdGlj IHZvaWQgZ2RidGtfcG9zdF9hZGRfc3ltYm9sICh2b2lkKTsKIHN0YXRpYyB2 b2lkIGdkYnRrX3JlZ2lzdGVyX2NoYW5nZWQgKGludCByZWdubyk7Ci1zdGF0 aWMgdm9pZCBnZGJ0a19tZW1vcnlfY2hhbmdlZCAoQ09SRV9BRERSIGFkZHIs IGludCBsZW4pOworc3RhdGljIHZvaWQgZ2RidGtfbWVtb3J5X2NoYW5nZWQg KENPUkVfQUREUiBhZGRyLCBpbnQgbGVuLAorCQkJCSAgY29uc3QgYmZkX2J5 dGUgKmRhdGEpOwogc3RhdGljIHZvaWQgZ2RidGtfc2VsZWN0ZWRfZnJhbWVf Y2hhbmdlZCAoaW50KTsKIHN0YXRpYyB2b2lkIGdkYnRrX2NvbnRleHRfY2hh bmdlIChpbnQpOwogc3RhdGljIHZvaWQgZ2RidGtfZXJyb3JfYmVnaW4gKHZv aWQpOwpAQCAtMTI5LDYgKzEzMCw3IEBAIGdkYnRrX2FkZF9ob29rcyAodm9p ZCkKICAgb2JzZXJ2ZXJfYXR0YWNoX3RyYWNlcG9pbnRfbW9kaWZpZWQgKGdk YnRrX21vZGlmeV90cmFjZXBvaW50KTsKICAgb2JzZXJ2ZXJfYXR0YWNoX3Ry YWNlcG9pbnRfZGVsZXRlZCAoZ2RidGtfZGVsZXRlX3RyYWNlcG9pbnQpOwog ICBvYnNlcnZlcl9hdHRhY2hfYXJjaGl0ZWN0dXJlX2NoYW5nZWQgKGdkYnRr X2FyY2hpdGVjdHVyZV9jaGFuZ2VkKTsKKyAgb2JzZXJ2ZXJfYXR0YWNoX21l bW9yeV9jaGFuZ2VkIChnZGJ0a19tZW1vcnlfY2hhbmdlZCk7CiAKICAgLyog SG9va3MgKi8KICAgZGVwcmVjYXRlZF9jYWxsX2NvbW1hbmRfaG9vayA9IGdk YnRrX2NhbGxfY29tbWFuZDsKQEAgLTE1OCw3ICsxNjAsNiBAQCBnZGJ0a19h ZGRfaG9va3MgKHZvaWQpCiAgIGRlcHJlY2F0ZWRfZGV0YWNoX2hvb2sgICAg ICAgICAgICA9IGdkYnRrX2RldGFjaDsKIAogICBkZXByZWNhdGVkX3JlZ2lz dGVyX2NoYW5nZWRfaG9vayA9IGdkYnRrX3JlZ2lzdGVyX2NoYW5nZWQ7Ci0g IGRlcHJlY2F0ZWRfbWVtb3J5X2NoYW5nZWRfaG9vayA9IGdkYnRrX21lbW9y eV9jaGFuZ2VkOwogICBkZXByZWNhdGVkX3NlbGVjdGVkX2ZyYW1lX2xldmVs X2NoYW5nZWRfaG9vayA9IGdkYnRrX3NlbGVjdGVkX2ZyYW1lX2NoYW5nZWQ7 CiAgIGRlcHJlY2F0ZWRfY29udGV4dF9ob29rID0gZ2RidGtfY29udGV4dF9j aGFuZ2U7CiAKQEAgLTM5Myw3ICszOTQsNyBAQCBnZGJ0a19yZWdpc3Rlcl9j aGFuZ2VkIChpbnQgcmVnbm8pCiB9CiAKIHN0YXRpYyB2b2lkCi1nZGJ0a19t ZW1vcnlfY2hhbmdlZCAoQ09SRV9BRERSIGFkZHIsIGludCBsZW4pCitnZGJ0 a19tZW1vcnlfY2hhbmdlZCAoQ09SRV9BRERSIGFkZHIsIGludCBsZW4sIGNv bnN0IGJmZF9ieXRlICpkYXRhKQogewogICBpZiAoVGNsX0V2YWwgKGdkYnRr X2ludGVycCwgImdkYnRrX21lbW9yeV9jaGFuZ2VkIikgIT0gVENMX09LKQog ICAgIHJlcG9ydF9lcnJvciAoKTsK --00504502a1bc2bb9e10479374154--