From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20014 invoked by alias); 21 Nov 2009 00:44:14 -0000 Received: (qmail 20006 invoked by uid 22791); 21 Nov 2009 00:44:13 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 Nov 2009 00:43:00 +0000 Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) by smtp-out.google.com with ESMTP id nAL0gtNJ016915 for ; Sat, 21 Nov 2009 00:42:55 GMT Received: from pzk13 (pzk13.prod.google.com [10.243.19.141]) by zps77.corp.google.com with ESMTP id nAL0gquq003090 for ; Fri, 20 Nov 2009 16:42:52 -0800 Received: by pzk13 with SMTP id 13so2572670pzk.25 for ; Fri, 20 Nov 2009 16:42:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.253.24 with SMTP id a24mr2557094wai.201.1258764172320; Fri, 20 Nov 2009 16:42:52 -0800 (PST) In-Reply-To: References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com> <8ac60eac0911161028of5f2352lf1857db7a46a94b2@mail.gmail.com> <8ac60eac0911191539w4245739ka6405ba072b79395@mail.gmail.com> Date: Sat, 21 Nov 2009 00:44:00 -0000 Message-ID: <8ac60eac0911201642y138489ffvab73550bfa72a89d@mail.gmail.com> Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'" From: Paul Pluzhnikov To: Tom Tromey Cc: Andreas Schwab , gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016e687869c58df3c0478d6dff5 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00455.txt.bz2 --0016e687869c58df3c0478d6dff5 Content-Type: text/plain; charset=ISO-8859-1 Content-length: 746 On Fri, Nov 20, 2009 at 9:27 AM, Tom Tromey wrote: > Paul> If it's acceptable to require comma for two-argument command > It is fine by me. Here is the patch with documentation and test fixes. Does this require a NEWS entry (incompatible change to disassemble command) ? Thanks, -- Paul Pluzhnikov gdb/ChangeLog: 2009-11-20 Paul Pluzhnikov * cli/cli-cmds.c (disassemble_command): Split on comma. (init_cli_cmds): Update help. gdb/doc/ChangeLog: 2009-11-20 Paul Pluzhnikov * gdb.texinfo (Machine Code): Adjust. gdb/testsuite/ChangeLog: 2009-11-20 Paul Pluzhnikov * gdb.asm/asm-source.exp: Adjust. * gdb.base/help.exp: Adjust. --0016e687869c58df3c0478d6dff5 Content-Type: text/plain; charset=US-ASCII; name="gdb-disas-20091120.txt" Content-Disposition: attachment; filename="gdb-disas-20091120.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g29nmzja0 Content-length: 8837 SW5kZXg6IGNsaS9jbGktY21kcy5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvY2xpL2NsaS1jbWRzLmMsdgpy ZXRyaWV2aW5nIHJldmlzaW9uIDEuOTMKZGlmZiAtdSAtcCAtdSAtcjEuOTMg Y2xpLWNtZHMuYwotLS0gY2xpL2NsaS1jbWRzLmMJMjMgT2N0IDIwMDkgMDA6 NDk6MzMgLTAwMDAJMS45MworKysgY2xpL2NsaS1jbWRzLmMJMjEgTm92IDIw MDkgMDA6MzM6MjUgLTAwMDAKQEAgLTk4Myw3ICs5ODMsNiBAQCBkaXNhc3Nl bWJsZV9jb21tYW5kIChjaGFyICphcmcsIGludCBmcm9tCiAgIENPUkVfQURE UiBsb3csIGhpZ2g7CiAgIGNoYXIgKm5hbWU7CiAgIENPUkVfQUREUiBwYywg cGNfbWFza2VkOwotICBjaGFyICpzcGFjZV9pbmRleDsKICAgaW50IGZsYWdz OwogCiAgIG5hbWUgPSBOVUxMOwpAQCAtMTAyMiwxMyArMTAyMSwxMiBAQCBk aXNhc3NlbWJsZV9jb21tYW5kIChjaGFyICphcmcsIGludCBmcm9tCiAgICAg ICByZXR1cm47CiAgICAgfQogCi0gIC8qIEZJWE1FOiAndHdvdWxkIGJlIG5p Y2UgdG8gYWxsb3cgc3BhY2VzIGluIHRoZSBleHByZXNzaW9uIGZvciB0aGUg Zmlyc3QKLSAgICAgYXJnLiAgQWxsb3cgY29tbWEgc2VwYXJhdGVyIHRvbz8g ICovCi0KLSAgaWYgKCEoc3BhY2VfaW5kZXggPSAoY2hhciAqKSBzdHJjaHIg KGFyZywgJyAnKSkpCisgIHBjID0gdmFsdWVfYXNfYWRkcmVzcyAocGFyc2Vf dG9fY29tbWFfYW5kX2V2YWwgKCZhcmcpKTsKKyAgaWYgKGFyZ1swXSA9PSAn LCcpCisgICAgKythcmc7CisgIGlmIChhcmdbMF0gPT0gJ1wwJykKICAgICB7 CiAgICAgICAvKiBPbmUgYXJndW1lbnQuICAqLwotICAgICAgcGMgPSBwYXJz ZV9hbmRfZXZhbF9hZGRyZXNzIChhcmcpOwogICAgICAgaWYgKGZpbmRfcGNf cGFydGlhbF9mdW5jdGlvbiAocGMsICZuYW1lLCAmbG93LCAmaGlnaCkgPT0g MCkKIAllcnJvciAoXygiTm8gZnVuY3Rpb24gY29udGFpbnMgc3BlY2lmaWVk IGFkZHJlc3MuIikpOwogI2lmIGRlZmluZWQoVFVJKQpAQCAtMTA0NCw5ICsx MDQyLDggQEAgZGlzYXNzZW1ibGVfY29tbWFuZCAoY2hhciAqYXJnLCBpbnQg ZnJvbQogICBlbHNlCiAgICAgewogICAgICAgLyogVHdvIGFyZ3VtZW50cy4g ICovCi0gICAgICAqc3BhY2VfaW5kZXggPSAnXDAnOwotICAgICAgbG93ID0g cGFyc2VfYW5kX2V2YWxfYWRkcmVzcyAoYXJnKTsKLSAgICAgIGhpZ2ggPSBw YXJzZV9hbmRfZXZhbF9hZGRyZXNzIChzcGFjZV9pbmRleCArIDEpOworICAg ICAgbG93ID0gcGM7CisgICAgICBoaWdoID0gcGFyc2VfYW5kX2V2YWxfYWRk cmVzcyAoYXJnKTsKICAgICB9CiAKICAgcHJpbnRfZGlzYXNzZW1ibHkgKGdk YmFyY2gsIG5hbWUsIGxvdywgaGlnaCwgZmxhZ3MpOwpAQCAtMTQ2MSw3ICsx NDU4LDcgQEAgRGVmYXVsdCBpcyB0aGUgZnVuY3Rpb24gc3Vycm91bmRpbmcg dGhlIAogV2l0aCBhIC9tIG1vZGlmaWVyLCBzb3VyY2UgbGluZXMgYXJlIGlu Y2x1ZGVkIChpZiBhdmFpbGFibGUpLlxuXAogV2l0aCBhIC9yIG1vZGlmaWVy LCByYXcgaW5zdHJ1Y3Rpb25zIGluIGhleCBhcmUgaW5jbHVkZWQuXG5cCiBX aXRoIGEgc2luZ2xlIGFyZ3VtZW50LCB0aGUgZnVuY3Rpb24gc3Vycm91bmRp bmcgdGhhdCBhZGRyZXNzIGlzIGR1bXBlZC5cblwKLVR3byBhcmd1bWVudHMg YXJlIHRha2VuIGFzIGEgcmFuZ2Ugb2YgbWVtb3J5IHRvIGR1bXAuIikpOwor VHdvIGFyZ3VtZW50cyAoc2VwYXJhdGVkIGJ5IGNvbW1hKSBhcmUgdGFrZW4g YXMgYSByYW5nZSBvZiBtZW1vcnkgdG8gZHVtcC4iKSk7CiAgIHNldF9jbWRf Y29tcGxldGVyIChjLCBsb2NhdGlvbl9jb21wbGV0ZXIpOwogICBpZiAoeGRi X2NvbW1hbmRzKQogICAgIGFkZF9jb21fYWxpYXMgKCJ2YSIsICJkaXNhc3Nl bWJsZSIsIGNsYXNzX3hkYiwgMCk7CkluZGV4OiBkb2MvZ2RiLnRleGluZm8K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3Jj L2dkYi9kb2MvZ2RiLnRleGluZm8sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu NjQxCmRpZmYgLXUgLXAgLXUgLXIxLjY0MSBnZGIudGV4aW5mbwotLS0gZG9j L2dkYi50ZXhpbmZvCTIgTm92IDIwMDkgMTQ6NTk6NTIgLTAwMDAJMS42NDEK KysrIGRvYy9nZGIudGV4aW5mbwkyMSBOb3YgMjAwOSAwMDozMzoyNSAtMDAw MApAQCAtNjUzOSwxMCArNjUzOSwxMCBAQCBpbiBzeW1ib2xpYyBmb3JtIGJ5 IHNwZWNpZnlpbmcgdGhlIEBjb2RlCiBUaGUgZGVmYXVsdCBtZW1vcnkgcmFu Z2UgaXMgdGhlIGZ1bmN0aW9uIHN1cnJvdW5kaW5nIHRoZQogcHJvZ3JhbSBj b3VudGVyIG9mIHRoZSBzZWxlY3RlZCBmcmFtZS4gIEEgc2luZ2xlIGFyZ3Vt ZW50IHRvIHRoaXMKIGNvbW1hbmQgaXMgYSBwcm9ncmFtIGNvdW50ZXIgdmFs dWU7IEB2YWx1ZXtHREJOfSBkdW1wcyB0aGUgZnVuY3Rpb24KLXN1cnJvdW5k aW5nIHRoaXMgdmFsdWUuICBUd28gYXJndW1lbnRzIHNwZWNpZnkgYSByYW5n ZSBvZiBhZGRyZXNzZXMKLShmaXJzdCBpbmNsdXNpdmUsIHNlY29uZCBleGNs dXNpdmUpIHRvIGR1bXAuICBJbiB0aGF0IGNhc2UsIHRoZSBuYW1lIG9mCi10 aGUgZnVuY3Rpb24gaXMgYWxzbyBwcmludGVkIChzaW5jZSB0aGVyZSBjb3Vs ZCBiZSBzZXZlcmFsIGZ1bmN0aW9ucyBpbgotdGhlIGdpdmVuIHJhbmdlKS4K K3N1cnJvdW5kaW5nIHRoaXMgdmFsdWUuICBUd28gYXJndW1lbnRzIChzZXBh cmF0ZWQgYnkgY29tbWEpIHNwZWNpZnkgYQorcmFuZ2Ugb2YgYWRkcmVzc2Vz IChmaXJzdCBpbmNsdXNpdmUsIHNlY29uZCBleGNsdXNpdmUpIHRvIGR1bXAu ICBJbiB0aGF0CitjYXNlLCB0aGUgbmFtZSBvZiB0aGUgZnVuY3Rpb24gaXMg YWxzbyBwcmludGVkIChzaW5jZSB0aGVyZSBjb3VsZCBiZQorc2V2ZXJhbCBm dW5jdGlvbnMgaW4gdGhlIGdpdmVuIHJhbmdlKS4KIAogSWYgdGhlIHJhbmdl IG9mIG1lbW9yeSBiZWluZyBkaXNhc3NlbWJsZWQgY29udGFpbnMgY3VycmVu dCBwcm9ncmFtIGNvdW50ZXIsCiB0aGUgaW5zdHJ1Y3Rpb24gYXQgdGhhdCBs b2NhdGlvbiBpcyBzaG93biB3aXRoIGEgQGNvZGV7PT59IG1hcmtlci4KSW5k ZXg6IHRlc3RzdWl0ZS9nZGIuYXNtL2FzbS1zb3VyY2UuZXhwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvdGVz dHN1aXRlL2dkYi5hc20vYXNtLXNvdXJjZS5leHAsdgpyZXRyaWV2aW5nIHJl dmlzaW9uIDEuNzUKZGlmZiAtdSAtcCAtdSAtcjEuNzUgYXNtLXNvdXJjZS5l eHAKLS0tIHRlc3RzdWl0ZS9nZGIuYXNtL2FzbS1zb3VyY2UuZXhwCTIzIE9j dCAyMDA5IDAwOjQ5OjMzIC0wMDAwCTEuNzUKKysrIHRlc3RzdWl0ZS9nZGIu YXNtL2FzbS1zb3VyY2UuZXhwCTIxIE5vdiAyMDA5IDAwOjMzOjI1IC0wMDAw CkBAIC00NTMsMTIgKzQ1MywxMiBAQCBwcm9jIHRlc3RfZGlzIHsgY29tbWFu ZCB2YXIgfSB7CiAjIFNlZSBpZiB3ZSBjYW4gbG9vayBhdCBhIGdsb2JhbCB2 YXJpYWJsZSwgdGhyZWUgd2F5cwogZ2RiX3Rlc3QgInByaW50IGdsb2JhbHZh ciIgIi4qID0gMTEiICJsb29rIGF0IGdsb2JhbCB2YXJpYWJsZSIKIHRlc3Rf ZGlzICJ4L2kgJmdsb2JhbHZhciIgImdsb2JhbHZhciIKLXRlc3RfZGlzICJk aXNhc3NlbSAmZ2xvYmFsdmFyICZnbG9iYWx2YXIrMSIgImdsb2JhbHZhciIK K3Rlc3RfZGlzICJkaXNhc3NlbSAmZ2xvYmFsdmFyLCAmZ2xvYmFsdmFyKzEi ICJnbG9iYWx2YXIiCiAKICMgU2VlIGlmIHdlIGNhbiBsb29rIGF0IGEgc3Rh dGljIHZhcmlhYmxlLCB0aHJlZSB3YXlzCiBnZGJfdGVzdCAicHJpbnQgc3Rh dGljdmFyIiAiLiogPSA1IiAibG9vayBhdCBzdGF0aWMgdmFyaWFibGUiCiB0 ZXN0X2RpcyAieC9pICZzdGF0aWN2YXIiICJzdGF0aWN2YXIiCi10ZXN0X2Rp cyAiZGlzYXNzZW0gJnN0YXRpY3ZhciAmc3RhdGljdmFyKzEiICJzdGF0aWN2 YXIiCit0ZXN0X2RpcyAiZGlzYXNzZW0gJnN0YXRpY3ZhciwgJnN0YXRpY3Zh cisxIiAic3RhdGljdmFyIgogCiAjIFNlZSBpZiB3ZSBjYW4gbG9vayBhdCBh IHN0YXRpYyBmdW5jdGlvbgogZ2RiX3Rlc3QgImRpc2Fzc2VtIGZvb3N0YXRp YyIgIi4qPFxcKzA+Oi4qRW5kIG9mIGFzc2VtYmxlciBkdW1wLiIgXApJbmRl eDogdGVzdHN1aXRlL2dkYi5iYXNlL2hlbHAuZXhwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvdGVzdHN1aXRl L2dkYi5iYXNlL2hlbHAuZXhwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjM1 CmRpZmYgLXUgLXAgLXUgLXIxLjM1IGhlbHAuZXhwCi0tLSB0ZXN0c3VpdGUv Z2RiLmJhc2UvaGVscC5leHAJMTMgQXVnIDIwMDkgMTQ6NTg6MjcgLTAwMDAJ MS4zNQorKysgdGVzdHN1aXRlL2dkYi5iYXNlL2hlbHAuZXhwCTIxIE5vdiAy MDA5IDAwOjMzOjI1IC0wMDAwCkBAIC0xMjQsNyArMTI0LDcgQEAgZ2RiX3Rl c3QgImhlbHAgZGlzYWJsZSBicmVha3BvaW50cyIgIkRpcwogIyB0ZXN0IGhl bHAgZGlzYWJsZSBkaXNwbGF5CiBnZGJfdGVzdCAiaGVscCBkaXNhYmxlIGRp c3BsYXkiICJEaXNhYmxlIHNvbWUgZXhwcmVzc2lvbnMgdG8gYmUgZGlzcGxh eWVkIHdoZW4gcHJvZ3JhbSBzdG9wc1wuXFtcclxuXF0rQXJndW1lbnRzIGFy ZSB0aGUgY29kZSBudW1iZXJzIG9mIHRoZSBleHByZXNzaW9ucyB0byBzdG9w IGRpc3BsYXlpbmdcLlxbXHJcblxdK05vIGFyZ3VtZW50IG1lYW5zIGRpc2Fi bGUgYWxsIGF1dG9tYXRpYy1kaXNwbGF5IGV4cHJlc3Npb25zXC5cW1xyXG5c XStEbyBcImluZm8gZGlzcGxheVwiIHRvIHNlZSBjdXJyZW50IGxpc3Qgb2Yg Y29kZSBudW1iZXJzXC4iICJoZWxwIGRpc2FibGUgZGlzcGxheSIKICMgdGVz dCBoZWxwIGRpc2Fzc2VtYmxlCi1nZGJfdGVzdCAiaGVscCBkaXNhc3NlbWJs ZSIgIkRpc2Fzc2VtYmxlIGEgc3BlY2lmaWVkIHNlY3Rpb24gb2YgbWVtb3J5 XC5cW1xyXG5cXStEZWZhdWx0IGlzIHRoZSBmdW5jdGlvbiBzdXJyb3VuZGlu ZyB0aGUgcGMgb2YgdGhlIHNlbGVjdGVkIGZyYW1lXC5cW1xyXG5cXStXaXRo IGEgL20gbW9kaWZpZXIsIHNvdXJjZSBsaW5lcyBhcmUgaW5jbHVkZWQgXFwo aWYgYXZhaWxhYmxlXFwpXC5cW1xyXG5cXStXaXRoIGEgL3IgbW9kaWZpZXIs IHJhdyBpbnN0cnVjdGlvbnMgaW4gaGV4IGFyZSBpbmNsdWRlZFwuXFtcclxu XF0rV2l0aCBhIHNpbmdsZSBhcmd1bWVudCwgdGhlIGZ1bmN0aW9uIHN1cnJv dW5kaW5nIHRoYXQgYWRkcmVzcyBpcyBkdW1wZWRcLlxbXHJcblxdK1R3byBh cmd1bWVudHMgYXJlIHRha2VuIGFzIGEgcmFuZ2Ugb2YgbWVtb3J5IHRvIGR1 bXBcLiIgImhlbHAgZGlzYXNzZW1ibGUiCitnZGJfdGVzdCAiaGVscCBkaXNh c3NlbWJsZSIgIkRpc2Fzc2VtYmxlIGEgc3BlY2lmaWVkIHNlY3Rpb24gb2Yg bWVtb3J5XC5cW1xyXG5cXStEZWZhdWx0IGlzIHRoZSBmdW5jdGlvbiBzdXJy b3VuZGluZyB0aGUgcGMgb2YgdGhlIHNlbGVjdGVkIGZyYW1lXC5cW1xyXG5c XStXaXRoIGEgL20gbW9kaWZpZXIsIHNvdXJjZSBsaW5lcyBhcmUgaW5jbHVk ZWQgXFwoaWYgYXZhaWxhYmxlXFwpXC5cW1xyXG5cXStXaXRoIGEgL3IgbW9k aWZpZXIsIHJhdyBpbnN0cnVjdGlvbnMgaW4gaGV4IGFyZSBpbmNsdWRlZFwu XFtcclxuXF0rV2l0aCBhIHNpbmdsZSBhcmd1bWVudCwgdGhlIGZ1bmN0aW9u IHN1cnJvdW5kaW5nIHRoYXQgYWRkcmVzcyBpcyBkdW1wZWRcLlxbXHJcblxd K1R3byBhcmd1bWVudHMgXFwoc2VwYXJhdGVkIGJ5IGNvbW1hXFwpIGFyZSB0 YWtlbiBhcyBhIHJhbmdlIG9mIG1lbW9yeSB0byBkdW1wXC4iICJoZWxwIGRp c2Fzc2VtYmxlIgogIyB0ZXN0IGhlbHAgZGlzcGxheQogZ2RiX3Rlc3QgImhl bHAgZGlzcGxheSIgIlByaW50IHZhbHVlIG9mIGV4cHJlc3Npb24gRVhQIGVh Y2ggdGltZSB0aGUgcHJvZ3JhbSBzdG9wc1wuXFtcclxuXF0rL0ZNVCBtYXkg YmUgdXNlZCBiZWZvcmUgRVhQIGFzIGluIHRoZSBcInByaW50XCIgY29tbWFu ZFwuXFtcclxuXF0rL0ZNVCBcImlcIiBvciBcInNcIiBvciBpbmNsdWRpbmcg YSBzaXplLWxldHRlciBpcyBhbGxvd2VkLFxbXHJcblxdK2FzIGluIHRoZSBc InhcIiBjb21tYW5kLCBhbmQgdGhlbiBFWFAgaXMgdXNlZCB0byBnZXQgdGhl IGFkZHJlc3MgdG8gZXhhbWluZVxbXHJcblxdK2FuZCBleGFtaW5pbmcgaXMg ZG9uZSBhcyBpbiB0aGUgXCJ4XCIgY29tbWFuZFwuXFtcclxuXF0rV2l0aCBu byBhcmd1bWVudCwgZGlzcGxheSBhbGwgY3VycmVudGx5IHJlcXVlc3RlZCBh dXRvLWRpc3BsYXkgZXhwcmVzc2lvbnNcLlxbXHJcblxdK1VzZSBcInVuZGlz cGxheVwiIHRvIGNhbmNlbCBkaXNwbGF5IHJlcXVlc3RzIHByZXZpb3VzbHkg bWFkZVwuIiAiaGVscCBkaXNwbGF5IgogIyB0ZXN0IGhlbHAgZG8K --0016e687869c58df3c0478d6dff5--