From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68535-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24771 invoked by alias); 20 Nov 2009 17:41:52 -0000
Received: (qmail 24762 invoked by uid 22791); 20 Nov 2009 17:41:51 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Nov 2009 17:40:48 +0000
Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com [172.28.16.148]) 	by smtp-out.google.com with ESMTP id nAKHeiMS007014 	for <gdb-patches@sourceware.org>; Fri, 20 Nov 2009 09:40:45 -0800
Received: from pwi9 (pwi9.prod.google.com [10.241.219.9]) 	by spaceape14.eur.corp.google.com with ESMTP id nAKHeVT4021335 	for <gdb-patches@sourceware.org>; Fri, 20 Nov 2009 09:40:41 -0800
Received: by pwi9 with SMTP id 9so2441130pwi.26         for <gdb-patches@sourceware.org>; Fri, 20 Nov 2009 09:40:40 -0800 (PST)
MIME-Version: 1.0
Received: by 10.114.71.20 with SMTP id t20mr2211285waa.205.1258738840871; Fri,  	20 Nov 2009 09:40:40 -0800 (PST)
In-Reply-To: <m3pr7d9ket.fsf@fleche.redhat.com>
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> 	 <m23a4g5fur.fsf@whitebox.home> 	 <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com> 	 <m3my2mtjhp.fsf@fleche.redhat.com> 	 <8ac60eac0911161028of5f2352lf1857db7a46a94b2@mail.gmail.com> 	 <8ac60eac0911191539w4245739ka6405ba072b79395@mail.gmail.com> 	 <m3pr7d9ket.fsf@fleche.redhat.com>
Date: Fri, 20 Nov 2009 17:41:00 -0000
Message-ID: <8ac60eac0911200940t41b09049x1ec583a119be52b7@mail.gmail.com>
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00442.txt.bz2

On Fri, Nov 20, 2009 at 9:27 AM, Tom Tromey <tromey@redhat.com> wrote:

> You probably want to skip whitespace after the ",".

parse_and_eval_address() does it on its own (as
"disas 0x40055a + 1, 0x40055a + 5" demonstrates).

I didn't see the point in adding extra "while (isspace)" loop.

Thanks,
-- 
Paul Pluzhnikov