From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23962 invoked by alias); 15 Nov 2009 17:17:19 -0000 Received: (qmail 23951 invoked by uid 22791); 15 Nov 2009 17:17:17 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 Nov 2009 17:16:13 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id nAFHG95L012623 for ; Sun, 15 Nov 2009 09:16:10 -0800 Received: from pwj9 (pwj9.prod.google.com [10.241.219.73]) by wpaz21.hot.corp.google.com with ESMTP id nAFHG636002153 for ; Sun, 15 Nov 2009 09:16:07 -0800 Received: by pwj9 with SMTP id 9so3045085pwj.11 for ; Sun, 15 Nov 2009 09:16:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.9.2 with SMTP id 2mr4344249wai.197.1258305366447; Sun, 15 Nov 2009 09:16:06 -0800 (PST) In-Reply-To: References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> Date: Sun, 15 Nov 2009 17:17:00 -0000 Message-ID: <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com> Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'" From: Paul Pluzhnikov To: Andreas Schwab Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00332.txt.bz2 On Sun, Nov 15, 2009 at 12:53 AM, Andreas Schwab wrote: > Looks like the comment is now obsolete? No, not really: (top-gdb) disas &main+1 &main+5 Dump of assembler code from 0x453c39 to 0x453c3d: 0x0000000000453c39 : mov %rsp,%rbp 0x0000000000453c3c : sub $0x30,%rsp End of assembler dump. (top-gdb) disas &main+1 &main + 5 Dump of assembler code from 0x453c39 to 0x453c3d: 0x0000000000453c39 : mov %rsp,%rbp 0x0000000000453c3c : sub $0x30,%rsp End of assembler dump. (top-gdb) disas &main + 1 &main + 5 Argument to arithmetic operation not a number or boolean. The only way I can see to allow general expressions here is to require a separator which can't happen in any expression in any language (semicolon probably comes close), or for parse_expression() to consume as much as it can and set a "end_of_parse" indicator. But perhaps splitting on comma (after skipping any quoted expression -- Foo::bar could have multiple parameters) is "good enough"? That would allow 'disas &main + 1, &main + 5' to work. Thanks, -- Paul Pluzhnikov