From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10564 invoked by alias); 14 Nov 2009 02:04:53 -0000 Received: (qmail 10392 invoked by uid 22791); 14 Nov 2009 02:04:52 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 Nov 2009 02:04:48 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id nAE24jv0019926 for ; Sat, 14 Nov 2009 02:04:45 GMT Received: from pxi1 (pxi1.prod.google.com [10.243.27.1]) by wpaz24.hot.corp.google.com with ESMTP id nAE24gOq012981 for ; Fri, 13 Nov 2009 18:04:42 -0800 Received: by pxi1 with SMTP id 1so2311706pxi.32 for ; Fri, 13 Nov 2009 18:04:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.114.249.24 with SMTP id w24mr861585wah.146.1258164281974; Fri, 13 Nov 2009 18:04:41 -0800 (PST) In-Reply-To: <8ac60eac0911111648yf189469t875002ca5cafbefb@mail.gmail.com> References: <20091112003504.29C4876D6F@ppluzhnikov.mtv.corp.google.com> <20091112004255.GA26101@caradoc.them.org> <8ac60eac0911111648yf189469t875002ca5cafbefb@mail.gmail.com> Date: Sat, 14 Nov 2009 02:04:00 -0000 Message-ID: <8ac60eac0911131804q379d346fwd192d46f5452b314@mail.gmail.com> Subject: Re: [patch] Fix for PR gdb/10838 From: Paul Pluzhnikov To: Paul Pluzhnikov , gdb-patches@sourceware.org Cc: Doug Evans Content-Type: multipart/mixed; boundary=0016e64cda8c189edb04784b33fe X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00325.txt.bz2 --0016e64cda8c189edb04784b33fe Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1407 2009/11/11 Paul Pluzhnikov : > That was fast :-) Too fast, as it turns out :-( I didn't test the gdbserver part, but this patch introduced a gdbserver crash here: Program terminated with signal 11, Segmentation fault. #0 0x0000000000408b75 in look_up_one_symbol (name=0x7f6dc44ee3a2 "__nptl_threads_events", addrp=0x7fffcce720c8) at ../../../src/gdb/gdbserver/remote-utils.c:1374 1374 for (sym = proc->symbol_cache; sym; sym = sym->next) proc is NULL. Called from: #0 0x0000000000408b75 in look_up_one_symbol () at ../../../src/gdb/gdbserver/remote-utils.c:1374 #1 0x000000000041ae0e in ps_pglobal_lookup () at ../../../src/gdb/gdbserver/proc-service.c:68 #2 0x00007f6dc44ed60d in td_ta_clear_event () from /lib/libthread_db.so.1 #3 0x000000000041ac8b in thread_db_free (proc=0x6311a0) at ../../../src/gdb/gdbserver/thread-db.c:773 #4 0x0000000000411b44 in linux_remove_process (process=0x6311a0) at ../../../src/gdb/gdbserver/linux-low.c:267 Attached patch fixes that (tested with gdbserver on Linux/x86_64 this time). The gdb.mi/mi-non-stop-exit.exp test is still failing (regression since 2009-10-27), but apparently for a different reason. Thanks, -- Paul Pluzhnikov 2009-11-13 Paul Pluzhnikov * proc-service.c (ps_pglobal_lookup): Handle error return * remote-utils.c (look_up_one_symbol): Don't crash if the process is gone. --0016e64cda8c189edb04784b33fe Content-Type: text/plain; charset=US-ASCII; name="gdbserver-crash-20091113.txt" Content-Disposition: attachment; filename="gdbserver-crash-20091113.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g1zovccl0 Content-length: 1656 SW5kZXg6IGdkYnNlcnZlci9wcm9jLXNlcnZpY2UuYwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2dkYnNlcnZl ci9wcm9jLXNlcnZpY2UuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xNApk aWZmIC11IC1wIC11IC1yMS4xNCBwcm9jLXNlcnZpY2UuYwotLS0gZ2Ric2Vy dmVyL3Byb2Mtc2VydmljZS5jCTEzIE9jdCAyMDA5IDEzOjUxOjIxIC0wMDAw CTEuMTQKKysrIGdkYnNlcnZlci9wcm9jLXNlcnZpY2UuYwkxNCBOb3YgMjAw OSAwMTowNDo0OCAtMDAwMApAQCAtNjUsNyArNjUsNyBAQCBwc19wZ2xvYmFs X2xvb2t1cCAoZ2RiX3BzX3Byb2NoYW5kbGVfdCBwCiB7CiAgIENPUkVfQURE UiBhZGRyOwogCi0gIGlmIChsb29rX3VwX29uZV9zeW1ib2wgKG5hbWUsICZh ZGRyKSA9PSAwKQorICBpZiAobG9va191cF9vbmVfc3ltYm9sIChuYW1lLCAm YWRkcikgPD0gMCkKICAgICByZXR1cm4gUFNfTk9TWU07CiAKICAgKnN5bV9h ZGRyID0gKHBzYWRkcl90KSAodW5zaWduZWQgbG9uZykgYWRkcjsKSW5kZXg6 IGdkYnNlcnZlci9yZW1vdGUtdXRpbHMuYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2dkYnNlcnZlci9yZW1v dGUtdXRpbHMuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS42OApkaWZmIC11 IC1wIC11IC1yMS42OCByZW1vdGUtdXRpbHMuYwotLS0gZ2Ric2VydmVyL3Jl bW90ZS11dGlscy5jCTYgSnVsIDIwMDkgMTg6MzE6MjAgLTAwMDAJMS42OAor KysgZ2Ric2VydmVyL3JlbW90ZS11dGlscy5jCTE0IE5vdiAyMDA5IDAxOjA0 OjQ4IC0wMDAwCkBAIC0xMzY5LDYgKzEzNjksOSBAQCBsb29rX3VwX29uZV9z eW1ib2wgKGNvbnN0IGNoYXIgKm5hbWUsIENPCiAgIHN0cnVjdCBwcm9jZXNz X2luZm8gKnByb2M7CiAKICAgcHJvYyA9IGN1cnJlbnRfcHJvY2VzcyAoKTsK KyAgaWYgKHByb2MgPT0gTlVMTCkKKyAgICAvKiBDb3VsZCBoYXBwZW4gaWYg dGhlIHByb2Nlc3MgaGFzIGp1c3QgZXhpdGVkLiAgKi8KKyAgICByZXR1cm4g LTE7CiAKICAgLyogQ2hlY2sgdGhlIGNhY2hlIGZpcnN0LiAgKi8KICAgZm9y IChzeW0gPSBwcm9jLT5zeW1ib2xfY2FjaGU7IHN5bTsgc3ltID0gc3ltLT5u ZXh0KQo= --0016e64cda8c189edb04784b33fe--