From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5198 invoked by alias); 3 Nov 2009 17:05:23 -0000 Received: (qmail 5132 invoked by uid 22791); 3 Nov 2009 17:05:21 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Nov 2009 17:05:16 +0000 Received: from spaceape14.eur.corp.google.com (spaceape14.eur.corp.google.com [172.28.16.148]) by smtp-out.google.com with ESMTP id nA3H5DMe022145 for ; Tue, 3 Nov 2009 09:05:14 -0800 Received: from pxi35 (pxi35.prod.google.com [10.243.27.35]) by spaceape14.eur.corp.google.com with ESMTP id nA3H59De031872 for ; Tue, 3 Nov 2009 09:05:10 -0800 Received: by pxi35 with SMTP id 35so2709117pxi.18 for ; Tue, 03 Nov 2009 09:05:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.115.27.10 with SMTP id e10mr236910waj.148.1257267908996; Tue, 03 Nov 2009 09:05:08 -0800 (PST) In-Reply-To: <200911031652.32512.pedro@codesourcery.com> References: <20091027221614.3050076B2D@ppluzhnikov.mtv.corp.google.com> <8ac60eac0911030846p6e456d4bh7f6c203ae6f7a97e@mail.gmail.com> <200911031652.32512.pedro@codesourcery.com> Date: Tue, 03 Nov 2009 17:05:00 -0000 Message-ID: <8ac60eac0911030905n28b4291bi5e9bff623761dbd9@mail.gmail.com> Subject: Re: [patch][ob] Fix possible crash in disable_thread_event_reporting From: Paul Pluzhnikov To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00061.txt.bz2 On Tue, Nov 3, 2009 at 8:52 AM, Pedro Alves wrote: >> http://sourceware.org/ml/gdb-patches/2009-10/msg00666.html > > Okay. [OOC, do you have a libc where this function isn't present?] The oldest glibc I have access to is from RedHat-6.2 (glibc-2.1.3-29), and it has all of the "optional" functions: $ nm libthread_db.so.1 | egrep 'td_ta_.*event|get_info' 00002a80 T td_ta_clear_event 00002410 T td_ta_event_addr 00002860 T td_ta_event_getmsg 000027a0 T td_ta_set_event 00001b50 T td_thr_get_info > Since the subject indicated the patch was obvious, I assumed > you had checked it in already. Ah, sorry. It's obvious to me, but I wanted to make sure I am not missing something. I will not mark future patches I want reviewed as obvious. Thanks, -- Paul Pluzhnikov