From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17810 invoked by alias); 27 Oct 2009 21:38:45 -0000 Received: (qmail 17802 invoked by uid 22791); 27 Oct 2009 21:38:44 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Oct 2009 21:38:39 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id n9RLcaOM022649 for ; Tue, 27 Oct 2009 21:38:36 GMT Received: from pxi16 (pxi16.prod.google.com [10.243.27.16]) by wpaz33.hot.corp.google.com with ESMTP id n9RLcXe0018355 for ; Tue, 27 Oct 2009 14:38:33 -0700 Received: by pxi16 with SMTP id 16so115814pxi.3 for ; Tue, 27 Oct 2009 14:38:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.114.86.5 with SMTP id j5mr10947430wab.0.1256679512411; Tue, 27 Oct 2009 14:38:32 -0700 (PDT) In-Reply-To: <8ac60eac0910261425x363afd0bp43299ab0b18e576a@mail.gmail.com> References: <20091015191037.4091D76761@ppluzhnikov.mtv.corp.google.com> <8ac60eac0910171625n489736e1v94326e4d95b40f98@mail.gmail.com> <200910252354.55084.pedro@codesourcery.com> <8ac60eac0910261425x363afd0bp43299ab0b18e576a@mail.gmail.com> Date: Tue, 27 Oct 2009 21:38:00 -0000 Message-ID: <8ac60eac0910271438l117f5fbei14e86b4070e7a05@mail.gmail.com> Subject: Re: [patch] Fix for PR gdb/10757 From: Paul Pluzhnikov To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=00504502e13bef0f550476f17f9a X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00663.txt.bz2 --00504502e13bef0f550476f17f9a Content-Type: text/plain; charset=ISO-8859-1 Content-length: 523 On Mon, Oct 26, 2009 at 2:25 PM, Paul Pluzhnikov wrote: > I'll commit attached patch tomorrow if there are no further comments. So committed. > A similar patch is required for gdbserver as well. Attached. Thanks, -- Paul Pluzhnikov 2009-10-27 Paul Pluzhnikov PR gdb/10757 * thread-db.c (attach_thread): New function. (maybe_attach_thread): Return success/failure. (find_new_threads_callback): Adjust. (thread_db_find_new_threads): Loop until no new threads. --00504502e13bef0f550476f17f9a Content-Type: text/plain; charset=US-ASCII; name="gdbserver-pr10757-20091027.txt" Content-Disposition: attachment; filename="gdbserver-pr10757-20091027.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g1b6d2u51 Content-length: 5653 SW5kZXg6IGdkYnNlcnZlci90aHJlYWQtZGIuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMvZ2RiL2dkYnNlcnZlci90 aHJlYWQtZGIuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yNApkaWZmIC11 IC1wIC11IC1yMS4yNCB0aHJlYWQtZGIuYwotLS0gZ2Ric2VydmVyL3RocmVh ZC1kYi5jCTkgT2N0IDIwMDkgMDA6MzE6MDEgLTAwMDAJMS4yNAorKysgZ2Ri c2VydmVyL3RocmVhZC1kYi5jCTI3IE9jdCAyMDA5IDIxOjEyOjEyIC0wMDAw CkBAIC0yOTcsMTYgKzI5NywxMyBAQCBmaW5kX29uZV90aHJlYWQgKHB0aWRf dCBwdGlkKQogICByZXR1cm4gMTsKIH0KIAotc3RhdGljIHZvaWQKLW1heWJl X2F0dGFjaF90aHJlYWQgKGNvbnN0IHRkX3RocmhhbmRsZV90ICp0aF9wLCB0 ZF90aHJpbmZvX3QgKnRpX3ApCisvKiBBdHRhY2ggYSB0aHJlYWQuICBSZXR1 cm4gdHJ1ZSBvbiBzdWNjZXNzLiAgKi8KKworc3RhdGljIGludAorYXR0YWNo X3RocmVhZCAoY29uc3QgdGRfdGhyaGFuZGxlX3QgKnRoX3AsIHRkX3Rocmlu Zm9fdCAqdGlfcCkKIHsKLSAgdGRfZXJyX2UgZXJyOwogICBzdHJ1Y3QgbHdw X2luZm8gKmx3cDsKIAotICBsd3AgPSBmaW5kX2x3cF9waWQgKHBpZF90b19w dGlkICh0aV9wLT50aV9saWQpKTsKLSAgaWYgKGx3cCAhPSBOVUxMKQotICAg IHJldHVybjsKLQogICBpZiAoZGVidWdfdGhyZWFkcykKICAgICBmcHJpbnRm IChzdGRlcnIsICJBdHRhY2hpbmcgdG8gdGhyZWFkICVsZCAoTFdQICVkKVxu IiwKIAkgICAgIHRpX3AtPnRpX3RpZCwgdGlfcC0+dGlfbGlkKTsKQEAgLTMx Niw3ICszMTMsNyBAQCBtYXliZV9hdHRhY2hfdGhyZWFkIChjb25zdCB0ZF90 aHJoYW5kbGVfCiAgICAgewogICAgICAgd2FybmluZyAoIkNvdWxkIG5vdCBh dHRhY2ggdG8gdGhyZWFkICVsZCAoTFdQICVkKVxuIiwKIAkgICAgICAgdGlf cC0+dGlfdGlkLCB0aV9wLT50aV9saWQpOwotICAgICAgcmV0dXJuOworICAg ICAgcmV0dXJuIDA7CiAgICAgfQogCiAgIGx3cC0+dGhyZWFkX2tub3duID0g MTsKQEAgLTMyNCwxMiArMzIxLDM5IEBAIG1heWJlX2F0dGFjaF90aHJlYWQg KGNvbnN0IHRkX3RocmhhbmRsZV8KIAogICBpZiAodGhyZWFkX2RiX3VzZV9l dmVudHMpCiAgICAgeworICAgICAgdGRfZXJyX2UgZXJyOwogICAgICAgc3Ry dWN0IHRocmVhZF9kYiAqdGhyZWFkX2RiID0gY3VycmVudF9wcm9jZXNzICgp LT5wcml2YXRlLT50aHJlYWRfZGI7CisKICAgICAgIGVyciA9IHRocmVhZF9k Yi0+dGRfdGhyX2V2ZW50X2VuYWJsZV9wICh0aF9wLCAxKTsKICAgICAgIGlm IChlcnIgIT0gVERfT0spCiAJZXJyb3IgKCJDYW5ub3QgZW5hYmxlIHRocmVh ZCBldmVudCByZXBvcnRpbmcgZm9yICVkOiAlcyIsCiAJICAgICAgIHRpX3At PnRpX2xpZCwgdGhyZWFkX2RiX2Vycl9zdHIgKGVycikpOwogICAgIH0KKwor ICByZXR1cm4gMTsKK30KKworLyogQXR0YWNoIHRocmVhZCBpZiB3ZSBoYXZl bid0IHNlZW4gaXQgeWV0LgorICAgSW5jcmVtZW50ICpDT1VOVEVSIGlmIHdl IGhhdmUgYXR0YWNoZWQgYSBuZXcgdGhyZWFkLgorICAgUmV0dXJuIGZhbHNl IG9uIGZhaWx1cmUuICAqLworCitzdGF0aWMgaW50CittYXliZV9hdHRhY2hf dGhyZWFkIChjb25zdCB0ZF90aHJoYW5kbGVfdCAqdGhfcCwgdGRfdGhyaW5m b190ICp0aV9wLAorCQkgICAgIGludCAqY291bnRlcikKK3sKKyAgc3RydWN0 IGx3cF9pbmZvICpsd3A7CisKKyAgbHdwID0gZmluZF9sd3BfcGlkIChwaWRf dG9fcHRpZCAodGlfcC0+dGlfbGlkKSk7CisgIGlmIChsd3AgIT0gTlVMTCkK KyAgICByZXR1cm4gMTsKKworICBpZiAoIWF0dGFjaF90aHJlYWQgKHRoX3As IHRpX3ApKQorICAgIHJldHVybiAwOworCisgIGlmIChjb3VudGVyICE9IE5V TEwpCisgICAgKmNvdW50ZXIgKz0gMTsKKworICByZXR1cm4gMTsKIH0KIAog c3RhdGljIGludApAQCAtMzQ3LDcgKzM3MSwxMiBAQCBmaW5kX25ld190aHJl YWRzX2NhbGxiYWNrIChjb25zdCB0ZF90aHJoCiAgIGlmICh0aS50aV9zdGF0 ZSA9PSBURF9USFJfVU5LTk9XTiB8fCB0aS50aV9zdGF0ZSA9PSBURF9USFJf Wk9NQklFKQogICAgIHJldHVybiAwOwogCi0gIG1heWJlX2F0dGFjaF90aHJl YWQgKHRoX3AsICZ0aSk7CisgIGlmICghbWF5YmVfYXR0YWNoX3RocmVhZCAo dGhfcCwgJnRpLCAoaW50ICopIGRhdGEpKQorICAgIHsKKyAgICAgIC8qIFRl cm1pbmF0ZSBpdGVyYXRpb24gZWFybHk6IHdlIG1pZ2h0IGJlIGxvb2tpbmcg YXQgc3RhbGUgZGF0YSBpbgorCSB0aGUgaW5mZXJpb3IuICBUaGUgdGhyZWFk X2RiX2ZpbmRfbmV3X3RocmVhZHMgd2lsbCByZXRyeS4gICovCisgICAgICBy ZXR1cm4gMTsKKyAgICB9CiAKICAgcmV0dXJuIDA7CiB9CkBAIC0zNTgsNiAr Mzg3LDcgQEAgdGhyZWFkX2RiX2ZpbmRfbmV3X3RocmVhZHMgKHZvaWQpCiAg IHRkX2Vycl9lIGVycjsKICAgcHRpZF90IHB0aWQgPSAoKHN0cnVjdCBpbmZl cmlvcl9saXN0X2VudHJ5ICopIGN1cnJlbnRfaW5mZXJpb3IpLT5pZDsKICAg c3RydWN0IHRocmVhZF9kYiAqdGhyZWFkX2RiID0gY3VycmVudF9wcm9jZXNz ICgpLT5wcml2YXRlLT50aHJlYWRfZGI7CisgIGludCBsb29wLCBpdGVyYXRp b247CiAKICAgLyogVGhpcyBmdW5jdGlvbiBpcyBvbmx5IGNhbGxlZCB3aGVu IHdlIGZpcnN0IGluaXRpYWxpemUgdGhyZWFkX2RiLgogICAgICBGaXJzdCBs b2NhdGUgdGhlIGluaXRpYWwgdGhyZWFkLiAgSWYgaXQgaXMgbm90IHJlYWR5 IGZvcgpAQCAtMzY1LDExICszOTUsMzAgQEAgdGhyZWFkX2RiX2ZpbmRfbmV3 X3RocmVhZHMgKHZvaWQpCiAgIGlmIChmaW5kX29uZV90aHJlYWQgKHB0aWQp ID09IDApCiAgICAgcmV0dXJuOwogCi0gIC8qIEl0ZXJhdGUgb3ZlciBhbGwg dXNlci1zcGFjZSB0aHJlYWRzIHRvIGRpc2NvdmVyIG5ldyB0aHJlYWRzLiAg Ki8KLSAgZXJyID0gdGhyZWFkX2RiLT50ZF90YV90aHJfaXRlcl9wICh0aHJl YWRfZGItPnRocmVhZF9hZ2VudCwKLQkJCQkgICAgIGZpbmRfbmV3X3RocmVh ZHNfY2FsbGJhY2ssIE5VTEwsCi0JCQkJICAgICBURF9USFJfQU5ZX1NUQVRF LCBURF9USFJfTE9XRVNUX1BSSU9SSVRZLAotCQkJCSAgICAgVERfU0lHTk9f TUFTSywgVERfVEhSX0FOWV9VU0VSX0ZMQUdTKTsKKyAgLyogUmVxdWlyZSA0 IHN1Y2Nlc3NpdmUgaXRlcmF0aW9ucyB3aGljaCBkbyBub3QgZmluZCBhbnkg bmV3IHRocmVhZHMuCisgICAgIFRoZSA0IGlzIGEgaGV1cmlzdGljOiB0aGVy ZSBpcyBhbiBpbmhlcmVudCByYWNlIGhlcmUsIGFuZCBJIGhhdmUKKyAgICAg c2VlbiB0aGF0IDIgaXRlcmF0aW9ucyBpbiBhIHJvdyBhcmUgbm90IGFsd2F5 cyBzdWZmaWNpZW50IHRvCisgICAgICJjYXB0dXJlIiBhbGwgdGhyZWFkcy4g ICovCisgIGZvciAobG9vcCA9IDAsIGl0ZXJhdGlvbiA9IDA7IGxvb3AgPCA0 OyArK2xvb3AsICsraXRlcmF0aW9uKQorICAgIHsKKyAgICAgIGludCBuZXdf dGhyZWFkX2NvdW50ID0gMDsKKworICAgICAgLyogSXRlcmF0ZSBvdmVyIGFs bCB1c2VyLXNwYWNlIHRocmVhZHMgdG8gZGlzY292ZXIgbmV3IHRocmVhZHMu ICAqLworICAgICAgZXJyID0gdGhyZWFkX2RiLT50ZF90YV90aHJfaXRlcl9w ICh0aHJlYWRfZGItPnRocmVhZF9hZ2VudCwKKwkJCQkJIGZpbmRfbmV3X3Ro cmVhZHNfY2FsbGJhY2ssCisJCQkJCSAmbmV3X3RocmVhZF9jb3VudCwKKwkJ CQkJIFREX1RIUl9BTllfU1RBVEUsIFREX1RIUl9MT1dFU1RfUFJJT1JJVFks CisJCQkJCSBURF9TSUdOT19NQVNLLCBURF9USFJfQU5ZX1VTRVJfRkxBR1Mp OworICAgICAgaWYgKGRlYnVnX3RocmVhZHMpCisJZnByaW50ZiAoc3RkZXJy LCAiRm91bmQgJWQgdGhyZWFkcyBpbiBpdGVyYXRpb24gJWQuXG4iLAorCQkg bmV3X3RocmVhZF9jb3VudCwgaXRlcmF0aW9uKTsKKworICAgICAgaWYgKG5l d190aHJlYWRfY291bnQgIT0gMCkKKwl7CisJICAvKiBGb3VuZCBuZXcgdGhy ZWFkcy4gIFJlc3RhcnQgaXRlcmF0aW9uIGZyb20gYmVnaW5uaW5nLiAgKi8K KwkgIGxvb3AgPSAtMTsKKwl9CisgICAgfQogICBpZiAoZXJyICE9IFREX09L KQogICAgIGVycm9yICgiQ2Fubm90IGZpbmQgbmV3IHRocmVhZHM6ICVzIiwg dGhyZWFkX2RiX2Vycl9zdHIgKGVycikpOwogfQo= --00504502e13bef0f550476f17f9a--