Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Michael Snyder <msnyder@vmware.com>,
	        Joel Brobecker <brobecker@adacore.com>,
	        "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] New testes for process record save/restore commands
Date: Fri, 23 Oct 2009 14:07:00 -0000	[thread overview]
Message-ID: <8ac60eac0910230707kbf075e0sea197c23bfd2231a@mail.gmail.com> (raw)
In-Reply-To: <daef60380910222356k23ebacabn49d1b1ec7995f6c9@mail.gmail.com>

On Thu, Oct 22, 2009 at 11:56 PM, Hui Zhu <teawater@gmail.com> wrote:

> I checked the consecutive-precsave.exp, this issue is because:
> x /2i $pc
> => 0x8048377 <foo+3>:   mov    0x80495a4,%edx
>   0x804837d <foo+9>:   mov    0x80495a8,%eax
>
> This is the new feature of gdb from Paul.
>
> Paul, could you add a switch for this "=>"?

When I was fixing these tests:

  2009-10-20  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* gdb.base/consecutive.exp: Adjust.
	* gdb.base/display.exp: Likewise.
	* gdb.base/pc-fp.exp: Likewise.
	* gdb.base/sigbpt.exp: Likewise.

I did think about making the '=> ' marker optional, but rejected the
idea: it seems that the only context where you'd really want to turn
it off is the test suite.

OTOH, Daniel Jacobowitz did write on Mon, 19 Oct 2009 14:48:53 -0400:

> For whatever it's worth, I miss the extra screen real estate stolen by
> the enlarged prompt (or even the narrower prompt).

so I'll take a vote.

The 'set print program-counter-marker on/off' feature itself is
trivial to implement, I believe.

Thanks,
-- 
Paul Pluzhnikov


  reply	other threads:[~2009-10-23 14:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-19 19:51 Michael Snyder
2009-10-19 20:03 ` Joel Brobecker
2009-10-20  5:23   ` Joel Brobecker
2009-10-22 19:59   ` Michael Snyder
2009-10-23  6:56     ` Hui Zhu
2009-10-23 14:07       ` Paul Pluzhnikov [this message]
2009-10-26  8:51         ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ac60eac0910230707kbf075e0sea197c23bfd2231a@mail.gmail.com \
    --to=ppluzhnikov@google.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox