From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31157 invoked by alias); 22 Oct 2009 18:31:49 -0000 Received: (qmail 30878 invoked by uid 22791); 22 Oct 2009 18:31:47 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Oct 2009 18:31:38 +0000 Received: from spaceape24.eur.corp.google.com (spaceape24.eur.corp.google.com [172.28.16.76]) by smtp-out.google.com with ESMTP id n9MIVZtx019356 for ; Thu, 22 Oct 2009 11:31:35 -0700 Received: from ywh31 (ywh31.prod.google.com [10.192.8.31]) by spaceape24.eur.corp.google.com with ESMTP id n9MIVWg1011304 for ; Thu, 22 Oct 2009 11:31:32 -0700 Received: by ywh31 with SMTP id 31so12864649ywh.30 for ; Thu, 22 Oct 2009 11:31:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.186.12 with SMTP id n12mr1565265anp.111.1256236291823; Thu, 22 Oct 2009 11:31:31 -0700 (PDT) In-Reply-To: References: <8ac60eac0910212148w24f44d53xfa6bedd7e12b41d1@mail.gmail.com> <20091022054758.GA15116@host0.dyn.jankratochvil.net> <8ac60eac0910212314h3517ff9btcad84f8d0978bddb@mail.gmail.com> <200910221142.55021.pedro@codesourcery.com> <8ac60eac0910220833v96b75i379486328b8f7955@mail.gmail.com> <8ac60eac0910220929v4cad21b4gcf706be716b13771@mail.gmail.com> Date: Thu, 22 Oct 2009 18:31:00 -0000 Message-ID: <8ac60eac0910221131h7424ed4fpbcf4036058621162@mail.gmail.com> Subject: Re: [patch] Fix for PR gdb/10819 From: Paul Pluzhnikov To: tromey@redhat.com Cc: Andreas Schwab , Pedro Alves , gdb-patches@sourceware.org, Jan Kratochvil Content-Type: multipart/mixed; boundary=001636c9297bed994504768a4d6f X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00531.txt.bz2 --001636c9297bed994504768a4d6f Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 692 On Thu, Oct 22, 2009 at 10:43 AM, Tom Tromey wrote: > Paul> + =A0/* See comment in dwarf2-frame.c:find_cie on why this check > Paul> + =A0 =A0 is necessary. =A0*/ > > I'm not ok with this comment; references like this are fragile because > the referenced comment may change without anybody knowing to update this > one. How about this one then? Tested on Linux/x86_64, no regressions. Thanks, --=20 Paul Pluzhnikov 2009-10-22 Paul Pluzhnikov PR gdb/10819 * dwarf2-frame.c (find_cie): Don't call bsearch on empty cie_table. * objfiles.c (find_pc_section): Likewise. (update_section_map): Don't allocate empty table. --001636c9297bed994504768a4d6f Content-Type: text/plain; charset=US-ASCII; name="gdb-pr10819-20091022-3.txt" Content-Disposition: attachment; filename="gdb-pr10819-20091022-3.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g13umuyt0 Content-length: 2546 SW5kZXg6IGR3YXJmMi1mcmFtZS5jCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K UkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvZHdhcmYyLWZyYW1lLmMsdgpy ZXRyaWV2aW5nIHJldmlzaW9uIDEuMTAwCmRpZmYgLXUgLXAgLXUgLXIxLjEw MCBkd2FyZjItZnJhbWUuYwotLS0gZHdhcmYyLWZyYW1lLmMJNiBPY3QgMjAw OSAyMzoyNzowNCAtMDAwMAkxLjEwMAorKysgZHdhcmYyLWZyYW1lLmMJMjIg T2N0IDIwMDkgMTg6MjY6MzEgLTAwMDAKQEAgLTE1MjUsNiArMTUyNSwxNCBA QCBmaW5kX2NpZSAoc3RydWN0IGR3YXJmMl9jaWVfdGFibGUgKmNpZV90CiB7 CiAgIHN0cnVjdCBkd2FyZjJfY2llICoqcF9jaWU7CiAKKyAgLyogVGhlIEMg c3RhbmRhcmQgKElTTy9JRUMgOTg5OTpUQzIpIHJlcXVpcmVzIHRoZSBCQVNF IGFyZ3VtZW50IHRvCisgICAgIGJzZWFyY2ggYmUgbm9uLU5VTEwuICAqLwor ICBpZiAoY2llX3RhYmxlLT5lbnRyaWVzID09IE5VTEwpCisgICAgeworICAg ICAgZ2RiX2Fzc2VydCAoY2llX3RhYmxlLT5udW1fZW50cmllcyA9PSAwKTsK KyAgICAgIHJldHVybiBOVUxMOworICAgIH0KKwogICBwX2NpZSA9IGJzZWFy Y2ggKCZjaWVfcG9pbnRlciwgY2llX3RhYmxlLT5lbnRyaWVzLCBjaWVfdGFi bGUtPm51bV9lbnRyaWVzLAogICAgICAgICAgICAgICAgICAgIHNpemVvZiAo Y2llX3RhYmxlLT5lbnRyaWVzWzBdKSwgYnNlYXJjaF9jaWVfY21wKTsKICAg aWYgKHBfY2llICE9IE5VTEwpCkluZGV4OiBvYmpmaWxlcy5jCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvb2Jq ZmlsZXMuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS45OQpkaWZmIC11IC1w IC11IC1yMS45OSBvYmpmaWxlcy5jCi0tLSBvYmpmaWxlcy5jCTE5IE9jdCAy MDA5IDA5OjUxOjQxIC0wMDAwCTEuOTkKKysrIG9iamZpbGVzLmMJMjIgT2N0 IDIwMDkgMTg6MjY6MzEgLTAwMDAKQEAgLTExMTMsNiArMTExMywxNCBAQCB1 cGRhdGVfc2VjdGlvbl9tYXAgKHN0cnVjdCBwcm9ncmFtX3NwYWNlCiAgICAg ICBpZiAoaW5zZXJ0X3NlY3Rpb25fcCAob2JqZmlsZS0+b2JmZCwgcy0+dGhl X2JmZF9zZWN0aW9uKSkKIAlhbGxvY19zaXplICs9IDE7CiAKKyAgLyogVGhp cyBoYXBwZW5zIG9uIGRldGFjaC9hdHRhY2ggKGUuZy4gaW4gZ2RiLmJhc2Uv YXR0YWNoLmV4cCkuICAqLworICBpZiAoYWxsb2Nfc2l6ZSA9PSAwKQorICAg IHsKKyAgICAgICpwbWFwID0gTlVMTDsKKyAgICAgICpwbWFwX3NpemUgPSAw OworICAgICAgcmV0dXJuOworICAgIH0KKwogICBtYXAgPSB4bWFsbG9jIChh bGxvY19zaXplICogc2l6ZW9mICgqbWFwKSk7CiAKICAgaSA9IDA7CkBAIC0x MTc1LDYgKzExODMsMTQgQEAgZmluZF9wY19zZWN0aW9uIChDT1JFX0FERFIg cGMpCiAgICAgICBwc3BhY2VfaW5mby0+b2JqZmlsZXNfY2hhbmdlZF9wID0g MDsKICAgICB9CiAKKyAgLyogVGhlIEMgc3RhbmRhcmQgKElTTy9JRUMgOTg5 OTpUQzIpIHJlcXVpcmVzIHRoZSBCQVNFIGFyZ3VtZW50IHRvCisgICAgIGJz ZWFyY2ggYmUgbm9uLU5VTEwuICAqLworICBpZiAocHNwYWNlX2luZm8tPnNl Y3Rpb25zID09IE5VTEwpCisgICAgeworICAgICAgZ2RiX2Fzc2VydCAocHNw YWNlX2luZm8tPm51bV9zZWN0aW9ucyA9PSAwKTsKKyAgICAgIHJldHVybiBO VUxMOworICAgIH0KKwogICBzcCA9IChzdHJ1Y3Qgb2JqX3NlY3Rpb24gKiop IGJzZWFyY2ggKCZwYywKIAkJCQkJcHNwYWNlX2luZm8tPnNlY3Rpb25zLAog CQkJCQlwc3BhY2VfaW5mby0+bnVtX3NlY3Rpb25zLAo= --001636c9297bed994504768a4d6f--